App\Repository\ExcuseNoteRepository

Complexity

Total Complexity

9

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	findByStudents()	0	13	1
A	findByStudentsAndDate()	0	16	1
A	persist()	0	3	1
A	findByStudent()	0	4	1
A	remove()	0	3	1
A	removeBetween()	0	9	1
A	getPaginator()	0	28	3

<?php

namespace App\Repository;

use App\Entity\ExcuseNote;
use App\Entity\Student;
use DateTime;
use Doctrine\ORM\Tools\Pagination\Paginator;

class ExcuseNoteRepository extends AbstractRepository implements ExcuseNoteRepositoryInterface {

    public function findByStudent(Student $student): array {
        return $this->em->getRepository(ExcuseNote::class)
            ->findBy([
                'student' => $student
            ]);
    }

    public function findByStudents(array $students): array {
        $studentIds = array_map(fn(Student $student) => $student->getId(), $students);

        $qb = $this->em->createQueryBuilder();
        $qb->select(['n', 's'])
            ->from(ExcuseNote::class, 'n')
            ->leftJoin('n.student', 's')
            ->where(
                $qb->expr()->in('s.id', ':ids')
            )
            ->setParameter('ids', $studentIds);

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function findByStudentsAndDate(array $students, DateTime $date): array {
        $studentIds = array_map(fn(Student $student) => $student->getId(), $students);

        $qb = $this->em->createQueryBuilder();
        $qb->select(['n', 's'])
            ->from(ExcuseNote::class, 'n')
            ->leftJoin('n.student', 's')
            ->where('n.from.date <= :date')
            ->andWhere('n.until.date >= :date')
            ->andWhere(
                $qb->expr()->in('s.id', ':ids')
            )
            ->setParameter('ids', $studentIds)
            ->setParameter('date', $date);

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function persist(ExcuseNote $note): void {
        $this->em->persist($note);
        $this->em->flush();
    }

    public function remove(ExcuseNote $note): void {
        $this->em->remove($note);
        $this->em->flush();
    }

    public function removeBetween(DateTime $start, DateTime $end): int {
        return $this->em->createQueryBuilder()

The expression return $this->em->createQueryBuilder()->delete(App\Entity\ExcuseNote::class, 'e')->where('e.until.date >= :start')->andWhere('e.until.date <= :end')->setParameter('start', $start)->setParameter('end', $end)->getQuery()->execute() could return the type array<mixed,mixed> which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

            ->delete(ExcuseNote::class, 'e')
            ->where('e.until.date >= :start')
            ->andWhere('e.until.date <= :end')
            ->setParameter('start', $start)
            ->setParameter('end', $end)
            ->getQuery()
            ->execute();
    }

    /**
     * @inheritDoc
     */
    public function getPaginator(int $itemsPerPage, int &$page, ?Student $student, DateTime $start, DateTime $end): Paginator {
        $qb = $this->em->createQueryBuilder()
            ->select(['e', 's'])
            ->from(ExcuseNote::class, 'e')
            ->leftJoin('e.student', 's')
            ->where('e.from.date >= :start')
            ->andWhere('e.until.date <= :end')
            ->setParameter('start', $start)
            ->setParameter('end', $end)
            ->orderBy('e.from.date', 'desc');

        if($student !== null) {
            $qb->andWhere('s.id = :student')
                ->setParameter('student', $student->getId());
        }

        if($page < 1) {
            $page = 1;
        }

        $offset = ($page - 1) * $itemsPerPage;

        $paginator = new Paginator($qb);
        $paginator->getQuery()
            ->setMaxResults($itemsPerPage)
            ->setFirstResult($offset);

        return $paginator;
    }
}