InfotextRepository::removeBetween() - Code Metrics - Inspection of "Adds missing migration" - SchulIT/icc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 168c03...b525a2 )

by Marcel

created 2023-06-23 10:37 UTC

InfotextRepository::removeBetween() A

↳ Parent: InfotextRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	2
dl	0
loc	9
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace App\Repository;

use App\Entity\Absence;
use App\Entity\Infotext;
use DateTime;

class InfotextRepository extends AbstractTransactionalRepository implements InfotextRepositoryInterface {

    /**
     * @inheritDoc
     */
    public function findAll(): array {
        return $this->em
            ->getRepository(Infotext::class)
            ->findAll();
    }

    /**
     * @inheritDoc
     */
    public function findAllByDate(DateTime $dateTime): array {
        return $this->em
            ->getRepository(Infotext::class)
            ->findBy([
                'date' => $dateTime
            ]);
    }

    /**
     * @inheritDoc
     */
    public function persist(Infotext $infotext): void {
        $this->em->persist($infotext);
        $this->flushIfNotInTransaction();
    }

    public function removeAll(?DateTime $dateTime = null): void {
        $qb = $this->em->createQueryBuilder()
            ->delete(Infotext::class, 'i');

        if($dateTime !== null) {
            $qb->where('i.date = :date')
                ->setParameter('date', $dateTime);
        }

        $qb->getQuery()
            ->execute();

        $this->flushIfNotInTransaction();
    }

    public function removeBetween(DateTime $start, DateTime $end): int {
        return $this->em->createQueryBuilder()

            ->delete(Infotext::class, 'i')
            ->where('i.date >= :start')
            ->andWhere('i.date <= :end')
            ->setParameter('start', $start)
            ->setParameter('end', $end)
            ->getQuery()
            ->execute();
    }
}

1			<?php
2
3			namespace App\Repository;
4
5			use App\Entity\Absence;
6			use App\Entity\Infotext;
7			use DateTime;
8
9			class InfotextRepository extends AbstractTransactionalRepository implements InfotextRepositoryInterface {
10
11			/**
12			* @inheritDoc
13			*/
14			public function findAll(): array {
15			return $this->em
16			->getRepository(Infotext::class)
17			->findAll();
18			}
19
20			/**
21			* @inheritDoc
22			*/
23			public function findAllByDate(DateTime $dateTime): array {
24			return $this->em
25			->getRepository(Infotext::class)
26			->findBy([
27			'date' => $dateTime
28			]);
29			}
30
31			/**
32			* @inheritDoc
33			*/
34			public function persist(Infotext $infotext): void {
35			$this->em->persist($infotext);
36			$this->flushIfNotInTransaction();
37			}
38
39			public function removeAll(?DateTime $dateTime = null): void {
40			$qb = $this->em->createQueryBuilder()
41			->delete(Infotext::class, 'i');
42
43			if($dateTime !== null) {
44			$qb->where('i.date = :date')
45			->setParameter('date', $dateTime);
46			}
47
48			$qb->getQuery()
49			->execute();
50
51			$this->flushIfNotInTransaction();
52			}
53
54			public function removeBetween(DateTime $start, DateTime $end): int {
55			return $this->em->createQueryBuilder()
			0 ignored issues – show Bug Best Practice introduced 2023-06-23 10:52 UTC by Report Bug Copy Issue Report The expression `return $this->em->create...->getQuery()->execute()` could return the type `array<mixed,mixed>` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
56			->delete(Infotext::class, 'i')
57			->where('i.date >= :start')
58			->andWhere('i.date <= :end')
59			->setParameter('start', $start)
60			->setParameter('end', $end)
61			->getQuery()
62			->execute();
63			}
64			}

SchulIT / icc

Push — master ( 168c03...b525a2 )

InfotextRepository::removeBetween() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like