FreeTimespanRepository::removeBetween() - Code Metrics - Inspection of "Adds missing migration" - SchulIT/icc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 168c03...b525a2 )

by Marcel

created 2023-06-23 10:37 UTC

FreeTimespanRepository::removeBetween() A

↳ Parent: FreeTimespanRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	2
dl	0
loc	9
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace App\Repository;

use App\Entity\FreeTimespan;
use DateTime;

class FreeTimespanRepository extends AbstractTransactionalRepository implements FreeTimespanRepositoryInterface {

    /**
     * @inheritDoc
     */
    public function findAllByDate(DateTime $dateTime): array {
        return $this->em->getRepository(FreeTimespan::class)
            ->findBy([
                'date' => $dateTime
            ]);
    }

    /**
     * @inheritDoc
     */
    public function findAll(): array {
        return $this->em->getRepository(FreeTimespan::class)
            ->findAll();
    }

    public function persist(FreeTimespan $timespan): void {
        $this->em->persist($timespan);
        $this->flushIfNotInTransaction();
    }

    public function removeAll(?DateTime $dateTime): void {
        $qb = $this->em->createQueryBuilder()
            ->delete(FreeTimespan::class, 't');

        if($dateTime !== null) {
            $qb->where('t.date = :date')
                ->setParameter('date', $dateTime);
        }

        $qb
            ->getQuery()
            ->execute();

        $this->flushIfNotInTransaction();
    }

    public function removeBetween(DateTime $start, DateTime $end): int {
        return $this->em->createQueryBuilder()

            ->delete(FreeTimespan::class, 't')
            ->where('t.date >= :start')
            ->andWhere('t.date <= :end')
            ->setParameter('start', $start)
            ->setParameter('end', $end)
            ->getQuery()
            ->execute();
    }
}

1			<?php
2
3			namespace App\Repository;
4
5			use App\Entity\FreeTimespan;
6			use DateTime;
7
8			class FreeTimespanRepository extends AbstractTransactionalRepository implements FreeTimespanRepositoryInterface {
9
10			/**
11			* @inheritDoc
12			*/
13			public function findAllByDate(DateTime $dateTime): array {
14			return $this->em->getRepository(FreeTimespan::class)
15			->findBy([
16			'date' => $dateTime
17			]);
18			}
19
20			/**
21			* @inheritDoc
22			*/
23			public function findAll(): array {
24			return $this->em->getRepository(FreeTimespan::class)
25			->findAll();
26			}
27
28			public function persist(FreeTimespan $timespan): void {
29			$this->em->persist($timespan);
30			$this->flushIfNotInTransaction();
31			}
32
33			public function removeAll(?DateTime $dateTime): void {
34			$qb = $this->em->createQueryBuilder()
35			->delete(FreeTimespan::class, 't');
36
37			if($dateTime !== null) {
38			$qb->where('t.date = :date')
39			->setParameter('date', $dateTime);
40			}
41
42			$qb
43			->getQuery()
44			->execute();
45
46			$this->flushIfNotInTransaction();
47			}
48
49			public function removeBetween(DateTime $start, DateTime $end): int {
50			return $this->em->createQueryBuilder()
			0 ignored issues – show Bug Best Practice introduced 2023-06-23 10:52 UTC by Report Bug Copy Issue Report The expression `return $this->em->create...->getQuery()->execute()` could return the type `array<mixed,mixed>` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
51			->delete(FreeTimespan::class, 't')
52			->where('t.date >= :start')
53			->andWhere('t.date <= :end')
54			->setParameter('start', $start)
55			->setParameter('end', $end)
56			->getQuery()
57			->execute();
58			}
59			}

SchulIT / icc

Push — master ( 168c03...b525a2 )

FreeTimespanRepository::removeBetween() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like