App\Repository\AbsenceRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	findAll()	0	4	1
A	findAllStudyGroups()	0	12	1
A	findAllTeachers()	0	12	1
A	persist()	0	3	1
A	removeAll()	0	14	2
A	findAllStudentsByDateAndLesson()	0	33	1
A	removeBetween()	0	9	1

<?php

namespace App\Repository;

use App\Entity\Absence;
use App\Entity\Student;
use DateTime;

class AbsenceRepository extends AbstractTransactionalRepository implements AbsenceRepositoryInterface {

    public function findAll(): array {
        return $this->em
            ->getRepository(Absence::class)
            ->findAll();
    }

    /**
     * @inheritDoc
     */
    public function findAllTeachers(DateTime $date): array {
        $qb = $this->em->createQueryBuilder();

        $qb
            ->select(['p', 't'])
            ->from(Absence::class, 'p')
            ->leftJoin('p.teacher', 't')
            ->where($qb->expr()->isNotNull('t.id'))
            ->andWhere('p.date = :date')
            ->setParameter('date', $date);

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * @inheritDoc
     */
    public function findAllStudyGroups(DateTime $date): array {
        $qb = $this->em->createQueryBuilder();

        $qb
            ->select('p')
            ->from(Absence::class, 'p')
            ->leftJoin('p.studyGroup', 'sg')
            ->where($qb->expr()->isNotNull('sg.id'))
            ->andWhere('p.date = :date')
            ->setParameter('date', $date);

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * @inheritDoc
     */
    public function findAllStudentsByDateAndLesson(DateTime $dateTime, array $students, int $lesson) {
        $studentIds = array_map(fn(Student $student) => $student->getId(), $students);

        $qb = $this->em->createQueryBuilder();
        $qbInner = $this->em->createQueryBuilder();

        $qbInner
            ->select('sInner.id')
            ->from(Absence::class, 'aInner')
            ->leftJoin('aInner.studyGroup', 'sgInner')
            ->leftJoin('sgInner.memberships', 'mInner')
            ->leftJoin('mInner.student', 'sInner')
            ->where('aInner.date = :date')
            ->andWhere(
                $qb->expr()->orX(
                    $qb->expr()->isNull('aInner.lessonStart'),
                    $qb->expr()->andX(
                        'aInner.lessonStart <= :lesson',
                        'aInner.lessonEnd >= :lesson'
                    )
                )
            );

        $qb
            ->select('s')
            ->from(Student::class, 's')
            ->where($qb->expr()->in('s.id', $qbInner->getDQL()))
            ->andWhere($qb->expr()->in('s.id', ':students'))
            ->setParameter('date', $dateTime)
            ->setParameter('lesson', $lesson)
            ->setParameter('students', $studentIds);

        return $qb->getQuery()->getResult();

The expression return $qb->getQuery()->getResult() also could return the type integer which is incompatible with the return type mandated by App\Repository\AbsenceRepositoryInterface::findAllStudentsByDateAndLesson() of App\Entity\Student[].

    }

    public function persist(Absence $person): void {
        $this->em->persist($person);
        $this->flushIfNotInTransaction();
    }

    public function removeAll(?DateTime $dateTime = null): void {
        $qb = $this->em->createQueryBuilder()
            ->delete(Absence::class, 'p');

        if($dateTime !== null) {
            $qb->where('p.date = :date')
                ->setParameter('date', $dateTime);
        }

        $qb
            ->getQuery()
            ->execute();

        $this->flushIfNotInTransaction();
    }

    public function removeBetween(DateTime $start, DateTime $end): int {
        return $this->em->createQueryBuilder()

The expression return $this->em->createQueryBuilder()->delete(App\Entity\Absence::class, 'a')->where('a.date >= :start')->andWhere('a.date <= :end')->setParameter('start', $start)->setParameter('end', $end)->getQuery()->execute() could return the type array<mixed,mixed> which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

            ->delete(Absence::class, 'a')
            ->where('a.date >= :start')
            ->andWhere('a.date <= :end')
            ->setParameter('start', $start)
            ->setParameter('end', $end)
            ->getQuery()
            ->execute();
    }

}