App\Repository\TuitionGradeRepository

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	persist()	0	3	1
A	findAllByStudent()	0	9	1
A	createDefaultQueryBuilder()	0	7	1
A	findAllByTuition()	0	6	1

<?php

namespace App\Repository;

use App\Entity\Section;
use App\Entity\Student;
use App\Entity\Tuition;
use App\Entity\TuitionGrade;
use Doctrine\ORM\QueryBuilder;

class TuitionGradeRepository extends AbstractTransactionalRepository implements TuitionGradeRepositoryInterface {

    private function createDefaultQueryBuilder(): QueryBuilder {
        return $this->em->createQueryBuilder()
            ->select(['g', 't', 's', 'c'])
            ->from(TuitionGrade::class, 'g')
            ->leftJoin('g.category', 'c')
            ->leftJoin('g.student', 's')
            ->leftJoin('g.tuition', 't');
    }

    public function findAllByTuition(Tuition $tuition): array {
        return $this->createDefaultQueryBuilder()

The expression return $this->createDefaultQueryBuilder()->where('t.id = :tuition')->setParameter('tuition', $tuition->getId())->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->where('t.id = :tuition')
            ->setParameter('tuition', $tuition->getId())
            ->getQuery()
            ->getResult();
    }

    public function findAllByStudent(Student $student, Section $section): array {
        return $this->createDefaultQueryBuilder()

The expression return $this->createDefaultQueryBuilder()->leftJoin('t.section', 'sec')->where('s.id = :student')->andWhere('sec.id = :section')->setParameter('student', $student->getId())->setParameter('section', $section->getId())->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->leftJoin('t.section', 'sec')
            ->where('s.id = :student')
            ->andWhere('sec.id = :section')
            ->setParameter('student', $student->getId())
            ->setParameter('section', $section->getId())
            ->getQuery()
            ->getResult();
    }

    public function persist(TuitionGrade $grade): void {
        $this->em->persist($grade);
        $this->flushIfNotInTransaction();
    }
}