App\Settings\ImportSettings

Complexity

Total Complexity

6

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

40%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getFallbackSection()	0	2	1
A	setFallbackSection()	0	2	1
A	setExamRules()	0	2	1
A	getExamRules()	0	2	1
A	getSubjectsWithoutTuition()	0	2	1
A	setSubjectsWithoutTuition()	0	2	1

<?php

namespace App\Settings;

class ImportSettings extends AbstractSettings {
    public function getExamRules(): array {
        return $this->getValue('import.exam_write_rules', [ ]);

The expression return $this->getValue('import.exam_write_rules', array()) could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function setExamRules(array $rules): void {
        $this->setValue('import.exam_write_rules', $rules);
    }

    public function getFallbackSection(): ?int {
        return $this->getValue('import.fallback_section');
    }

    public function setFallbackSection(?int $sectionId): void {
        $this->setValue('import.fallback_section', $sectionId);
    }

    public function getSubjectsWithoutTuition(): array {
        return $this->getValue('import.subjects_without_tuition', [ ]);

The expression return $this->getValue('import.subjects_without_tuition', array()) could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function setSubjectsWithoutTuition(array $subjects): void {
        $this->setValue('import.subjects_without_tuition', $subjects);
    }
}