App\Validator\DateLessonInSectionValidator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	1	1
A	validate()	0	18	4

<?php

namespace App\Validator;

use App\Entity\DateLesson;
use App\Entity\Section;
use App\Repository\SectionRepositoryInterface;
use App\Section\SectionResolverInterface;
use DateTime;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Exception\UnexpectedTypeException;

class DateLessonInSectionValidator extends ConstraintValidator {

    public function __construct(private readonly SectionResolverInterface $sectionResolver, private readonly SectionRepositoryInterface $sectionRepository) { }

    public function validate(mixed $value, Constraint $constraint) {#
        if(!$value instanceof DateLesson) {
            throw new UnexpectedTypeException($value, DateLesson::class);
        }

        if(!$constraint instanceof DateLessonInSection) {
            throw new UnexpectedTypeException($constraint, DateLessonInSection::class);
        }

        $section = $this->sectionResolver->getSectionForDate($value->getDate());

It seems like $value->getDate() can also be of type null; however, parameter $dateTime of App\Section\SectionResolverInterface::getSectionForDate() does only seem to accept DateTime, maybe add an additional type check?

        if($section === null) {
            $sections = $this->sectionRepository->findAll();

            $this->context
                ->buildViolation($constraint->message)
                ->setParameter('{{ sections }}', implode(', ', array_map(fn(Section $section) => $section->getDisplayName(), $sections)))
                ->addViolation();
        }
    }
}