App\Validator\NoReservationCollisionValidator::validate()

Complexity

Conditions	22
Paths	56

Size

Total Lines	76
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	506

Importance

Changes

0

<?php
    public function validate($value, Constraint $constraint) {
        if(!$constraint instanceof NoReservationCollision) {
            throw new UnexpectedTypeException($constraint, NoReservationCollision::class);
        }

        if(!$value instanceof ResourceReservation && !$value instanceof Exam) {
            throw new UnexpectedTypeException($value, ResourceReservation::class);
        }

        $room = $value instanceof Exam ? $value->getRoom() : $value->getResource();
        $date = $value->getDate();
        $lessonStart = $value->getLessonStart();
        $lessonEnd = $value->getLessonEnd();

        if($room === null || $date === null || $lessonStart <= 0 || $lessonEnd <= 0 || $lessonStart > $lessonEnd) {
            // reservation must be filled with serious information first
            return;
        }

        for($lessonNumber = $lessonStart; $lessonNumber <= $lessonEnd; $lessonNumber++) {
            $availability = $this->availabilityHelper->getAvailability($room, $date, $lessonNumber);

            if($availability === null) {
                continue;
            }

            $timetableLesson = $availability->getTimetableLesson();

            if($timetableLesson !== null && $availability->isTimetableLessonCancelled() === false) {
                $tuition = null;

                if($timetableLesson->getTuition() !== null) {
                    $tuition = $timetableLesson->getTuition()->getName();
                } else {
                    $tuition = $timetableLesson->getSubject();
                }

                $this->context
                    ->buildViolation($constraint->messageTimetable)
                    ->setParameter('{{ tuition }}', $tuition)

It seems like $tuition can also be of type null; however, parameter $value of Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setParameter() does only seem to accept string, maybe add an additional type check?

                    ->setParameter('{{ teacher }}', $this->teacherConverter->convert($timetableLesson->getTeachers()->first()))
                    ->setParameter('{{ lessonNumber }}', (string)$lessonNumber)
                    ->addViolation();
            }

            $substitution = $availability->getSubstitution();

            if($substitution !== null) {
                $this->context
                    ->buildViolation($constraint->messageSubstitution)
                    ->setParameter('{{ lessonNumber }}', (string)$lessonNumber)
                    ->addViolation();
            }

            $existingReservation = $availability->getReservation();

            if($existingReservation !== null && $existingReservation->getId() !== $value->getId()) {
                $this->context
                    ->buildViolation($constraint->messageReservation)
                    ->setParameter('{{ teacher }}', $this->teacherConverter->convert($existingReservation->getTeacher()))
                    ->setParameter('{{ lessonNumber }}', (string)$lessonNumber)
                    ->addViolation();
            }

            $exams = $availability->getExams();

            if(count($exams) > 0) {
                foreach($exams as $collidingExam) {
                    if($value instanceof Exam && $value->getId() === $collidingExam->getId()) {
                        continue;
                    }

                    $this->context
                        ->buildViolation($constraint->messageExam)
                        ->setParameter('{{ lessonNumber }}', (string)$lessonNumber)
                        ->addViolation();
                }
}