App\Controller\PostingsController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	124
Duplicated Lines	20.16 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	5	1
A	add()	0	22	3
A	edit()	0	31	5
B	meta()	25	42	6

<?php

declare(strict_types=1);

/**
 * Saito - The Threaded Web Forum
 *
 * @copyright Copyright (c) the Saito Project Developers
 * @link https://github.com/Schlaefer/Saito
 * @license http://opensource.org/licenses/MIT
 */

namespace App\Controller;

use Api\Controller\ApiAppController;
use App\Model\Entity\Entry;
use App\Model\Table\EntriesTable;
use Cake\Core\Configure;
use Cake\Http\Exception\BadRequestException;
use Cake\Http\Exception\HttpException;
use Cake\Http\Exception\NotFoundException;
use Saito\Exception\SaitoForbiddenException;
use Saito\Posting\PostingInterface;

/**
 * @property EntriesTable $Entries
 */
class PostingsController extends ApiAppController
{
    /**
     * {@inheritDoc}
     */
    public function initialize()
    {
        parent::initialize();
        $this->loadModel('Entries');
    }

    /**
     * Add new posting.
     *
     * @return void
     */
    public function add()
    {
        $data = $this->request->getData();

        /** @var Entry */
        $posting = $this->Entries->createPosting($data, $this->CurrentUser);

It seems like $data defined by $this->request->getData() on line 46 can also be of type null or string; however, App\Model\Table\EntriesTable::createPosting() does only seem to accept array, maybe add an additional type check?

        if (empty($posting)) {
            throw new BadRequestException();
        }

        $errors = $posting->getErrors();

        if (!count($errors)) {
            $this->set(compact('posting'));

            return;
        }

        $this->set(compact('errors'));
        $this->viewBuilder()->setTemplate('/Error/json/entityValidation');
    }

    /**
     * Edit an existing posting
     *
     * @return void
     */
    public function edit()
    {
        $data = $this->request->getData();

        if (empty($data['id'])) {
            throw new BadRequestException('No posting-id provided.');
        }

        $id = $data['id'];
        $posting = $this->Entries->get($id, ['return' => 'Entity']);
        if (!$posting) {
            throw new NotFoundException('Posting not found.');
        }

        $updatedPosting = $this->Entries->updatePosting($posting, $data, $this->CurrentUser);

It seems like $data defined by $this->request->getData() on line 74 can also be of type string; however, App\Model\Table\EntriesTable::updatePosting() does only seem to accept array, maybe add an additional type check?

        if (!$updatedPosting) {
            throw new BadRequestException('Posting could not be saved.');
        }

        if (!$updatedPosting->hasErrors()) {
            $this->set('posting', $updatedPosting);
            $this->render('/Postings/json/add');

            return;
        }

        $errors = $updatedPosting->getErrors();
        $this->set(compact('errors'));
        $this->viewBuilder()->setTemplate('/Error/json/entityValidation');
    }

    /**
     * Serves meta information required to add or edit a posting
     *
     * @return void
     */
    public function meta()
    {
        $id = $this->getRequest()->getQuery('id', null);
        $isEdit = !empty($id);
        $pid = $this->getRequest()->getQuery('pid', null);
        $isAnswer = !empty($pid);

        if ($isAnswer) {

This code seems to be duplicated across your project.

            /** @var PostingInterface */
            $parent = $this->Entries->get($pid);

$pid is of type string|array, but the function expects a integer.

            // Don't leak content of forbidden categories
            if ($parent->isAnsweringForbidden()) {
                throw new SaitoForbiddenException(
                    'Access to parent in PostingsController:meta() forbidden.',
                    ['CurrentUser' => $this->CurrentUser]
                );
            }

            $this->set('parent', $parent);
        }

        if ($isEdit) {

This code seems to be duplicated across your project.

            /** @var PostingInterface */
            $posting = $this->Entries->get($id);

$id is of type string|array, but the function expects a integer.

            if (!$posting->isEditingAllowed()) {
                throw new SaitoForbiddenException(
                    'Access to posting in PostingsController:meta() forbidden.',
                    ['CurrentUser' => $this->CurrentUser]
                );
            }
            $this->set('posting', $posting);
        }

        $settings = Configure::read('Saito.Settings');

        $this->set(compact('isAnswer', 'isEdit', 'settings'));

        $action = $isAnswer ? 'answer' : 'thread';
        $categories = $this->CurrentUser->getCategories()->getAll($action, 'list');
        $this->set('categories', $categories);
    }
}