Schlaefer / Saito

plugins/Admin/src/Controller/CategoriesController.php

Doc Comments +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
     /**
      * add new category
      *
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function add()
     {
@@ -66,7 +66,7 @@ 
      * edit category
      *
      * @param string $id category-ID
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function edit($id)
     {
@@ -106,7 +106,7 @@ 
      *
      * @param string $id category-ID
      *
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function delete($id)
     {

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 
         switch ($this->request->getData('mode')) {
             case ('move'):
-                $targetId = (int)$this->request->getData('targetCategory');
+                $targetId = (int) $this->request->getData('targetCategory');
                 try {
                     $this->Categories->merge($category->get('id'), $targetId);
                     $this->Flash->set(

plugins/Admin/src/Controller/SettingsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
      *
      * @param null $id settings-ID
      *
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function edit($id = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum

plugins/Admin/src/Controller/UsersController.php

Doc Comments +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
     /**
      * add user
      *
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function add()
     {
@@ -68,7 +68,7 @@ 
      * delete user
      *
      * @param string $id user-ID
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function delete($id)
     {

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
      */
     public function delete($id)
     {
-        $id = (int)$id;
+        $id = (int) $id;
         $exists = $this->Users->exists($id);
         if (!$exists) {
             $this->Flash->set(__('User not found.'), ['element' => 'error']);

plugins/BbcodeParser/src/Lib/jBBCode/Definitions/JbbCodeDefinitions.php

Doc Comments +1 added lines

@@ -566,6 +566,7 @@
 
     /**
      * {@inheritDoc}
+     * @param string $content
      */
     protected function _getUrl($content, $attributes)
     {

Spacing +16 added lines, -16 removed lines

@@ -71,7 +71,7 @@ 
             return $this->Html->link($url, $url, ['target' => '_blank']);
         }
 
-        $loader = function () use ($url) {
+        $loader = function() use ($url) {
             $embed = ['url' => $url];
 
             try {
@@ -107,7 +107,7 @@ 
 
         $callable = \Closure::fromCallable($loader);
 
-        $uid = 'embed-' . md5($url);
+        $uid = 'embed-'.md5($url);
         $info = Cache::remember($uid, $callable, 'bbcodeParserEmbed');
 
         return $this->_sHelper->Html->div('js-embed', '', ['id' => $uid, 'data-embed' => json_encode($info)]);
@@ -186,7 +186,7 @@ 
         }
 
         $ad = explode('|', $this->_sOptions->get('video_domains_allowed'));
-        $trim = function ($v) {
+        $trim = function($v) {
             return trim($v);
         };
         $this->_allowedVideoDomains = array_fill_keys(array_map($trim, $ad), 1);
@@ -271,9 +271,9 @@ 
             }
         }
 
-        $out = '<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" width="' . $width . '" height="' . $height . '">
-									<param name="movie" value="' . $url . '"></param>
-									<embed src="' . $url . '" width="' . $width . '" height="' . $height . '" type="application/x-shockwave-flash" wmode="opaque" style="width:' . $width . 'px; height:' . $height . 'px;" id="VideoPlayback" flashvars=""> </embed> </object>';
+        $out = '<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" width="'.$width.'" height="'.$height.'">
+									<param name="movie" value="' . $url.'"></param>
+									<embed src="' . $url.'" width="'.$width.'" height="'.$height.'" type="application/x-shockwave-flash" wmode="opaque" style="width:'.$width.'px; height:'.$height.'px;" id="VideoPlayback" flashvars=""> </embed> </object>';
 
         return $out;
     }
@@ -359,12 +359,12 @@ 
     {
         $listPieces = explode('[*]', $content);
         unset($listPieces[0]);
-        $listPieceProcessor = function ($li) {
-            return '<li>' . $li . '</li>' . "\n";
+        $listPieceProcessor = function($li) {
+            return '<li>'.$li.'</li>'."\n";
         };
         $listPieces = array_map($listPieceProcessor, $listPieces);
 
-        return '<ul>' . implode('', $listPieces) . '</ul>';
+        return '<ul>'.implode('', $listPieces).'</ul>';
     }
 }
 
@@ -386,14 +386,14 @@ 
         }
 
         $title = $this->_mbStrpad(
-            ' ' . __('Spoiler') . ' ',
+            ' '.__('Spoiler').' ',
             $length,
             '▇',
             STR_PAD_BOTH
         );
 
         $json = json_encode(['string' => $content]);
-        $id = 'spoiler_' . rand(0, 9999999999999);
+        $id = 'spoiler_'.rand(0, 9999999999999);
 
         $out = <<<EOF
 <div class="richtext-spoiler" style="display: inline;">
@@ -441,18 +441,18 @@ 
         $result = null;
         $repeat = ceil($strLen - $padStrLen + $padLen);
         if ($dir == STR_PAD_RIGHT) {
-            $result = $str . str_repeat($padStr, $repeat);
+            $result = $str.str_repeat($padStr, $repeat);
             $result = mb_substr($result, 0, $padLen);
         } else {
             if ($dir == STR_PAD_LEFT) {
-                $result = str_repeat($padStr, $repeat) . $str;
+                $result = str_repeat($padStr, $repeat).$str;
                 $result = mb_substr($result, -$padLen);
             } else {
                 if ($dir == STR_PAD_BOTH) {
                     $length = ($padLen - $strLen) / 2;
                     $repeat = ceil($length / $padStrLen);
-                    $result = mb_substr(str_repeat($padStr, $repeat), 0, floor($length)) .
-                        $str .
+                    $result = mb_substr(str_repeat($padStr, $repeat), 0, floor($length)).
+                        $str.
                         mb_substr(str_repeat($padStr, $repeat), 0, ceil($length));
                 }
             }
@@ -487,7 +487,7 @@ 
             'fullBase' => true,
         ];
 
-        $url = '/useruploads/' . $content;
+        $url = '/useruploads/'.$content;
         $image = $this->_sHelper->Html->image($url, $params);
 
         if ($node->getParent()->getTagName() === 'Document') {

plugins/BbcodeParser/src/Lib/Parser.php

Doc Comments +3 added lines, -3 removed lines

@@ -208,7 +208,7 @@ 
      * Constructor
      *
      * @param Helper $Helper helper
-     * @param array $settings settings
+     * @param MarkupSettings $settings settings
      */
     public function __construct(Helper $Helper, MarkupSettings $settings)
     {
@@ -225,7 +225,7 @@ 
      * - `multimedia` bool true|false parse or ignore multimedia content
      * - `embed` bool true|false parse or ignore embed content
      *
-     * @return mixed|string
+     * @return string
      */
     public function parse($string, array $options = [])
     {
@@ -315,7 +315,7 @@ 
      * Add definitin set
      *
      * @param string $set set
-     * @param array $options options
+     * @param MarkupSettings $options options
      *
      * @return void
      * @throws \Exception

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -281,7 +281,7 @@ 
         // serializing complex objects kills PHP
         $serializable = array_filter(
             $options,
-            function ($value) {
+            function($value) {
                 return !is_object($value);
             }
         );
@@ -335,7 +335,7 @@ 
                     $this->_Parser->addCodeDefinition($builder->build());
                     break;
                 case 'class':
-                    $class = '\Plugin\BbcodeParser\src\Lib\jBBCode\Definitions\\' . ucfirst($title);
+                    $class = '\Plugin\BbcodeParser\src\Lib\jBBCode\Definitions\\'.ucfirst($title);
                     $this->_Parser->addCodeDefinition(new $class($this->_Helper, $options));
                     break;
                 default:
@@ -355,10 +355,10 @@ 
             return;
         }
 
-        $folder = __DIR__ . '/jBBCode/Definitions/';
-        require_once $folder . 'JbbCodeDefinitions.php';
-        require_once $folder . 'JbbHtml5MediaCodeDefinition.php';
-        require_once $folder . 'JbbCodeCodeDefinition.php';
+        $folder = __DIR__.'/jBBCode/Definitions/';
+        require_once $folder.'JbbCodeDefinitions.php';
+        require_once $folder.'JbbHtml5MediaCodeDefinition.php';
+        require_once $folder.'JbbCodeCodeDefinition.php';
 
         $this->areCombinedClassFilesLoaded = true;
     }

plugins/Cron/src/Lib/Cron.php

Doc Comments +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
      *
      * @param string $msg message
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function _log($msg)
     {

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
             }
             $jobsExecuted++;
             $job->execute();
-            $this->_log('Run cron-job ' . $job->uid);
+            $this->_log('Run cron-job '.$job->uid);
             $this->_lastRuns[$job->due][$job->uid] = $this->_now;
         }
         if ($jobsExecuted === 0) {

plugins/Feeds/src/View/Helper/FeedsHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     /**
      * Get RssWriter feed
      *
-     * @return Channel
+     * @return Feed
      */
     public function getFeed(): Feed
     {

plugins/Sitemap/src/Lib/SitemapGenerator.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     /**
      * @param string $file filename
-     * @return mixed
+     * @return false|string
      */
     public function content($file)
     {
@@ -94,7 +94,7 @@ 
     /**
      * Creates name for sitemap-file
      *
-     * @param array $params additional name parameters
+     * @param integer[] $params additional name parameters
      * @return string
      */
     protected function _filename($params = [])

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
     {
         $filename = "sitemap-{$this->_type}";
         if ($params) {
-            $filename .= '-' . implode('-', $params);
+            $filename .= '-'.implode('-', $params);
         }
 
         return $filename;

plugins/Stopwatch/src/Lib/Stopwatch.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
     /**
      * time to Cake start
      *
-     * @return mixed
+     * @return double
      */
     protected static function _timeToCake()
     {
@@ -177,7 +177,7 @@ 
     /**
      * time from cake to stopwatch
      *
-     * @return int
+     * @return double
      */
     protected static function _timeFromCakeToStopwatch()
     {

Spacing +8 added lines, -8 removed lines

@@ -141,10 +141,10 @@ 
 
         switch ($event) {
             case 'start':
-                $x = '* ' . $x;
+                $x = '* '.$x;
                 break;
             case 'stop':
-                $x = '† ' . $x;
+                $x = '† '.$x;
                 break;
         }
 
@@ -208,13 +208,13 @@ 
         self::start('now');
 
         $out = "";
-        $out .= 'Time to Cake: ' . sprintf('%05.3f', self::_timeToCake()) . " s\n";
-        $out .= 'Cake bootstrap: ' . sprintf('%05.3f', self::_timeFromCakeToStopwatch()) . " s\n";
+        $out .= 'Time to Cake: '.sprintf('%05.3f', self::_timeToCake())." s\n";
+        $out .= 'Cake bootstrap: '.sprintf('%05.3f', self::_timeFromCakeToStopwatch())." s\n";
 
         $out .= "W\tU\tW_delta\tU_delta\tMem [MB]\n";
         $_seriesIndex = 1;
         foreach (self::$_events as $k => $v) {
-            $out .= '<span id="stopwatch-' . $_seriesIndex++ . '" class="stopwatch-row">';
+            $out .= '<span id="stopwatch-'.$_seriesIndex++.'" class="stopwatch-row">';
             $out .= sprintf(
                 "%05.3f\t%05.3f\t%05.3f\t%05.3f\t%5.1f\t%s\n",
                 $v['wtime'],
@@ -265,7 +265,7 @@ 
             );
         }
 
-        $out .= "\n\n" . self::printStatistic();
+        $out .= "\n\n".self::printStatistic();
 
         return $out;
     }
@@ -354,10 +354,10 @@ 
      */
     public static function printStatistic()
     {
-        return self::$_stopwatchCalls . " calls with ca " . sprintf(
+        return self::$_stopwatchCalls." calls with ca ".sprintf(
             "%05.3f",
             self::$_stopwatchTime
-        ) . ' sec overhead.';
+        ).' sec overhead.';
     }
 
     /**