ImageUploader\Lib\ImageProcessor::resize()

Complexity

Conditions	4
Paths	4

Size

Total Lines	31
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function resize(File $file, int $target): void
    {
        if ($file->getSize() < $target) {
            return;
        }

        $raw = $file->read();

        [$width, $height] = getimagesizefromstring($raw);
        $ratio = $file->getSize() / $target;
        $ratio = sqrt($ratio);

        $newwidth = (int)($width / $ratio);
        $newheight = (int)($height / $ratio);
        $destination = imagecreatetruecolor($newwidth, $newheight);

        $source = imagecreatefromstring($raw);
        imagecopyresized($destination, $source, 0, 0, 0, 0, $newwidth, $newheight, $width, $height);

It seems like $destination can also be of type false; however, parameter $dst_image of imagecopyresized() does only seem to accept resource, maybe add an additional type check?

It seems like $source can also be of type false; however, parameter $src_image of imagecopyresized() does only seem to accept resource, maybe add an additional type check?

        $raw = $destination;

The assignment to $raw is dead and can be removed.

        $type = $file->getMime();
        switch ($type) {
            case 'image/jpeg':
                imagejpeg($destination, $file->getPath());

It seems like $destination can also be of type false; however, parameter $image of imagejpeg() does only seem to accept resource, maybe add an additional type check?

                break;
            case 'image/png':
                imagepng($destination, $file->getPath());

It seems like $destination can also be of type false; however, parameter $image of imagepng() does only seem to accept resource, maybe add an additional type check?

                break;
            default:
                throw new \RuntimeException();
        }