Schlaefer / Saito

plugins/ImageUploader/tests/TestCase/Controller/UploadsControllerTest.php

Unused Use Statements -2 removed lines

@@ -13,13 +13,11 @@
 namespace ImageUploader\Test\TestCase\Controller;
 
 use Api\Error\Exception\GenericApiException;
-use Cake\Cache\Cache;
 use Cake\Core\Configure;
 use Cake\Core\Plugin;
 use Cake\Filesystem\File;
 use Cake\Http\Exception\UnauthorizedException;
 use Cake\ORM\TableRegistry;
-use claviska\SimpleImage;
 use Saito\Exception\SaitoForbiddenException;
 use Saito\Test\IntegrationTestCase;
 

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -72,7 +72,7 @@ 
         $this->loginJwt(1);
 
         $this->upload($this->file);
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -119,7 +119,7 @@ 
             <svg width="9" height="9" style="background:red;"></svg>');
         $this->upload($this->file);
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -176,7 +176,7 @@ 
 
         $this->upload($this->file);
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -236,7 +236,7 @@ 
 
         $this->get('api/v2/uploads');
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -283,7 +283,7 @@ 
 
         $this->delete('api/v2/uploads/1');
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(204);
 

plugins/Installer/tests/TestCase/Controller/UpdaterControllerTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Installer\Test\TestCase\Controller;
 
-use App\Model\Table\SettingsTable;
 use Cake\Core\Configure;
 use Cake\Datasource\ConnectionManager;
 use Cake\Filesystem\File;

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -54,7 +54,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737182);
+        $this->assertResponseContains((string) 1529737182);
     }
 
     public function testUpdaterShowFailureNoDbVersionString()
@@ -64,7 +64,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737397);
+        $this->assertResponseContains((string) 1529737397);
     }
 
     public function testUpdaterShowFailureWrongDbVersionString()
@@ -74,7 +74,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737648);
+        $this->assertResponseContains((string) 1529737648);
     }
 
     public function testUpdaterInitMigrationsFormEmpty()

plugins/Sitemap/src/Lib/SitemapGenerator.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     /**
      * @param string $file filename
-     * @return mixed
+     * @return false|string
      */
     public function content($file)
     {
@@ -94,7 +94,7 @@ 
     /**
      * Creates name for sitemap-file
      *
-     * @param array $params additional name parameters
+     * @param integer[] $params additional name parameters
      * @return string
      */
     protected function _filename($params = [])

plugins/Stopwatch/src/Lib/Stopwatch.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
     /**
      * time to Cake start
      *
-     * @return mixed
+     * @return double
      */
     protected static function _timeToCake()
     {
@@ -177,7 +177,7 @@ 
     /**
      * time from cake to stopwatch
      *
-     * @return int
+     * @return double
      */
     protected static function _timeFromCakeToStopwatch()
     {

src/Auth/CookieAuthenticate.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace App\Auth;
 
 use Cake\Auth\BaseAuthenticate;
-use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Http\Response;
 use Cake\Http\ServerRequest;

src/Controller/Component/SlidetabsComponent.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Controller\Component;
 
 use Cake\Controller\Component;
-use Cake\Core\Configure;
 use Saito\User\ForumsUserInterface;
 
 class SlidetabsComponent extends Component

src/Controller/ContactsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
      * @param Form $contact contact-form
      * @param mixed $recipient recipient
      * @param mixed $sender sender
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     protected function _contact(Form $contact, $recipient, $sender)
     {

Spacing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
                         'subject' => $this->request->getData('subject'),
                         'message' => $this->request->getData('text'),
                         'template' => 'user_contact',
-                        'ccsender' => (bool)$this->request->getData('cc'),
+                        'ccsender' => (bool) $this->request->getData('cc'),
                     ];
                     $this->SaitoEmail->email($email);
                     $message = __('Message was send.');

src/Controller/EntriesController.php

Doc Comments +7 added lines, -7 removed lines

@@ -64,7 +64,7 @@ 
     /**
      * posting index
      *
-     * @return void|\Cake\Network\Response
+     * @return \Cake\Http\Response|null
      */
     public function index()
     {
@@ -111,7 +111,7 @@ 
      * Mix view
      *
      * @param string $tid thread-ID
-     * @return void|Response
+     * @return \Cake\Http\Response|null
      * @throws NotFoundException
      */
     public function mix($tid)
@@ -184,7 +184,7 @@ 
      * View posting.
      *
      * @param string $id posting-ID
-     * @return \Cake\Network\Response|void
+     * @return \Cake\Http\Response|null
      */
     public function view($id = null)
     {
@@ -236,7 +236,7 @@ 
      * Add new posting.
      *
      * @param null|string $id parent-ID if is answer
-     * @return void|\Cake\Network\Response
+     * @return \Cake\Http\Response|null
      * @throws ForbiddenException
      */
     public function add($id = null)
@@ -345,7 +345,7 @@ 
      * Get thread-line to insert after an inline-answer
      *
      * @param string $id posting-ID
-     * @return void|\Cake\Network\Response
+     * @return \Cake\Http\Response|null
      */
     public function threadLine($id = null)
     {
@@ -364,7 +364,7 @@ 
      * Edit posting
      *
      * @param string $id posting-ID
-     * @return void|\Cake\Network\Response
+     * @return \Cake\Http\Response|null
      * @throws NotFoundException
      * @throws BadRequestException
      */
@@ -570,7 +570,7 @@ 
      * @param string $id posting-ID
      * @param string $toggle property
      *
-     * @return \Cake\Network\Response
+     * @return \Cake\Http\Response
      */
     public function ajaxToggle($id = null, $toggle = null)
     {

Spacing +3 added lines, -3 removed lines

@@ -81,7 +81,7 @@ 
         $threads = $this->Threads->paginate($order);
         $this->set('entries', $threads);
 
-        $currentPage = (int)$this->request->getQuery('page') ?: 1;
+        $currentPage = (int) $this->request->getQuery('page') ?: 1;
         if ($currentPage > 1) {
             $this->set('titleForLayout', __('page') . ' ' . $currentPage);
         }
@@ -116,7 +116,7 @@ 
      */
     public function mix($tid)
     {
-        $tid = (int)$tid;
+        $tid = (int) $tid;
         if ($tid <= 0) {
             throw new BadRequestException();
         }
@@ -583,7 +583,7 @@ 
             throw new BadRequestException;
         }
 
-        $current = $this->Entries->toggle((int)$id, $toggle);
+        $current = $this->Entries->toggle((int) $id, $toggle);
         if ($current) {
             $out['html'] = __d('nondynamic', $toggle . '_unset_entry_link');
         } else {

Unused Use Statements -3 removed lines

@@ -9,7 +9,6 @@ 
 
 namespace App\Controller;
 
-use App\Controller\Component\CurrentUserComponent;
 use App\Controller\Component\MarkAsReadComponent;
 use App\Controller\Component\ThreadsComponent;
 use App\Model\Entity\Entry;
@@ -21,9 +20,7 @@ 
 use Cake\Http\Exception\ForbiddenException;
 use Cake\Http\Exception\MethodNotAllowedException;
 use Cake\Http\Exception\NotFoundException;
-use Cake\I18n\Time;
 use Cake\Routing\RequestActionTrait;
-use Saito\App\Registry;
 use Saito\Posting\Posting;
 use Saito\User\CurrentUser\CurrentUserInterface;
 use Saito\User\ForumsUserInterface;

src/Controller/PreviewController.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     /**
      * Generate posting preview for JSON frontend.
      *
-     * @return \Cake\Network\Response|void
+     * @return null|\Cake\Http\Response
      * @throws BadRequestException
      * @throws ForbiddenException
      */