CakeLogEntry::__construct() - Code Metrics - Inspection of "improves code quality" - Schlaefer/Saito - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (c03385)

by Schlaefer

created 2019-06-02 12:54 UTC

CakeLogEntry::__construct() A

↳ Parent: CakeLogEntry

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	17
rs	9.7
c	0
b	0
f	0

<?php

declare(strict_types = 1);

/**
 * Saito - The Threaded Web Forum
 *
 * @copyright Copyright (c) the Saito Project Developers
 * @link https://github.com/Schlaefer/Saito
 * @license http://opensource.org/licenses/MIT
 */

namespace Admin;

/**
 * @bogus the ability to see logs isn't in Saito 5 anymore; see also AdminHelper::formatCakeLog
 */
class CakeLogEntry
{
    /**
     * Constructor
     *
     * @param string $text log entry text
     */
    public function __construct($text)
    {
        $lines = explode("\n", trim($text));
        $_firstLine = array_shift($lines);
        preg_match(
            '/^(\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}) (.*?): (.*)/',
            $_firstLine,
            $matches
        );
        $this->_time = $matches[1];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->_type = $matches[2];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->_message = trim($matches[3]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if (empty($this->_message)) {
            $this->_message = array_shift($lines);
        }
        $this->_detail = implode($lines, '<br>');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Gets log entry time
     *
     * @return string
     */
    public function time()
    {
        return $this->_time;
    }

    /**
     * Gets log entry type
     *
     * @return string
     */
    public function type()
    {
        return $this->_type;
    }

    /**
     * Gets log entry message
     *
     * @return string
     */
    public function message()
    {
        return $this->_message;
    }

    /**
     * Gets log entry details
     *
     * @return string
     */
    public function details()
    {
        return $this->_detail;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			/**
6			* Saito - The Threaded Web Forum
7			*
8			* @copyright Copyright (c) the Saito Project Developers
9			* @link https://github.com/Schlaefer/Saito
10			* @license http://opensource.org/licenses/MIT
11			*/
12
13			namespace Admin;
14
15			/**
16			* @bogus the ability to see logs isn't in Saito 5 anymore; see also AdminHelper::formatCakeLog
17			*/
18			class CakeLogEntry
19			{
20			/**
21			* Constructor
22			*
23			* @param string $text log entry text
24			*/
25			public function __construct($text)
26			{
27			$lines = explode("\n", trim($text));
28			$_firstLine = array_shift($lines);
29			preg_match(
30			'/^(\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}) (.?): (.)/',
31			$_firstLine,
32			$matches
33			);
34			$this->_time = $matches[1];
			0 ignored issues – show Bug introduced 2019-05-10 05:40 UTC by Report Bug Copy Issue Report The property `_time` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			$this->_type = $matches[2];
			0 ignored issues – show Bug introduced 2019-05-10 05:40 UTC by Report Bug Copy Issue Report The property `_type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			$this->_message = trim($matches[3]);
			0 ignored issues – show Bug introduced 2019-05-10 05:40 UTC by Report Bug Copy Issue Report The property `_message` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37			if (empty($this->_message)) {
38			$this->_message = array_shift($lines);
39			}
40			$this->_detail = implode($lines, '<br>');
			0 ignored issues – show Bug introduced 2019-05-10 05:40 UTC by Report Bug Copy Issue Report The property `_detail` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41			}
42
43			/**
44			* Gets log entry time
45			*
46			* @return string
47			*/
48			public function time()
49			{
50			return $this->_time;
51			}
52
53			/**
54			* Gets log entry type
55			*
56			* @return string
57			*/
58			public function type()
59			{
60			return $this->_type;
61			}
62
63			/**
64			* Gets log entry message
65			*
66			* @return string
67			*/
68			public function message()
69			{
70			return $this->_message;
71			}
72
73			/**
74			* Gets log entry details
75			*
76			* @return string
77			*/
78			public function details()
79			{
80			return $this->_detail;
81			}
82			}
83

Schlaefer / Saito

Branch — develop (c03385)

CakeLogEntry::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like