Schlaefer / Saito

src/Model/Table/UsersTable.php

Doc Comments +1 added lines, -1 removed lines

@@ -368,7 +368,7 @@
      * set last refresh
      *
      * @param int $userId user-ID
-     * @param null $lastRefresh last refresh
+     * @param integer $lastRefresh last refresh
      * @return void
      */
     public function setLastRefresh($userId, $lastRefresh = null)

Spacing +4 added lines, -4 removed lines

@@ -77,7 +77,7 @@ 
         $this->addBehavior(
             'Proffer.Proffer',
             [
-                'avatar' => [ // The name of your upload field (filename)
+                'avatar' => [// The name of your upload field (filename)
                     'root' => $avatarRootDir,
                     'dir' => 'avatar_dir', // field for upload directory
                     'thumbnailSizes' => [
@@ -787,8 +787,8 @@ 
             $User->set('user_category_custom', $newCats);
         } else {
             //=if set a single category
-            $category = (int)$category;
-            if ($category > 0 && $this->Entries->Categories->exists((int)$category)
+            $category = (int) $category;
+            if ($category > 0 && $this->Entries->Categories->exists((int) $category)
             ) {
                 $active = $category;
             } else {
@@ -845,7 +845,7 @@ 
             // ->enableHydration(false)
             ->contain(
                 [
-                    'UserIgnores' => function ($query) {
+                    'UserIgnores' => function($query) {
                         return $query->enableHydration(false)->select(
                             ['blocked_user_id', 'user_id']
                         );

src/View/Helper/JsDataHelper.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 
 namespace App\View\Helper;
 
-use App\Controller\Component\CurrentUserComponent;
 use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\View\Helper;

Spacing +5 added lines, -5 removed lines

@@ -61,7 +61,7 @@ 
                 'version' => Configure::read('Saito.v'),
                 'settings' => [
                     'autoPageReload' => (isset($View->viewVars['autoPageReload']) ? $View->viewVars['autoPageReload'] : 0),
-                    'editPeriod' => (int)Configure::read(
+                    'editPeriod' => (int) Configure::read(
                         'Saito.Settings.edit_period'
                     ),
                     'language' => Configure::read('Saito.language'),
@@ -75,9 +75,9 @@ 
                     'quote_symbol' => $settings['quote_symbol'],
                     'subject_maxlength' => $settings['subject_maxlength'],
                     'upload_max_img_size' => $settings['upload_max_img_size'] * 1024,
-                    'upload_max_number_of_uploads' => (int)$settings['upload_max_number_of_uploads'],
+                    'upload_max_number_of_uploads' => (int) $settings['upload_max_number_of_uploads'],
                     'theme' => $View->getTheme(),
-                    'apiroot' => $View->request->getAttribute('webroot') . 'api/v2/',
+                    'apiroot' => $View->request->getAttribute('webroot').'api/v2/',
                     'webroot' => $View->request->getAttribute('webroot')
                 ]
             ],
@@ -89,7 +89,7 @@ 
                 'csrf' => $this->_getCsrf($View)
             ],
             'currentUser' => [
-                'id' => (int)$CurrentUser->get('id'),
+                'id' => (int) $CurrentUser->get('id'),
                 'username' => $CurrentUser->get('username'),
                 'user_show_inline' => $CurrentUser->get('inline_view_on_click') || false,
                 'user_show_thread_collapsed' => $CurrentUser->get('user_show_thread_collapsed') || false
@@ -100,7 +100,7 @@ 
                 'afterViewInit' => []
             ]
         ];
-        $out = 'var SaitoApp = ' . json_encode($js);
+        $out = 'var SaitoApp = '.json_encode($js);
         $out .= '; SaitoApp.timeAppStart = new Date().getTime();';
 
         return $out;

src/View/Helper/ParserHelper.php

Unused Use Statements -2 removed lines

@@ -12,12 +12,10 @@
 
 namespace App\View\Helper;
 
-use Cake\Core\Configure;
 use Geshi\View\Helper\GeshiHelper;
 use Saito\App\Registry;
 use Saito\Markup\Markup;
 use Saito\Markup\MarkupInterface;
-use Saito\Smiley\SmileyRenderer;
 use Stopwatch\Lib\Stopwatch;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -162,7 +162,7 @@ 
         $defaults = ['return' => 'html', 'embed' => true, 'multimedia' => true, 'wrap' => true];
         $options += $defaults;
 
-        $cacheId = md5(serialize($options) . $string);
+        $cacheId = md5(serialize($options).$string);
         if (isset($this->_parserCache[$cacheId])) {
             $html = $this->_parserCache[$cacheId];
         } else {
@@ -170,7 +170,7 @@ 
             $this->_parserCache[$cacheId] = $html;
         }
         if ($options['return'] === 'html' && $options['wrap']) {
-            $html = '<div class="richtext">' . $html . '</div>';
+            $html = '<div class="richtext">'.$html.'</div>';
         }
         Stopwatch::stop('ParseHelper::parse()');
 

Doc Comments +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
     /**
      * get editor help
      *
-     * @return mixed
+     * @return string
      */
     public function editorHelp()
     {

src/View/Helper/UserHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      * Translates user types
      *
      * @param string $type type
-     * @return mixed
+     * @return string|null
      */
     public function type($type)
     {

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Identicon\Identicon;
 use Saito\RememberTrait;
 use Saito\User\ForumsUserInterface;
-use Saito\User\SaitoUser;
 use Stopwatch\Lib\Stopwatch;
 
 /**

Spacing +6 added lines, -6 removed lines

@@ -72,7 +72,7 @@ 
             }
         }
 
-        return '<style type="text/css">' . implode(" ", $styles) . '</style>';
+        return '<style type="text/css">'.implode(" ", $styles).'</style>';
     }
 
     /**
@@ -125,7 +125,7 @@ 
         $link = $url;
 
         if (substr($link, 0, 4) == 'www.') {
-            $link = 'http://' . $link;
+            $link = 'http://'.$link;
         }
         if (substr($link, 0, 4) == 'http') {
             $text = '<i class="fa fa-home fa-lg"></i>';
@@ -160,7 +160,7 @@ 
             $html = $name;
         } elseif ($link || ($link instanceof ForumsUserInterface && $link->isLoggedIn())
         ) {
-            return $this->Html->link($name, '/users/view/' . $id, $options);
+            return $this->Html->link($name, '/users/view/'.$id, $options);
         } else {
             $html = $name;
         }
@@ -180,7 +180,7 @@ 
      */
     public function getAvatar($user, array $options = [])
     {
-        $getAvatar = function () use ($user, $options) {
+        $getAvatar = function() use ($user, $options) {
             Stopwatch::start('UserHelper::getAvatar()');
             $defaults = [
                 'class' => 'avatar-image',
@@ -206,7 +206,7 @@ 
                 $imgUri = (new Identicon)->getImageDataUri($name, $hdpi);
             }
 
-            $style = "background-image: url({$imgUri});" . $options['style'];
+            $style = "background-image: url({$imgUri});".$options['style'];
 
             $html = $this->Html->tag(
                 $options['tag'],
@@ -227,7 +227,7 @@ 
         };
 
         $name = $user->get('username');
-        $hash = 'avatar.' . md5($name . serialize($options));
+        $hash = 'avatar.'.md5($name.serialize($options));
 
         return $this->remember($hash, $getAvatar);
     }

index.php

Spacing +1 added lines, -1 removed lines

@@ -13,4 +13,4 @@
  * @license       https://opensource.org/licenses/mit-license.php MIT License
  */
 
-require 'webroot' . DIRECTORY_SEPARATOR . 'index.php';
+require 'webroot'.DIRECTORY_SEPARATOR.'index.php';

config/Seeds/SmiliesSeed.php

Indentation +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
     public function run()
     {
         $data =
-          [
+            [
             [
                 'id' => 1,
                 'sort' => 1,
@@ -105,7 +105,7 @@ 
                 'sort' => 17,
                 'icon' => 'angry',
             ]
-          ];
+            ];
 
         $table = $this->table('smilies');
         $table->insert($data)->save();

config/saito_config.php

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
          * Is the forum installed? Runs installer if not. Default: run installer.
          */
         'installed' => filter_var(
-            env('INSTALLED', !file_exists(CONFIG . '/installer')),
+            env('INSTALLED', !file_exists(CONFIG.'/installer')),
             FILTER_VALIDATE_BOOLEAN
         ),
         /**
@@ -39,7 +39,7 @@ 
             /**
              * Upload directory root with trailing slash
              */
-            'uploadDirectory' => WWW_ROOT . 'useruploads' . DIRECTORY_SEPARATOR
+            'uploadDirectory' => WWW_ROOT.'useruploads'.DIRECTORY_SEPARATOR
         ],
 
         /**

config/routes.php

Spacing +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
  */
 Router::defaultRouteClass(DashedRoute::class);
 
-Router::scope('/', function (RouteBuilder $routes) {
+Router::scope('/', function(RouteBuilder $routes) {
     /**
      * Here, we are connecting '/' (base path) to a controller called 'Pages',
      * its action called 'display', and we pass a param to select the view file
@@ -96,7 +96,7 @@ 
     $routes->fallbacks(DashedRoute::class);
 });
 
-Router::scope('/entries', function ($routes) {
+Router::scope('/entries', function($routes) {
     $routes->setExtensions(['json']);
     $routes->connect(
         '/threadLine/*',

config/requirements.php

Spacing +3 added lines, -3 removed lines

@@ -21,19 +21,19 @@
  * You can remove this if you are confident that your PHP version is sufficient.
  */
 if (version_compare(PHP_VERSION, '5.6.0') < 0) {
-    trigger_error('Your PHP version must be equal or higher than 5.6.0 to use CakePHP.' . PHP_EOL, E_USER_ERROR);
+    trigger_error('Your PHP version must be equal or higher than 5.6.0 to use CakePHP.'.PHP_EOL, E_USER_ERROR);
 }
 
 /*
  * You can remove this if you are confident you have intl installed.
  */
 if (!extension_loaded('intl')) {
-    trigger_error('You must enable the intl extension to use CakePHP.' . PHP_EOL, E_USER_ERROR);
+    trigger_error('You must enable the intl extension to use CakePHP.'.PHP_EOL, E_USER_ERROR);
 }
 
 /*
  * You can remove this if you are confident you have mbstring installed.
  */
 if (!extension_loaded('mbstring')) {
-    trigger_error('You must enable the mbstring extension to use CakePHP.' . PHP_EOL, E_USER_ERROR);
+    trigger_error('You must enable the mbstring extension to use CakePHP.'.PHP_EOL, E_USER_ERROR);
 }