Schlaefer / Saito

src/Lib/Model/Table/AppTable.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Cake\Database\Expression\QueryExpression;
 use Cake\Event\Event;
 use Cake\Event\EventManager;
-use Cake\ORM\Entity;
 use Cake\ORM\Table;
 use Saito\Event\SaitoEventManager;
 

Spacing +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
      */
     protected function _setting($name)
     {
-        $setting = Configure::read('Saito.Settings.' . $name);
+        $setting = Configure::read('Saito.Settings.'.$name);
         if ($setting !== null) {
             return $setting;
         }

src/Lib/Saito/Event/SaitoEventManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     /**
      * attaches event-listener
      *
-     * @param string|SaitoEventListener $key key
+     * @param \Saito\Cache\EntriesCacheSupportCachelet $key key
      * @param null $callable function if $key is set
      * @return void
      * @throws InvalidArgumentException

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
     {
         $data = ($event->getData()) ?: [];
         $data += ['subject' => $event->getSubject()];
-        $name = 'Event.Saito.' . $event->getName();
+        $name = 'Event.Saito.'.$event->getName();
         $this->dispatch($name, $data);
     }
 

src/Lib/Saito/Exception/SaitoBlackholeException.php

Doc Comments +1 added lines

@@ -9,6 +9,7 @@
 {
     /**
      * {@inheritDoc}
+     * @param string $type
      */
     public function __construct($type = null, $data = [])
     {

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function __construct($type = null, $data = [])
     {
-        $message = 'Request was blackholed. Type: ' . $type;
+        $message = 'Request was blackholed. Type: '.$type;
         $this->__Logger = new ExceptionLogger;
         $this->__Logger->write($message, $data);
         parent::__construct($message, 400);

src/Lib/Saito/Posting/Decorator/UserPostingTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     /**
      * Checks if answering an entry is allowed
      *
-     * @return bool
+     * @return string|boolean
      */
     public function isAnsweringForbidden()
     {

Spacing +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
     {
         if (!$this->isRoot()) {
             throw new \RuntimeException(
-                'Posting with id ' . $this->get('id') . ' is no root posting.'
+                'Posting with id '.$this->get('id').' is no root posting.'
             );
         }
         if (!$this->_CurrentUser->get('last_refresh')) {

src/Lib/Saito/Posting/Posting.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Saito\Posting\Basic\BasicPostingInterface;
 use Saito\Posting\Basic\BasicPostingTrait;
-use Saito\Posting\Decorator\PostingTrait;
 use Saito\Posting\Decorator\UserPostingTrait;
 use Saito\Thread\Thread;
 use Saito\User\CurrentUser\CurrentUser;

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
     {
         $postings = [];
         $this->map(
-            function ($node) use (&$postings) {
+            function($node) use (&$postings) {
                 $postings[$node->get('id')] = $node;
             },
             false

src/Lib/Saito/Smiley/SmileyLoader.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Saito\Smiley;
 
 use Cake\Cache\Cache;
-use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 
 class SmileyLoader

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         if ($this->_smilies !== null) {
             return $this->_smilies;
         }
-        $this->_smilies = Cache::remember('Saito.Smilies.data', function () {
+        $this->_smilies = Cache::remember('Saito.Smilies.data', function() {
             $Smilies = TableRegistry::get('Smilies');
             $smiliesRaw = $Smilies->find()
                 ->contain(['SmileyCodes'])

src/Lib/Saito/Smiley/SmileyRenderer.php

Doc Comments +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
     /**
      * Constructor
      *
-     * @param array $smileyData data
+     * @param SmileyLoader $smileyData data
      */
     public function __construct(SmileyLoader $smileyData)
     {
@@ -61,7 +61,7 @@ 
     /**
      * Set Helper
      *
-     * @param Helper $Helper helper
+     * @param HtmlHelper $Helper helper
      * @return self
      */
     public function setHelper(HtmlHelper $Helper): self
@@ -78,7 +78,7 @@ 
      *
      * @param string $string string
      * @param array $replacements replacements
-     * @return mixed
+     * @return string
      */
     protected function _debug($string, $replacements)
     {

Spacing +4 added lines, -4 removed lines

@@ -132,11 +132,11 @@ 
     {
         $delimiter = '/';
         foreach ($codes['codes'] as $key => $code) {
-            $codes['quoted'][$key] = $delimiter .
+            $codes['quoted'][$key] = $delimiter.
                 // a smiley can't be concatenated to a string and requires a
                 // whitespace in front
-                '(^|(?<=(\s)))' .
-                preg_quote($code, $delimiter) .
+                '(^|(?<=(\s)))'.
+                preg_quote($code, $delimiter).
                 $delimiter;
         }
     }
@@ -167,7 +167,7 @@ 
                 //= pixel image smileys
             } else {
                 $replacements['html'][$k] = $this->HtmlHelper->image(
-                    'smilies/' . $smiley['image'],
+                    'smilies/'.$smiley['image'],
                     [
                         'alt' => $smiley['code'],
                         'class' => 'saito-smiley-image',

src/Lib/Saito/Test/IntegrationTestCase.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 namespace Saito\Test;
 
 use App\Test\Fixture\UserFixture;
-
 use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Event\EventManager;

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -129,7 +129,7 @@ 
         $Mock = $this->getMockForTableParent($table, $methods);
         EventManager::instance()->on(
             'Controller.initialize',
-            function (Event $event) use ($table, $Mock) {
+            function(Event $event) use ($table, $Mock) {
                 $Controller = $event->getSubject();
                 $Controller->{$table} = $Mock;
             }
@@ -153,7 +153,7 @@ 
         $this->configRequest([
             'headers' => [
                 'Accept' => 'application/json',
-                'Authorization' => 'bearer ' . $jwtToken,
+                'Authorization' => 'bearer '.$jwtToken,
             ]
         ]);
     }

src/Lib/Saito/Test/Model/Table/SaitoTableTestCase.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Cake\ORM\Table;
 use Cake\ORM\TableRegistry;
-use Saito\App\Registry;
 use Saito\Test\SaitoTestCase;
-use Saito\User\SaitoUser;
 
 abstract class SaitoTableTestCase extends SaitoTestCase
 {