Schlaefer / Saito

plugins/ImageUploader/src/Model/Table/UploadsTable.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 
 use App\Lib\Model\Table\AppTable;
 use Cake\Core\Configure;
-use Cake\Datasource\EntityInterface;
 use Cake\Event\Event;
 use Cake\Filesystem\File;
 use Cake\ORM\RulesChecker;

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -51,12 +51,12 @@ 
             ->notBlank('user_id')
             ->requirePresence(['name', 'size', 'type', 'user_id'], 'create');
 
-        $maxUploadSize = (int)Configure::read('Saito.Settings.upload_max_img_size');
+        $maxUploadSize = (int) Configure::read('Saito.Settings.upload_max_img_size');
         $validator->add(
             'document',
             [
                 'fileSize' => [
-                    'rule' => ['fileSize', '<', $maxUploadSize . 'kB'],
+                    'rule' => ['fileSize', '<', $maxUploadSize.'kB'],
                     'message' => __d(
                         'image_uploader',
                         'validation.error.fileSize',
@@ -83,9 +83,9 @@ 
     public function buildRules(RulesChecker $rules)
     {
         // check max allowed number of uploads per user
-        $nMax = (int)Configure::read('Saito.Settings.upload_max_number_of_uploads');
+        $nMax = (int) Configure::read('Saito.Settings.upload_max_number_of_uploads');
         $rules->add(
-            function (Upload $entity, array $options) use ($nMax) {
+            function(Upload $entity, array $options) use ($nMax) {
                 $count = $this->findByUserId($entity->get('user_id'))->count();
 
                 return $count < $nMax;
@@ -205,8 +205,8 @@ 
         $ratio = $size / $target;
         $ratio = sqrt($ratio);
 
-        $newwidth = (int)($width / $ratio);
-        $newheight = (int)($height / $ratio);
+        $newwidth = (int) ($width / $ratio);
+        $newheight = (int) ($height / $ratio);
         $destination = imagecreatetruecolor($newwidth, $newheight);
 
         $source = imagecreatefromstring($raw);

plugins/ImageUploader/tests/TestCase/Controller/UploadsControllerTest.php

Unused Use Statements -2 removed lines

@@ -13,13 +13,11 @@
 namespace ImageUploader\Test\TestCase\Controller;
 
 use Api\Error\Exception\GenericApiException;
-use Cake\Cache\Cache;
 use Cake\Core\Configure;
 use Cake\Core\Plugin;
 use Cake\Filesystem\File;
 use Cake\Http\Exception\UnauthorizedException;
 use Cake\ORM\TableRegistry;
-use claviska\SimpleImage;
 use Saito\Exception\SaitoForbiddenException;
 use Saito\Test\IntegrationTestCase;
 

Spacing +11 added lines, -11 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -45,7 +45,7 @@ 
     {
         parent::setUp();
 
-        $this->file = new File(TMP . 'my new-upload.png');
+        $this->file = new File(TMP.'my new-upload.png');
         $this->mockMediaFile($this->file);
     }
 
@@ -73,7 +73,7 @@ 
                 0 => [
                     'file' => [
                         'tmp_name' => $this->file->path,
-                        'name' => $this->file->name() . '.' . $this->file->ext(),
+                        'name' => $this->file->name().'.'.$this->file->ext(),
                         'size' => $this->file->size(),
                         'type' => $this->file->mime(),
                     ]
@@ -82,7 +82,7 @@ 
         ];
         $this->post('api/v2/uploads.json', $data);
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -112,12 +112,12 @@ 
     {
         $this->loginJwt(1);
         unset($this->file);
-        $this->file = new File(TMP . 'tmp_exif.jpg');
+        $this->file = new File(TMP.'tmp_exif.jpg');
 
-        $fixture = new File($path = Plugin::path('ImageUploader') . 'tests/Fixture/exif-with-location.jpg');
+        $fixture = new File($path = Plugin::path('ImageUploader').'tests/Fixture/exif-with-location.jpg');
         $fixture->copy($this->file->path);
 
-        $readExif = function (File $file) {
+        $readExif = function(File $file) {
             //@codingStandardsIgnoreStart
             return @exif_read_data($file->path);
             //@codingStandardsIgnoreEnd
@@ -132,7 +132,7 @@ 
                 0 => [
                     'file' => [
                         'tmp_name' => $this->file->path,
-                        'name' => $this->file->name() . '.' . $this->file->ext(),
+                        'name' => $this->file->name().'.'.$this->file->ext(),
                         'size' => $this->file->size(),
                         'type' => $this->file->mime(),
                     ]
@@ -141,7 +141,7 @@ 
         ];
         $this->post('api/v2/uploads.json', $data);
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -222,7 +222,7 @@ 
 
         $this->get('api/v2/uploads');
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(200);
 
@@ -260,7 +260,7 @@ 
 
         $this->delete('api/v2/uploads/1');
 
-        $response = json_decode((string)$this->_response->getBody(), true);
+        $response = json_decode((string) $this->_response->getBody(), true);
 
         $this->assertResponseCode(204);
 

plugins/Installer/tests/TestCase/Controller/UpdaterControllerTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Installer\Test\TestCase\Controller;
 
-use App\Model\Table\SettingsTable;
 use Cake\Core\Configure;
 use Cake\Datasource\ConnectionManager;
 use Cake\Filesystem\File;

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -35,7 +35,7 @@ 
     public function setUp()
     {
         parent::setUp();
-        $this->token = new File(CONFIG . 'updater');
+        $this->token = new File(CONFIG.'updater');
         $this->dbVersion = (new DbVersion(TableRegistry::get('Settings')));
         Configure::write('Saito.updated', false);
     }
@@ -54,7 +54,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737182);
+        $this->assertResponseContains((string) 1529737182);
     }
 
     public function testUpdaterShowFailureNoDbVersionString()
@@ -64,7 +64,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737397);
+        $this->assertResponseContains((string) 1529737397);
     }
 
     public function testUpdaterShowFailureWrongDbVersionString()
@@ -74,7 +74,7 @@ 
 
         $this->assertResponseOk();
         $this->assertEquals('failure', $this->_controller->viewBuilder()->getTemplate());
-        $this->assertResponseContains((string)1529737648);
+        $this->assertResponseContains((string) 1529737648);
     }
 
     public function testUpdaterInitMigrationsFormEmpty()

plugins/Sitemap/src/Lib/SitemapGenerator.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 
     /**
      * @param string $file filename
-     * @return mixed
+     * @return false|string
      */
     public function content($file)
     {
@@ -94,7 +94,7 @@ 
     /**
      * Creates name for sitemap-file
      *
-     * @param array $params additional name parameters
+     * @param integer[] $params additional name parameters
      * @return string
      */
     protected function _filename($params = [])

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
     {
         $filename = "sitemap-{$this->_type}";
         if ($params) {
-            $filename .= '-' . implode('-', $params);
+            $filename .= '-'.implode('-', $params);
         }
 
         return $filename;

plugins/Stopwatch/src/Lib/Stopwatch.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
     /**
      * time to Cake start
      *
-     * @return mixed
+     * @return double
      */
     protected static function _timeToCake()
     {
@@ -177,7 +177,7 @@ 
     /**
      * time from cake to stopwatch
      *
-     * @return int
+     * @return double
      */
     protected static function _timeFromCakeToStopwatch()
     {

Spacing +8 added lines, -8 removed lines

@@ -141,10 +141,10 @@ 
 
         switch ($event) {
             case 'start':
-                $x = '* ' . $x;
+                $x = '* '.$x;
                 break;
             case 'stop':
-                $x = '† ' . $x;
+                $x = '† '.$x;
                 break;
         }
 
@@ -208,13 +208,13 @@ 
         self::start('now');
 
         $out = "";
-        $out .= 'Time to Cake: ' . sprintf('%05.3f', self::_timeToCake()) . " s\n";
-        $out .= 'Cake bootstrap: ' . sprintf('%05.3f', self::_timeFromCakeToStopwatch()) . " s\n";
+        $out .= 'Time to Cake: '.sprintf('%05.3f', self::_timeToCake())." s\n";
+        $out .= 'Cake bootstrap: '.sprintf('%05.3f', self::_timeFromCakeToStopwatch())." s\n";
 
         $out .= "W\tU\tW_delta\tU_delta\tMem [MB]\n";
         $_seriesIndex = 1;
         foreach (self::$_events as $k => $v) {
-            $out .= '<span id="stopwatch-' . $_seriesIndex++ . '" class="stopwatch-row">';
+            $out .= '<span id="stopwatch-'.$_seriesIndex++.'" class="stopwatch-row">';
             $out .= sprintf(
                 "%05.3f\t%05.3f\t%05.3f\t%05.3f\t%5.1f\t%s\n",
                 $v['wtime'],
@@ -265,7 +265,7 @@ 
             );
         }
 
-        $out .= "\n\n" . self::printStatistic();
+        $out .= "\n\n".self::printStatistic();
 
         return $out;
     }
@@ -354,10 +354,10 @@ 
      */
     public static function printStatistic()
     {
-        return self::$_stopwatchCalls . " calls with ca " . sprintf(
+        return self::$_stopwatchCalls." calls with ca ".sprintf(
             "%05.3f",
             self::$_stopwatchTime
-        ) . ' sec overhead.';
+        ).' sec overhead.';
     }
 
     /**

src/Auth/CookieAuthenticate.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace App\Auth;
 
 use Cake\Auth\BaseAuthenticate;
-use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Http\Response;
 use Cake\Http\ServerRequest;

src/Controller/Component/CurrentUserComponent.php

Unused Use Statements -2 removed lines

@@ -16,7 +16,6 @@ 
 use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\ORM\TableRegistry;
-use Cake\Routing\Router;
 use Cake\Utility\Security;
 use Firebase\JWT\JWT;
 use Saito\App\Registry;
@@ -26,7 +25,6 @@ 
 use Saito\User\CurrentUser\CurrentUserInterface;
 use Saito\User\CurrentUser\CurrentUserTrait;
 use Saito\User\LastRefresh;
-use Saito\User\ReadPostings;
 use Saito\User\ReadPostings\ReadPostingsCookie;
 use Saito\User\ReadPostings\ReadPostingsDatabase;
 use Saito\User\ReadPostings\ReadPostingsDummy;

Spacing +3 added lines, -3 removed lines

@@ -180,7 +180,7 @@ 
         }
 
         //= set persistent Cookie
-        $setCookie = (bool)$this->request->getData('remember_me');
+        $setCookie = (bool) $this->request->getData('remember_me');
         if ($setCookie) {
             (new CurrentUserCookie($this->getController()))->write($this->getId());
         };
@@ -292,7 +292,7 @@ 
         $auth->setConfig('loginAction', '/login');
 
         $here = urlencode($this->getController()->getRequest()->getRequestTarget());
-        $auth->setConfig('unauthorizedRedirect', '/login?redirect=' . $here);
+        $auth->setConfig('unauthorizedRedirect', '/login?redirect='.$here);
 
         if ($this->isLoggedIn()) {
             $auth->allow();
@@ -318,7 +318,7 @@ 
      */
     private function setJwtCookie(Controller $controller): void
     {
-        $cookieKey = Configure::read('Session.cookie') . '-jwt';
+        $cookieKey = Configure::read('Session.cookie').'-jwt';
         $cookie = (new Storage($controller, $cookieKey, ['http' => false, 'expire' => '+1 week']));
 
         $existingToken = $cookie->read();

src/Controller/Component/SlidetabsComponent.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Controller\Component;
 
 use Cake\Controller\Component;
-use Cake\Core\Configure;
 use Saito\User\ForumsUserInterface;
 
 class SlidetabsComponent extends Component

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
             $tabs = $slidetabs;
         }
         $tabs = array_map(
-            function ($v) {
+            function($v) {
                 return $this->_available[$v];
             },
             $tabs

src/Controller/Component/ThreadsComponent.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use Cake\Core\Configure;
 use Cake\ORM\Entity;
 use Cake\ORM\TableRegistry;
-use Cake\Utility\Hash;
 use Saito\App\Registry;
 use Saito\Posting\Posting;
 use Stopwatch\Lib\Stopwatch;

Spacing +2 added lines, -2 removed lines

@@ -80,14 +80,14 @@
             'order' => $order,
             // Performance: Custom counter from categories counter-cache;
             // avoids a costly COUNT(*) DB call counting all pages for pagination.
-            'counter' => function ($query) use ($categories) {
+            'counter' => function($query) use ($categories) {
                 $results = $this->Entries->Categories->find('all')
                 ->select(['thread_count'])
                 ->where(['id IN' => $categories])
                 ->all();
                 $count = array_reduce(
                     $results->toArray(),
-                    function ($carry, Entity $entity) {
+                    function($carry, Entity $entity) {
                         return $carry + $entity->get('thread_count');
                     },
                     0