Schlaefer / Saito

src/Lib/Saito/Test/IntegrationTestCase.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 namespace Saito\Test;
 
 use App\Test\Fixture\UserFixture;
-
 use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Event\EventManager;

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -314,7 +314,7 @@ 
     {
         $this->assertContainsTag(
             $expected,
-            (string)$this->_controller->response->getBody()
+            (string) $this->_controller->response->getBody()
         );
     }
 }

src/Lib/Saito/Test/Model/Table/SaitoTableTestCase.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Cake\ORM\Table;
 use Cake\ORM\TableRegistry;
-use Saito\App\Registry;
 use Saito\Test\SaitoTestCase;
-use Saito\User\SaitoUser;
 
 abstract class SaitoTableTestCase extends SaitoTestCase
 {

src/Lib/Saito/Test/SecurityMockTrait.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Saito\Test;
 
-use Cake\Event\Event;
-use Cake\Event\EventManager;
-
 trait SecurityMockTrait
 {
 

src/Lib/Saito/User/LastRefresh/LastRefreshAbstract.php

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
      * tested if new for user.
      *
      * @param string|\DateTimeInterface $timestamp int unix-timestamp or date as string
-     * @return mixed bool or null if not determinable
+     * @return null|boolean bool or null if not determinable
      */
     public function isNewerThan($timestamp)
     {
@@ -60,7 +60,7 @@ 
     /**
      * Set timestamp.
      *
-     * @param mixed $timestamp null|'now'|<`Y-m-d H:i:s` timestamp>
+     * @param string $timestamp null|'now'|<`Y-m-d H:i:s` timestamp>
      * @return void
      */
     public function set($timestamp = null)

src/Lib/Saito/User/LastRefresh/LastRefreshCookie.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Saito\User\LastRefresh;
 
-use App\Controller\Component\CurrentUserComponent;
 use Saito\User\Cookie;
 
 /**

src/Lib/Saito/User/SaitoUserTrait.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace Saito\User;
 
 use App\Model\Entity\User;
-use Cake\Core\Exception\Exception;
-use Cake\I18n\Time;
 use Cake\Utility\Hash;
 use Saito\App\Registry;
 

Doc Comments +1 added lines

@@ -127,6 +127,7 @@
 
     /**
      * {@inheritDoc}
+     * @return boolean|string
      */
     public function isLoggedIn()
     {

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
         }
 
         if (!empty($settings['id'])) {
-            $this->_id = (int)$settings['id'];
+            $this->_id = (int) $settings['id'];
             $this->_isLoggedIn = true;
         }
 
@@ -139,7 +139,7 @@ 
     public function isUser($user)
     {
         if (is_numeric($user)) {
-            $id = (int)$user;
+            $id = (int) $user;
         } elseif ($user instanceof ForumsUserInterface || $user instanceof User) {
             $id = $user->get('id');
         } else {
@@ -156,7 +156,7 @@ 
      */
     public function isLocked(): bool
     {
-        return (bool)$this->get('user_lock');
+        return (bool) $this->get('user_lock');
     }
 
     /**

src/Lib/Saito/User/Upload/AvatarFilenameListener.php

Unused Use Statements -2 removed lines

@@ -3,11 +3,9 @@
 namespace Saito\User\Upload;
 
 use App\Model\Entity\User;
-use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Event\EventListenerInterface;
 use Cake\Filesystem\Folder;
-use Cake\ORM\Entity;
 use Cake\Utility\Text;
 use Proffer\Lib\ProfferPath;
 

src/Model/Table/EntriesTable.php

Doc Comments +8 added lines, -6 removed lines

@@ -416,7 +416,7 @@ 
      * get parent id
      *
      * @param int $id id
-     * @return mixed
+     * @return integer
      * @throws \UnexpectedValueException
      */
     public function getParentId($id)
@@ -627,7 +627,7 @@ 
     /**
      * trees for multiple tids
      *
-     * @param array $ids ids
+     * @param integer[] $ids ids
      * @param array $order order
      * @param array $fieldlist fieldlist
      * @return array|bool false if no threads or array of Postings
@@ -679,7 +679,7 @@ 
      * @param array $params params
      * - 'fields' array of thread-ids: [1, 2, 5]
      * - 'order' sort order for threads ['time' => 'ASC'],
-     * @return mixed unhydrated result set
+     * @return Query unhydrated result set
      */
     protected function _getThreadEntries(array $tid, array $params = [])
     {
@@ -747,6 +747,8 @@ 
 
     /**
      * {@inheritDoc}
+     * @param integer $id
+     * @param string $key
      */
     public function toggle($id, $key)
     {
@@ -826,7 +828,7 @@ 
      * Anonymizes the entries for a user
      *
      * @param string $userId user-ID
-     * @return bool success
+     * @return integer success
      */
     public function anonymizeEntriesFromUser($userId)
     {
@@ -933,7 +935,7 @@ 
      * Check if posting is thread-root.
      *
      * @param array $id posting-ID or posting data
-     * @return mixed
+     * @return boolean
      */
     protected function _isRoot(array $id)
     {
@@ -1128,7 +1130,7 @@ 
      *
      * @param null $tid thread-ID
      * @param null $newCategoryId id for new category
-     * @return bool success
+     * @return integer success
      * @throws \NotFoundException
      * @throws \InvalidArgumentException
      */

Unused Use Statements -2 removed lines

@@ -19,8 +19,6 @@
 use Cake\Http\Exception\NotFoundException;
 use Cake\ORM\Entity;
 use Cake\ORM\Query;
-use Cake\ORM\RulesChecker;
-use Cake\ORM\TableRegistry;
 use Cake\Validation\Validator;
 use Saito\App\Registry;
 use Saito\Posting\Posting;

Spacing +1 added lines, -1 removed lines

@@ -618,7 +618,7 @@
         $tree = reset($tree);
 
         //= extract subtree
-        if ((int)$tid !== (int)$id) {
+        if ((int) $tid !== (int) $id) {
             $tree = $tree->getThread()->get($id);
         }
 

src/Model/Table/SettingsTable.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
      * Fast version of Set::combine($results, '{n}.Setting.name',
      * '{n}.Setting.value');
      *
-     * @param array $results results
+     * @param Query $results results
      * @return array
      */
     protected function _compactKeyValue($results)

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
 use App\Lib\Model\Table\AppSettingTable;
 use Cake\Cache\Cache;
 use Cake\Core\Configure;
-use Cake\ORM\Query;
-use Saito\App\Registry;
 use \Stopwatch\Lib\Stopwatch;
 
 class SettingsTable extends AppSettingTable

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum