Completed
Push — master ( 5b5792...2b84bd )
by Schlaefer
03:33 queued 11s
created
src/Lib/Saito/User/SaitoUserTrait.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -127,6 +127,7 @@
 block discarded – undo
127 127
 
128 128
     /**
129 129
      * {@inheritDoc}
130
+     * @return boolean|string
130 131
      */
131 132
     public function isLoggedIn()
132 133
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         if (!empty($settings['id'])) {
59
-            $this->_id = (int)$settings['id'];
59
+            $this->_id = (int) $settings['id'];
60 60
             $this->_isLoggedIn = true;
61 61
         }
62 62
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     public function isUser($user)
140 140
     {
141 141
         if (is_numeric($user)) {
142
-            $id = (int)$user;
142
+            $id = (int) $user;
143 143
         } elseif ($user instanceof ForumsUserInterface || $user instanceof User) {
144 144
             $id = $user->get('id');
145 145
         } else {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     public function isLocked(): bool
158 158
     {
159
-        return (bool)$this->get('user_lock');
159
+        return (bool) $this->get('user_lock');
160 160
     }
161 161
 
162 162
     /**
Please login to merge, or discard this patch.
src/View/Helper/UserHelper.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -10,11 +10,9 @@
 block discarded – undo
10 10
 namespace App\View\Helper;
11 11
 
12 12
 use App\Model\Entity\User;
13
-use Cake\ORM\Entity;
14 13
 use Identicon\Identicon;
15 14
 use Saito\RememberTrait;
16 15
 use Saito\User\ForumsUserInterface;
17
-use Saito\User\SaitoUser;
18 16
 use Stopwatch\Lib\Stopwatch;
19 17
 
20 18
 /**
Please login to merge, or discard this patch.
plugins/BbcodeParser/src/Lib/jBBCode/Definitions/JbbCodeDefinitions.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Plugin\BbcodeParser\src\Lib\jBBCode\Definitions;
4 4
 
5 5
 use Cake\Cache\Cache;
6
-use Cake\Core\Configure;
7 6
 use Plugin\BbcodeParser\src\Lib\Helper\Message;
8 7
 use Plugin\BbcodeParser\src\Lib\Helper\UrlParserTrait;
9 8
 use Saito\DomainParser;
Please login to merge, or discard this patch.
plugins/ImageUploader/src/Lib/UploaderConfig.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     public function setDefaultMaxFileSize($number): self
64 64
     {
65 65
         if (is_string($number)) {
66
-            $number = (int)Text::parseFileSize($number, $this->defaultSize);
66
+            $number = (int) Text::parseFileSize($number, $this->defaultSize);
67 67
         }
68 68
         if (!is_int($number)) {
69 69
             throw new \InvalidArgumentException(
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         if ($size === null) {
90 90
             $size = $this->defaultSize;
91 91
         } elseif (is_string($size)) {
92
-            $size = (int)Text::parseFileSize($size, $this->defaultSize);
92
+            $size = (int) Text::parseFileSize($size, $this->defaultSize);
93 93
         }
94 94
         if (!is_int($size)) {
95 95
             throw new \InvalidArgumentException(
Please login to merge, or discard this patch.
plugins/ImageUploader/tests/TestCase/Controller/UploadsControllerTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $this->loginJwt(1);
73 73
 
74 74
         $this->upload($this->file);
75
-        $response = json_decode((string)$this->_response->getBody(), true);
75
+        $response = json_decode((string) $this->_response->getBody(), true);
76 76
 
77 77
         $this->assertResponseCode(200);
78 78
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
             <svg width="9" height="9" style="background:red;"></svg>');
120 120
         $this->upload($this->file);
121 121
 
122
-        $response = json_decode((string)$this->_response->getBody(), true);
122
+        $response = json_decode((string) $this->_response->getBody(), true);
123 123
 
124 124
         $this->assertResponseCode(200);
125 125
 
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 
177 177
         $this->upload($this->file);
178 178
 
179
-        $response = json_decode((string)$this->_response->getBody(), true);
179
+        $response = json_decode((string) $this->_response->getBody(), true);
180 180
 
181 181
         $this->assertResponseCode(200);
182 182
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 
237 237
         $this->get('api/v2/uploads');
238 238
 
239
-        $response = json_decode((string)$this->_response->getBody(), true);
239
+        $response = json_decode((string) $this->_response->getBody(), true);
240 240
 
241 241
         $this->assertResponseCode(200);
242 242
 
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 
284 284
         $this->delete('api/v2/uploads/1');
285 285
 
286
-        $response = json_decode((string)$this->_response->getBody(), true);
286
+        $response = json_decode((string) $this->_response->getBody(), true);
287 287
 
288 288
         $this->assertResponseCode(204);
289 289
 
Please login to merge, or discard this patch.
plugins/ImageUploader/tests/TestCase/Controller/ThumbnailControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $this->assertSame(300, imagesx($image));
56 56
         $this->assertSame(300, imagesy($image));
57 57
         $this->assertSame($upload->get('type'), $cache['type']);
58
-        $this->assertResponseEquals($cache['raw'], (string)$this->_response->getBody());
58
+        $this->assertResponseEquals($cache['raw'], (string) $this->_response->getBody());
59 59
         $this->assertHeader('content-type', 'image/png');
60 60
 
61 61
         //// cleanup
Please login to merge, or discard this patch.
plugins/ImageUploader/src/Model/Table/UploadsTable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -247,8 +247,8 @@  discard block
 block discarded – undo
247 247
         $ratio = $size / $target;
248 248
         $ratio = sqrt($ratio);
249 249
 
250
-        $newwidth = (int)($width / $ratio);
251
-        $newheight = (int)($height / $ratio);
250
+        $newwidth = (int) ($width / $ratio);
251
+        $newheight = (int) ($height / $ratio);
252 252
         $destination = imagecreatetruecolor($newwidth, $newheight);
253 253
 
254 254
         $source = imagecreatefromstring($raw);
Please login to merge, or discard this patch.
plugins/ImageUploader/src/Controller/ThumbnailController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
35 35
      */
36 36
     public function thumb(): Response
37 37
     {
38
-        $id = (int)$this->request->getParam('id');
39
-        ['hash' => $fingerprint, 'type' => $type, 'raw' => $raw] = Cache::remember((string)$id, function () use ($id) {
38
+        $id = (int) $this->request->getParam('id');
39
+        ['hash' => $fingerprint, 'type' => $type, 'raw' => $raw] = Cache::remember((string) $id, function () use ($id) {
40 40
             $Uploads = $this->loadModel('ImageUploader.Uploads');
41 41
             $document = $Uploads->get($id);
42 42
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             return compact('hash', 'raw', 'type');
56 56
         }, Configure::read('Saito.Settings.uploader')->getCacheKey());
57 57
 
58
-        $hash = (string)$this->request->getQuery('h');
58
+        $hash = (string) $this->request->getQuery('h');
59 59
         if ($hash !== $fingerprint) {
60 60
             throw new SaitoForbiddenException(
61 61
                 "Attempt to access image-thumbnail $id."
Please login to merge, or discard this patch.
plugins/ImageUploader/src/Controller/UploadsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 /**
6 6
  * Saito - The Threaded Web Forum
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
             throw new GenericApiException($msg);
104 104
         }
105 105
 
106
-        Cache::delete((string)$imageId, 'uploadsThumbnails');
106
+        Cache::delete((string) $imageId, 'uploadsThumbnails');
107 107
 
108 108
         $this->autoRender = false;
109 109
         $this->response = $this->response->withStatus(204);
Please login to merge, or discard this patch.