Schlaefer / Saito

src/Lib/Saito/Posting/Posting.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Saito\Posting\Basic\BasicPostingInterface;
 use Saito\Posting\Basic\BasicPostingTrait;
-use Saito\Posting\Decorator\PostingTrait;
 use Saito\Posting\Decorator\UserPostingTrait;
 use Saito\Thread\Thread;
 use Saito\User\CurrentUser\CurrentUser;

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
     {
         $postings = [];
         $this->map(
-            function ($node) use (&$postings) {
+            function($node) use (&$postings) {
                 $postings[$node->get('id')] = $node;
             },
             false

src/Lib/Saito/Smiley/SmileyLoader.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Saito\Smiley;
 
 use Cake\Cache\Cache;
-use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 
 class SmileyLoader

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         if ($this->_smilies !== null) {
             return $this->_smilies;
         }
-        $this->_smilies = Cache::remember('Saito.Smilies.data', function () {
+        $this->_smilies = Cache::remember('Saito.Smilies.data', function() {
             $Smilies = TableRegistry::get('Smilies');
             $smiliesRaw = $Smilies->find()
                 ->contain(['SmileyCodes'])

src/Lib/Saito/Smiley/SmileyRenderer.php

Doc Comments +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
     /**
      * Constructor
      *
-     * @param array $smileyData data
+     * @param SmileyLoader $smileyData data
      */
     public function __construct(SmileyLoader $smileyData)
     {
@@ -61,7 +61,7 @@ 
     /**
      * Set Helper
      *
-     * @param Helper $Helper helper
+     * @param HtmlHelper $Helper helper
      * @return self
      */
     public function setHelper(HtmlHelper $Helper): self
@@ -78,7 +78,7 @@ 
      *
      * @param string $string string
      * @param array $replacements replacements
-     * @return mixed
+     * @return string
      */
     protected function _debug($string, $replacements)
     {

Spacing +4 added lines, -4 removed lines

@@ -132,11 +132,11 @@ 
     {
         $delimiter = '/';
         foreach ($codes['codes'] as $key => $code) {
-            $codes['quoted'][$key] = $delimiter .
+            $codes['quoted'][$key] = $delimiter.
                 // a smiley can't be concatenated to a string and requires a
                 // whitespace in front
-                '(^|(?<=(\s)))' .
-                preg_quote($code, $delimiter) .
+                '(^|(?<=(\s)))'.
+                preg_quote($code, $delimiter).
                 $delimiter;
         }
     }
@@ -167,7 +167,7 @@ 
                 //= pixel image smileys
             } else {
                 $replacements['html'][$k] = $this->HtmlHelper->image(
-                    'smilies/' . $smiley['image'],
+                    'smilies/'.$smiley['image'],
                     [
                         'alt' => $smiley['code'],
                         'class' => 'saito-smiley-image',

src/Lib/Saito/Test/IntegrationTestCase.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 namespace Saito\Test;
 
 use App\Test\Fixture\UserFixture;
-
 use Cake\Core\Configure;
 use Cake\Event\Event;
 use Cake\Event\EventManager;

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 /**
  * Saito - The Threaded Web Forum
@@ -136,7 +136,7 @@ 
         $Mock = $this->getMockForTableParent($table, $methods);
         EventManager::instance()->on(
             'Controller.initialize',
-            function (Event $event) use ($table, $Mock) {
+            function(Event $event) use ($table, $Mock) {
                 $Controller = $event->getSubject();
                 $Controller->{$table} = $Mock;
             }
@@ -160,7 +160,7 @@ 
         $this->configRequest([
             'headers' => [
                 'Accept' => 'application/json',
-                'Authorization' => 'bearer ' . $jwtToken,
+                'Authorization' => 'bearer '.$jwtToken,
             ]
         ]);
     }
@@ -314,7 +314,7 @@ 
     {
         $this->assertContainsTag(
             $expected,
-            (string)$this->_controller->response->getBody()
+            (string) $this->_controller->response->getBody()
         );
     }
 }

src/Lib/Saito/Test/Model/Table/SaitoTableTestCase.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Cake\ORM\Table;
 use Cake\ORM\TableRegistry;
-use Saito\App\Registry;
 use Saito\Test\SaitoTestCase;
-use Saito\User\SaitoUser;
 
 abstract class SaitoTableTestCase extends SaitoTestCase
 {

src/Lib/Saito/Test/SecurityMockTrait.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Saito\Test;
 
-use Cake\Event\Event;
-use Cake\Event\EventManager;
-
 trait SecurityMockTrait
 {
 

src/Lib/Saito/User/LastRefresh/LastRefreshAbstract.php

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
      * tested if new for user.
      *
      * @param string|\DateTimeInterface $timestamp int unix-timestamp or date as string
-     * @return mixed bool or null if not determinable
+     * @return null|boolean bool or null if not determinable
      */
     public function isNewerThan($timestamp)
     {
@@ -60,7 +60,7 @@ 
     /**
      * Set timestamp.
      *
-     * @param mixed $timestamp null|'now'|<`Y-m-d H:i:s` timestamp>
+     * @param string $timestamp null|'now'|<`Y-m-d H:i:s` timestamp>
      * @return void
      */
     public function set($timestamp = null)

src/Lib/Saito/User/LastRefresh/LastRefreshCookie.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Saito\User\LastRefresh;
 
-use App\Controller\Component\CurrentUserComponent;
 use Saito\User\Cookie;
 
 /**

src/Lib/Saito/User/SaitoUserTrait.php

Doc Comments +2 added lines, -1 removed lines

@@ -127,6 +127,7 @@ 
 
     /**
      * {@inheritDoc}
+     * @return boolean|string
      */
     public function isLoggedIn()
     {
@@ -152,7 +153,7 @@ 
     /**
      * Checks if user is forbidden.
      *
-     * @return bool|string
+     * @return string|false
      */
     public function isForbidden()
     {

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace Saito\User;
 
 use App\Model\Entity\User;
-use Cake\Core\Exception\Exception;
-use Cake\I18n\Time;
 use Cake\Utility\Hash;
 use Saito\App\Registry;
 

Spacing +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
         }
 
         if (!empty($settings['id'])) {
-            $this->_id = (int)$settings['id'];
+            $this->_id = (int) $settings['id'];
             $this->_isLoggedIn = true;
         }
 
@@ -139,7 +139,7 @@ 
     public function isUser($user)
     {
         if (is_numeric($user)) {
-            $id = (int)$user;
+            $id = (int) $user;
         } elseif ($user instanceof ForumsUserInterface || $user instanceof User) {
             $id = $user->get('id');
         } else {