Code Duplication - Schlaefer/Saito - Measure and Improve Code Quality continuously with Scrutinizer

Saito

Code Duplication Length = 5-8 lines in 2 locations

plugins/SaitoHelp/src/Controller/SaitoHelpsController.php 1 location


        if (!$help && $lang !== 'en') {
            $this->redirect("/help/en/$id");
        }
        if ($help) {
            $this->set('help', $help);
        } else {
            $this->Flash->set(__('sh.nf'), ['element' => 'error']);
            $this->redirect('/');

            return;
        }

        $isCore = !strpos($id, '.');
        $this->set(compact('isCore'));

src/Controller/UsersController.php 1 location


            ->where(['Users.id' => $id])
            ->first();

        if ($id === null || empty($user)) {
            $this->Flash->set(__('Invalid user'), ['element' => 'error']);

            return $this->redirect('/');
        }

        $entriesShownOnPage = 20;
        $this->set(

		@@ 51-58 (lines=8) @@
48		if (!$help && $lang !== 'en') {
49		$this->redirect("/help/en/$id");
50		}
51		if ($help) {
52		$this->set('help', $help);
53		} else {
54		$this->Flash->set(__('sh.nf'), ['element' => 'error']);
55		$this->redirect('/');
56
57		return;
58		}
59
60		$isCore = !strpos($id, '.');
61		$this->set(compact('isCore'));

		@@ 385-389 (lines=5) @@
382		->where(['Users.id' => $id])
383		->first();
384
385		if ($id === null \|\| empty($user)) {
386		$this->Flash->set(__('Invalid user'), ['element' => 'error']);
387
388		return $this->redirect('/');
389		}
390
391		$entriesShownOnPage = 20;
392		$this->set(

Schlaefer / Saito

Code Duplication Length = 5-8 lines in 2 locations

plugins/SaitoHelp/src/Controller/SaitoHelpsController.php 1 location

src/Controller/UsersController.php 1 location