Installer\Controller\UpdaterController::start()

Complexity

Conditions	9
Paths	16

Size

Total Lines	70
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function start()
    {
        $token = new File(CONFIG . 'updater');

        if ($token->exists()) {
            $this->renderFailure(__d('installer', 'update.failure.explanation'), 1529737182);

It seems like __d('installer', 'update.failure.explanation') can also be of type null; however, parameter $message of Installer\Controller\UpdaterController::renderFailure() does only seem to accept string, maybe add an additional type check?

            return;
        }

        $this->set('dbVersion', $this->dbVersion);
        $this->set('saitoVersion', $this->saitoVersion);

        if (empty($this->dbVersion)) {
            $msg = __d('installer', 'update.failure.nodbversion');
            $this->renderFailure($msg, 1529737397);
            $this->log($msg, LogLevel::ERROR, ['saito.install']);

            return;
        }

        if (version_compare($this->dbVersion, '4.10.0', '<')) {
            $msg = __d('installer', 'update.failure.wrongdbversion', ['v' => $this->dbVersion]);
            $this->renderFailure($msg, 1529737648);
            $this->log($msg, LogLevel::ERROR, ['saito.install']);

            return;
        }

        $startForm = new UpdaterStartForm();
        $this->set('startForm', $startForm);

        if (!$this->getRequest()->is('post')) {
            return;
        }

        if (!$startForm->execute($this->request->getData())) {

It seems like $this->request->getData() can also be of type null; however, parameter $data of Cake\Form\Form::execute() does only seem to accept array, maybe add an additional type check?

            // don't emit errors in frontend in case form is accidental on live-installation
            $startForm->setErrors([]);
            $this->set('startAuthError', true);

            return;
        }

        $this->logCurrentState('Pre-update state.');

        $token->write('');

        try {
            if (
                version_compare($this->dbVersion, '4.10.0', '>=')
                && version_compare($this->dbVersion, '5.0.0', '<')
            ) {
                $this->migrations->markMigrated('20180620081553');

'20180620081553' of type string is incompatible with the type integer expected by parameter $version of Migrations\Migrations::markMigrated().

                $this->logCurrentState('Marked version 4.10.0 migrated.');
            }

            $this->migrations->migrate();
            (new DbVersion($this->Settings))->set($this->saitoVersion);
            $this->logCurrentState('Post upgrade state.');
        } catch (\Throwable $e) {
            $this->logCurrentState('Migration failed: ' . $e->getMessage());

            return $this->redirect('/');
        }

        $token->delete();
        $this->viewBuilder()->setTemplate('success');

        $this->logCurrentState('Update successfull.');
    }