Saito\User\ReadPostings\ReadPostingsCookie

Complexity

Total Complexity

10

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	set()	0	20	3
A	delete()	0	3	1
A	_gc()	0	12	2
A	_get()	0	17	4

<?php

declare(strict_types=1);

/**
 * Saito - The Threaded Web Forum
 *
 * @copyright Copyright (c) the Saito Project Developers
 * @link https://github.com/Schlaefer/Saito
 * @license http://opensource.org/licenses/MIT
 */

namespace Saito\User\ReadPostings;

use Saito\User\Cookie\Storage;

/**
 * Handles read posting by a client side cookie. Used for non logged-in
 * users.
 */
class ReadPostingsCookie extends ReadPostingsAbstract
{
    /**
     * Max number of postings in cookie
     */
    protected $maxPostings = 240;

    /** @var Storage */
    protected $storage;

    /**
     * {@inheritDoc}
     */
    public function set($entries)
    {
        $entries = $this->_prepareForSave($entries);
        if (empty($entries)) {
            return;
        }

        $entries = array_fill_keys($entries, 1);
        $new = $this->_get() + $entries;
        if (empty($new)) {
            return;
        }
        $this->readPostings = $new;

        $this->_gc();

        // make simple string and don't encrypt it to keep cookie small enough
        // to fit $this->_maxPostings into 4 kB
        $data = implode('.', array_keys($this->readPostings));
        $this->storage->write($data);
    }

    /**
     * {@inheritDoc}
     */
    public function delete()
    {
        $this->storage->delete();
    }

    /**
     * limits the number of postings saved in cookie
     *
     * cookie size should not exceed 4 kB
     *
     * @return void
     */
    protected function _gc()
    {
        $overhead = count($this->readPostings) - $this->maxPostings;
        if ($overhead < 0) {
            return;
        }
        ksort($this->readPostings);
        $this->readPostings = array_slice(
            $this->readPostings,
            $overhead,
            null,
            true
        );
    }

    /**
     * {@inheritDoc}
     */
    protected function _get()
    {
        if ($this->readPostings !== null) {
            return $this->readPostings;
        }
        $this->readPostings = $this->storage->read();

It seems like $this->storage->read() can also be of type string. However, the property $readPostings is declared as type array. Maybe add an additional type check?

        if (
            empty($this->readPostings)
            || !preg_match('/^[0-9\.]*$/', $this->readPostings)

It seems like $this->readPostings can also be of type array; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

        ) {
            $this->readPostings = [];
        } else {
            $this->readPostings = explode('.', $this->readPostings);

It seems like $this->readPostings can also be of type array; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

            $this->readPostings = array_fill_keys($this->readPostings, 1);
        }

        return $this->readPostings;
    }
}