Admin\Controller\SettingsController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	8	2
B	edit()	0	37	7
A	initialize()	0	4	1

<?php

declare(strict_types=1);

/**
 * Saito - The Threaded Web Forum
 *
 * @copyright Copyright (c) the Saito Project Developers
 * @link https://github.com/Schlaefer/Saito
 * @license http://opensource.org/licenses/MIT
 */

namespace Admin\Controller;

use App\Model\Table\SettingsTable;
use Cake\Http\Exception\NotFoundException;

/**
 * @property SettingsTable $Settings
 */
class SettingsController extends AdminAppController
{

    public $helpers = [
        'Admin.Setting',
        'TimeH',
    ];

    protected $settingsShownInAdminIndex = [
        'autolink' => ['type' => 'bool'],
        'bbcode_img' => ['type' => 'bool'],
        // Activates and deactivates the category-chooser on entries/index
        'category_chooser_global' => ['type' => 'bool'],
        // Allows users to show the category-chooser even if the default
        // setting `category_chooser_global` is off
        'category_chooser_user_override' => ['type' => 'bool'],
        'content_embed_active' => ['type' => 'bool'],
        'content_embed_media' => ['type' => 'bool'],
        'content_embed_text' => ['type' => 'bool'],
        'edit_delay' => 1,
        'edit_period' => 1,
        'email_contact' => 1,
        'email_register' => 1,
        'email_system' => 1,
        'forum_disabled' => ['type' => 'bool'],
        'forum_disabled_text' => 1,
        'forum_email' => 1,
        'forum_name' => 1,
        'quote_symbol' => 1,
        'signature_separator' => 1,
        'stopwatch_get' => ['type' => 'bool'],
        'store_ip' => ['type' => 'bool'],
        'store_ip_anonymized' => ['type' => 'bool'],
        'subject_maxlength' => 1,
        'thread_depth_indent' => 1,
        'timezone' => 1,
        'topics_per_page' => 1,
        'tos_enabled' => ['type' => 'bool'],
        'tos_url' => 1,
        'video_domains_allowed' => 1,
    ];

    /**
     * {@inheritDoc}
     */
    public function initialize()
    {
        parent::initialize();
        $this->loadModel('Settings');
    }

    /**
     * index settings
     *
     * @return void
     */
    public function index()
    {
        $settings = $this->Settings->getSettings();
        foreach ($settings as $key => $value) {
            $this->request = $this->request->withData($key, $value);
        }
        $settings = array_intersect_key($settings, $this->settingsShownInAdminIndex);
        $this->set('Settings', $settings);
    }

    /**
     * edit setting
     *
     * @param string|null $id settings-ID
     *
     * @return \Cake\Http\Response|void
     */
    public function edit(string $id = null)
    {
        if (empty($id)) {
            throw new NotFoundException();
        }

        $setting = $this->Settings->get($id);
        if (empty($setting)) {
            throw new NotFoundException();
        }

        if ($this->request->is(['post', 'put'])) {
            $this->Settings->patchEntity(
                $setting,
                $this->request->getData(),

It seems like $this->request->getData() can also be of type null; however, parameter $data of Cake\ORM\Table::patchEntity() does only seem to accept array, maybe add an additional type check?

                ['fields' => ['value']]
            );
            if ($this->Settings->save($setting)) {
                // @lo
                $this->Flash->set('Saved.', ['element' => 'notice']);

                return $this->redirect(['action' => 'index', '#' => $id]);
            }

            $errors = $setting->getErrors();
            // @lo
            $msg = !empty($errors) ? current(current($errors)) : 'Something went wrong';
            $this->Flash->set($msg, ['element' => 'error']);
        }

        $type = $this->settingsShownInAdminIndex[$id]['type'] ?? null;
        $setting->set('type', $type);

        $this->set('setting', $setting);

        if ($id === 'timezone') {
            $this->render('timezone');
        }
    }
}