Issues in UserController.php (master) - Issues in master - Schanihbg/ramverk1-comment - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/User/UserController.php (6 issues)

Labels

Duplication 6

Severity

Informational 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Schanihbg\User;

use \Anax\Configure\ConfigureInterface;
use \Anax\Configure\ConfigureTrait;
use \Anax\DI\InjectionAwareInterface;
use \Anax\Di\InjectionAwareTrait;
use \Schanihbg\User\HTMLForm\UserLoginForm;
use \Schanihbg\User\HTMLForm\CreateUserForm;
use \Schanihbg\User\HTMLForm\UpdateUserForm;

/**
 * A controller class.
 */
class UserController implements
    ConfigureInterface,
    InjectionAwareInterface
{
    use ConfigureTrait,
        InjectionAwareTrait;



    /**
     * @var $data description
     */
    //private $data;



    /**
     * Description.
     *
     * @throws Exception
     *
     * @return void
     */
    public function getIndex()

    {
        $title      = "User profile";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $view->add("user/profile");

        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostLogin()

    {
        $title      = "A login page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new UserLoginForm($this->di);

        $form->check();

        $data = [
            "content" => $form->getHTML(),
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }



    /**
     * Description.
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostCreateUser()

    {
        $title      = "A create user page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new CreateUserForm($this->di);

        $form->check();

        $data = [
            "content" => $form->getHTML(),
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Handler with form to update a user.
     *
     * @param datatype $id User ID
     *
     * @return void
     */
    public function getPostUpdateUser($id)

    {
        $title      = "Update an item";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new UpdateUserForm($this->di, $id);

        $form->check();

        $data = [
            "form" => $form->getHTML(),
            "id" => $id,
        ];

        $view->add("user/update", $data);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Description.
     *
     * @param datatype $input What user to login.
     *
     * @throws Exception
     *
     * @return void
     */
    public function loginUser($input)
    {
        $this->di->get("session")->set("userLoggedIn", $input);
    }

    /**
     * Description.
     *
     * @throws Exception
     *
     * @return void
     */
    public function logoutUser()

    {
        $title      = "Logout page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $view->add("user/logout");

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Description.
     *
     * @param datatype $userInput What user to check ID.
     *
     * @throws Exception
     *
     * @return void
     */
    public function getIDByUser($userInput)

    {
        $user = new User();
        $user->setDb($this->di->get("database"));
        $user->find("acronym", $userInput);

        return $user;
    }

    /**
     * Description.
     *
     * @throws Exception
     *
     * @return void
     */
    public function adminControl()
    {
        $title      = "Admin Control";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");

        $sql = "SELECT * FROM `User`";

        $data = $this->di->get("database")->executeFetchAll($sql);

        $view->add("user/admin", ["content" => $data]);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Delete user
     *
     * @param datatype $id User ID.
     *
     * @return void
     */
    public function removeUser($id)
    {
        $sql = "DELETE FROM `User` WHERE id = ?";
        $this->di->get("database")->execute($sql, [$id]);
        $this->di->get("response")->redirect($this->di->get("url")->create("user/admin"));
    }
}


1		<?php
2
3		namespace Schanihbg\User;
4
5		use \Anax\Configure\ConfigureInterface;
6		use \Anax\Configure\ConfigureTrait;
7		use \Anax\DI\InjectionAwareInterface;
8		use \Anax\Di\InjectionAwareTrait;
9		use \Schanihbg\User\HTMLForm\UserLoginForm;
10		use \Schanihbg\User\HTMLForm\CreateUserForm;
11		use \Schanihbg\User\HTMLForm\UpdateUserForm;
12
13		/**
14		* A controller class.
15		*/
16		class UserController implements
17		ConfigureInterface,
18		InjectionAwareInterface
19		{
20		use ConfigureTrait,
21		InjectionAwareTrait;
22
23
24
25		/**
26		* @var $data description
27		*/
28		//private $data;
29
30
31
32		/**
33		* Description.
34		*
35		* @throws Exception
36		*
37		* @return void
38		*/
39	View Code Duplication	public function getIndex()
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		$title = "User profile";
42		$view = $this->di->get("view");
43		$pageRender = $this->di->get("pageRender");
44
45		$view->add("user/profile");
46
47		$pageRender->renderPage(["title" => $title]);
48		}
49
50
51
52		/**
53		* Description.
54		*
55		* @throws Exception
56		*
57		* @return void
58		*/
59	View Code Duplication	public function getPostLogin()
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		$title = "A login page";
62		$view = $this->di->get("view");
63		$pageRender = $this->di->get("pageRender");
64		$form = new UserLoginForm($this->di);
65
66		$form->check();
67
68		$data = [
69		"content" => $form->getHTML(),
70		];
71
72		$view->add("default2/article", $data);
73
74		$pageRender->renderPage(["title" => $title]);
75		}
76
77
78
79		/**
80		* Description.
81		*
82		* @throws Exception
83		*
84		* @return void
85		*/
86	View Code Duplication	public function getPostCreateUser()
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$title = "A create user page";
89		$view = $this->di->get("view");
90		$pageRender = $this->di->get("pageRender");
91		$form = new CreateUserForm($this->di);
92
93		$form->check();
94
95		$data = [
96		"content" => $form->getHTML(),
97		];
98
99		$view->add("default2/article", $data);
100
101		$pageRender->renderPage(["title" => $title]);
102		}
103
104		/**
105		* Handler with form to update a user.
106		*
107		* @param datatype $id User ID
108		*
109		* @return void
110		*/
111	View Code Duplication	public function getPostUpdateUser($id)
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		{
113		$title = "Update an item";
114		$view = $this->di->get("view");
115		$pageRender = $this->di->get("pageRender");
116		$form = new UpdateUserForm($this->di, $id);
117
118		$form->check();
119
120		$data = [
121		"form" => $form->getHTML(),
122		"id" => $id,
123		];
124
125		$view->add("user/update", $data);
126
127		$pageRender->renderPage(["title" => $title]);
128		}
129
130		/**
131		* Description.
132		*
133		* @param datatype $input What user to login.
134		*
135		* @throws Exception
136		*
137		* @return void
138		*/
139		public function loginUser($input)
140		{
141		$this->di->get("session")->set("userLoggedIn", $input);
142		}
143
144		/**
145		* Description.
146		*
147		* @throws Exception
148		*
149		* @return void
150		*/
151	View Code Duplication	public function logoutUser()
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		$title = "Logout page";
154		$view = $this->di->get("view");
155		$pageRender = $this->di->get("pageRender");
156
157		$view->add("user/logout");
158
159		$pageRender->renderPage(["title" => $title]);
160		}
161
162		/**
163		* Description.
164		*
165		* @param datatype $userInput What user to check ID.
166		*
167		* @throws Exception
168		*
169		* @return void
170		*/
171	View Code Duplication	public function getIDByUser($userInput)
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
172		{
173		$user = new User();
174		$user->setDb($this->di->get("database"));
175		$user->find("acronym", $userInput);
176
177		return $user;
178		}
179
180		/**
181		* Description.
182		*
183		* @throws Exception
184		*
185		* @return void
186		*/
187		public function adminControl()
188		{
189		$title = "Admin Control";
190		$view = $this->di->get("view");
191		$pageRender = $this->di->get("pageRender");
192
193		$sql = "SELECT * FROM `User`";
194
195		$data = $this->di->get("database")->executeFetchAll($sql);
196
197		$view->add("user/admin", ["content" => $data]);
198
199		$pageRender->renderPage(["title" => $title]);
200		}
201
202		/**
203		* Delete user
204		*
205		* @param datatype $id User ID.
206		*
207		* @return void
208		*/
209		public function removeUser($id)
210		{
211		$sql = "DELETE FROM `User` WHERE id = ?";
212		$this->di->get("database")->execute($sql, [$id]);
213		$this->di->get("response")->redirect($this->di->get("url")->create("user/admin"));
214		}
215		}
216

Schanihbg / ramverk1-comment

Issues (18)

Security Analysis no request data

src/User/UserController.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like