UpdateUserForm::__construct() - Code Metrics - Inspection of "Added missing files for comment system" - Schanihbg/ramverk1-comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 10865e...d038e5 )

by Simon

created 2018-06-19 09:27 UTC

UpdateUserForm::__construct() A

↳ Parent: UpdateUserForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	51
rs	9.4109
cc	1
eloc	30
nc	1
nop	2

How to fix Long Method

<?php

namespace Schanihbg\User\HTMLForm;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Schanihbg\User\User;

/**
 * Form to update an item.
 */
class UpdateUserForm extends FormModel
{
    /**
     * Constructor injects with DI container and the id to update.
     *
     * @param Anax\DI\DIInterface $di a service container
     * @param integer             $id to update
     */
    public function __construct(DIInterface $di, $id)
    {
        parent::__construct($di);
        $user = $this->getItemDetails($id);
        $this->form->create(
            [
                "id" => __CLASS__,
            ],
            [
                "id" => [
                    "type" => "text",
                    "validation" => ["not_empty"],
                    "readonly" => true,
                    "value" => $user->id,
                ],

                "acronym" => [
                    "type" => "text",
                    "validation" => ["not_empty"],
                    "value" => $user->acronym,
                ],

                "email" => [
                    "type" => "email",
                    "validation" => ["not_empty"],
                    "value" => $user->email,
                ],

                "password" => [
                    "type"       => "password",
                ],

                "password-again" => [
                    "type"       => "password",
                    "validation" => [
                        "match" => "password"
                    ],
                ],

                "submit" => [
                    "type" => "submit",
                    "value" => "Save",
                    "callback" => [$this, "callbackSubmit"]
                ],

                "reset" => [
                    "type"      => "reset",
                ],
            ]
        );
    }



    /**
     * Get details on item to load form with.
     *
     * @param integer $id get details on item with id.
     *
     * @return User
     */
    public function getItemDetails($id)

    {
        $user = new User();
        $user->setDb($this->di->get("database"));
        $user->find("id", $id);
        return $user;
    }



    /**
     * Callback for submit-button which should return true if it could
     * carry out its work and false if something failed.
     *
     * @return boolean true if okey, false if something went wrong.
     */
    public function callbackSubmit()

    {
        // Get values from the submitted form
        $id            = $this->form->value("id");
        $acronym       = $this->form->value("acronym");
        $email         = $this->form->value("email");
        $password      = $this->form->value("password");
        $passwordAgain = $this->form->value("password-again");

        // Check password matches
        if ($password !== $passwordAgain) {
            $this->form->rememberValues();
            $this->form->addOutput("Password did not match.");
            return false;
        }

        $user = new User();
        $user->setDb($this->di->get("database"));
        $user->find("id", $id);

        $user->acronym = $acronym;
        $user->email = $email;
        $user->setPassword($password);
        $user->save();

        $this->form->addOutput("User was updated.");
        return true;
    }
}


1		<?php
2
3		namespace Schanihbg\User\HTMLForm;
4
5		use \Anax\HTMLForm\FormModel;
6		use \Anax\DI\DIInterface;
7		use \Schanihbg\User\User;
8
9		/**
10		* Form to update an item.
11		*/
12		class UpdateUserForm extends FormModel
13		{
14		/**
15		* Constructor injects with DI container and the id to update.
16		*
17		* @param Anax\DI\DIInterface $di a service container
18		* @param integer $id to update
19		*/
20		public function __construct(DIInterface $di, $id)
21		{
22		parent::__construct($di);
23		$user = $this->getItemDetails($id);
24		$this->form->create(
25		[
26		"id" => __CLASS__,
27		],
28		[
29		"id" => [
30		"type" => "text",
31		"validation" => ["not_empty"],
32		"readonly" => true,
33		"value" => $user->id,
34		],
35
36		"acronym" => [
37		"type" => "text",
38		"validation" => ["not_empty"],
39		"value" => $user->acronym,
40		],
41
42		"email" => [
43		"type" => "email",
44		"validation" => ["not_empty"],
45		"value" => $user->email,
46		],
47
48		"password" => [
49		"type" => "password",
50		],
51
52		"password-again" => [
53		"type" => "password",
54		"validation" => [
55		"match" => "password"
56		],
57		],
58
59		"submit" => [
60		"type" => "submit",
61		"value" => "Save",
62		"callback" => [$this, "callbackSubmit"]
63		],
64
65		"reset" => [
66		"type" => "reset",
67		],
68		]
69		);
70		}
71
72
73
74		/**
75		* Get details on item to load form with.
76		*
77		* @param integer $id get details on item with id.
78		*
79		* @return User
80		*/
81	View Code Duplication	public function getItemDetails($id)
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$user = new User();
84		$user->setDb($this->di->get("database"));
85		$user->find("id", $id);
86		return $user;
87		}
88
89
90
91		/**
92		* Callback for submit-button which should return true if it could
93		* carry out its work and false if something failed.
94		*
95		* @return boolean true if okey, false if something went wrong.
96		*/
97	View Code Duplication	public function callbackSubmit()
		0 ignored issues – show Duplication introduced 2018-06-19 09:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		{
99		// Get values from the submitted form
100		$id = $this->form->value("id");
101		$acronym = $this->form->value("acronym");
102		$email = $this->form->value("email");
103		$password = $this->form->value("password");
104		$passwordAgain = $this->form->value("password-again");
105
106		// Check password matches
107		if ($password !== $passwordAgain) {
108		$this->form->rememberValues();
109		$this->form->addOutput("Password did not match.");
110		return false;
111		}
112
113		$user = new User();
114		$user->setDb($this->di->get("database"));
115		$user->find("id", $id);
116
117		$user->acronym = $acronym;
118		$user->email = $email;
119		$user->setPassword($password);
120		$user->save();
121
122		$this->form->addOutput("User was updated.");
123		return true;
124		}
125		}
126

Schanihbg / ramverk1-comment

Push — master ( 10865e...d038e5 )

UpdateUserForm::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like