Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class CEscaperTest extends \PHPUnit_Framework_TestCase |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Test |
||
| 15 | * |
||
| 16 | * @return void |
||
| 17 | */ |
||
| 18 | public function testConstructorSuccess() { |
||
| 19 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 20 | |||
| 21 | $res = $el->getEncoding(); |
||
| 22 | $exp = 'UTF-8'; |
||
| 23 | $this->assertEquals($res, $exp, "Created element name missmatch."); |
||
| 24 | } |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Test |
||
| 28 | * |
||
| 29 | * @return void |
||
| 30 | */ |
||
| 31 | public function testSetAndGetEncoding() { |
||
| 32 | $el = new \Scelus\Escaper\CEscaper('ASCII'); |
||
| 33 | |||
| 34 | $res = $el->getEncoding(); |
||
| 35 | $exp = 'ASCII'; |
||
| 36 | $this->assertEquals($res, $exp, "Created element argument missmatch"); |
||
| 37 | |||
| 38 | $el->setEncoding('UTF-8'); |
||
| 39 | $res = $el->getEncoding(); |
||
| 40 | $exp = 'UTF-8'; |
||
| 41 | $this->assertEquals($res, $exp, "setEncoding() produced missmatch"); |
||
| 42 | } |
||
| 43 | |||
| 44 | /** |
||
| 45 | * Test |
||
| 46 | * |
||
| 47 | * @return void |
||
| 48 | */ |
||
| 49 | public function testEscapeHTML() { |
||
| 50 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 51 | |||
| 52 | $argument = '></div><h1>myattack</h1>'; |
||
| 53 | $res = $el->escapeHTML($argument); |
||
| 54 | $exp = '></div><h1>myattack</h1>'; |
||
| 55 | $this->assertEquals($res, $exp, "escapeHTML() produced missmatch"); |
||
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Test |
||
| 60 | * |
||
| 61 | * @return void |
||
| 62 | */ |
||
| 63 | public function testEscapeHTMLattr() { |
||
| 64 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 65 | |||
| 66 | $argument = '"><h1>Hello</table'; |
||
| 67 | $res = $el->escapeHTMLattr($argument); |
||
| 68 | $exp = ""><h1>Hello</table"; |
||
| 69 | $this->assertEquals($res, $exp, "escapeHTMLattr() produced missmatch"); |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Test |
||
| 74 | * |
||
| 75 | * @return void |
||
| 76 | */ |
||
| 77 | public function testEscapeUrl() { |
||
| 78 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 79 | |||
| 80 | $argument = '"><script>alert(1)</script><a href="#'; |
||
| 81 | $res = $el->escapeUrl($argument); |
||
| 82 | $exp = "%22%3E%3Cscript%3Ealert%281%29%3C%2Fscript%3E%3Ca%20href%3D%22%23"; |
||
| 83 | $this->assertEquals($res, $exp, "escapeUrl() produced missmatch"); |
||
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Test |
||
| 88 | * |
||
| 89 | * @return void |
||
| 90 | */ |
||
| 91 | public function testEscapeCSS() { |
||
| 92 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 93 | |||
| 94 | $argument = '"><script>alert(1)</script><a href="#'; |
||
| 95 | $res = $el->escapeCSS($argument); |
||
| 96 | $exp = '\22 \3e \3c script\3e alert\28 1\29 \3c \2f script\3e \3c a\20 href\3d \22 \23 '; |
||
| 97 | $this->assertEquals($res, $exp, "escapeCSS() produced missmatch"); |
||
| 98 | } |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Test |
||
| 102 | * |
||
| 103 | * @return void |
||
| 104 | */ |
||
| 105 | public function testEscapeJs() { |
||
| 106 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 107 | $argument = "'; alert(100); var x='"; |
||
| 108 | $res = $el->escapeJs($argument); |
||
| 109 | $exp = '\x27\x3b\x20alert\x28100\x29\x3b\x20var\x20x\x3d\x27'; |
||
| 110 | $this->assertEquals($res, $exp, "escapeJs() produced missmatch"); |
||
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Test |
||
| 115 | * |
||
| 116 | * @return void |
||
| 117 | */ |
||
| 118 | public function testEscapeXML() { |
||
| 119 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 120 | $argument = '></div><h1>myattack</h1>'; |
||
| 121 | $res = $el->escapeXml($argument); |
||
| 122 | $exp = '></div><h1>myattack</h1>'; |
||
| 123 | $this->assertEquals($res, $exp, "escapeHTML() produced missmatch"); |
||
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Test |
||
| 128 | * |
||
| 129 | * @return void |
||
| 130 | */ |
||
| 131 | public function testEscapeXmlattr() { |
||
| 132 | $el = new \Scelus\Escaper\CEscaper(); |
||
| 133 | $argument = '"><h1>Hello</table'; |
||
| 134 | $res = $el->escapeXmlattr($argument); |
||
| 135 | $exp = ""><h1>Hello</table"; |
||
| 136 | $this->assertEquals($res, $exp, "escapeHTMLattr() produced missmatch"); |
||
| 137 | } |
||
| 138 | } |