SandraJinnevall / ramverk1-module

src/Ip3/Validera3.php

<?php

namespace Anax\Ip3;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class Validera3 implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    protected $apiWeatherKey;

    public function getWeatherApi(string $key)
    {
        $this->apiWeatherKey = $key;
    }

    public function getPositionApi(string $key)
    {
        $this->apiPositionKey = $key;

The property apiPositionKey does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function check($ipadress)
    {
        $message = $this->getWeather($ipadress)["weatherForecast"]["message"];
        if ($message === 0) {
            return true;
        }
        return false;
    }

    public function getCurrentIP()
    {
        $remote = $_SERVER["REMOTE_ADDR"] ?? '127.0.0.1';
        $ipadress = isset($_SERVER['HTTP_CLIENT_IP']) ? $_SERVER['HTTP_CLIENT_IP'] : ((isset($_SERVER['HTTP_X_FORWARDED_FOR'])) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : $remote);
        return $ipadress;
    }

    public function getPosition($ipAdress)
    {
        $ch1 = curl_init();

        curl_setopt($ch1, CURLOPT_URL, 'http://api.ipstack.com/'.$ipAdress.'?access_key='.$this->apiPositionKey);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($ch1, CURLOPT_RETURNTRANSFER, true);

        $multi = curl_multi_init();
        $json = curl_exec($ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        do {
            $status = curl_multi_exec($multi, $active);
            if ($active) {
                curl_multi_select($multi);
            }
        } while ($active && $status == CURLM_OK);

        curl_multi_remove_handle($multi, $ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_multi_remove_handle() does only seem to accept resource, maybe add an additional type check?

        curl_multi_close($multi);
        // $curlLink = curl_init('http://api.ipstack.com/'.$ipAdress.'?access_key='.$this->apiPositionKey);
        // curl_setopt($curlLink, CURLOPT_RETURNTRANSFER, true);
        // $json = curl_exec($curlLink);
        // curl_close($curlLink);

        $apiResult = json_decode($json, true);
        $latitude = $apiResult['latitude'];
        $longitude = $apiResult['longitude'];
        $country = $apiResult['country_name'];
        $city = $apiResult['city'];
        $geoInfo = array($latitude, $longitude, $country, $city);
        return $geoInfo;
    }

    public function getWeather($ipAdress)
    {
        $ch1 = curl_init();

        $ch2 = curl_init();

        curl_setopt($ch1, CURLOPT_URL, 'http://api.openweathermap.org/data/2.5/forecast?q='.$ipAdress.'&appid='.$this->apiWeatherKey);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($ch1, CURLOPT_RETURNTRANSFER, true);

        curl_setopt($ch2, CURLOPT_URL, 'http://api.openweathermap.org/data/2.5/find?q='.$ipAdress.'&appid='.$this->apiWeatherKey);
        curl_setopt($ch2, CURLOPT_RETURNTRANSFER, true);

        $multi = curl_multi_init();
        // $json = curl_exec($ch1);
        curl_multi_add_handle($multi, $ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

        curl_multi_add_handle($multi, $ch2);

        do {
            $status = curl_multi_exec($multi, $active);
            if ($active) {
                curl_multi_select($multi);
            }
        } while ($active && $status == CURLM_OK);

        $json = curl_multi_getcontent($ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_multi_getcontent() does only seem to accept resource, maybe add an additional type check?

        $json2 = curl_multi_getcontent($ch2);

        curl_multi_remove_handle($multi, $ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_multi_remove_handle() does only seem to accept resource, maybe add an additional type check?

        curl_multi_remove_handle($multi, $ch2);
        curl_multi_close($multi);
        // $curlLink = curl_init('http://api.openweathermap.org/data/2.5/forecast?q='.$ipAdress.'&appid='.$this->apiWeatherKey);
        // curl_setopt($curlLink, CURLOPT_RETURNTRANSFER, true);
        // $json = curl_exec($curlLink);
        // curl_close($curlLink);

        // $array[] = json_decode($json, true);
        // $array[] = json_decode($json2, true);
        $json = [
            "weatherForecast" => json_decode($json, true),
            "weatherHistory" => json_decode($json2, true)
        ];

        // $apiResult3 = json_encode(array_merge(json_decode($json, true),json_decode($json2, true)));
        // $apiResult = json_decode($apiResult3, true);


        return $json;
    }
}