SandraJinnevall / ramverk1-module

src/Ip3/IpController3.php

<?php

namespace Anax\Ip3;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class IpController3 implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    private $db = "not active";

    public function initialize() : void
    {
        $this->db = "active";
        $this->IpController = new Validera3();

The property IpController does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function indexAction() : object
    {
        $title = "Kontrollera IP";
        $show = true;
        $ipController = $this->IpController;
        $getcurrentIp = $ipController->getCurrentIP();
        $postion = $this->di->get("positionKey");
        $getcurrentCity = $postion->getPosition($getcurrentIp);

        if ($this->di->get("request")->hasGet("ipadress")) {
            $session = $this->di->get("session");
            $session->set("ipadress", $this->di->get("request")->getGet("ipadress"));
            $resultIp = $this->checkIfValidOrNot();
            $this->di->get("page")->add("ip3/result3", $resultIp);
            $show = false;
        }

        $this->di->get("page")->add("ip3/ip3", [
          "show" => $show,
          "currentIP" => $getcurrentIp,
          "currentCity" => $getcurrentCity[3],
        ]);
        return $this->di->get("page")->render([
            "title" => $title,
        ]);
    }

    public function checkIfValidOrNot()
    {
        $ipcontroller = $this->IpController;

The assignment to $ipcontroller is dead and can be removed.

        $session = $this->di->get("session");
        $weather = $this->di->get("validera3");
        if ($session->has('ipadress')) {
            $ipadress = $session->get("ipadress");
            $resultIp["ipadress"] = $ipadress;

$resultIp was never initialized. Although not strictly required by PHP, it is generally a good practice to add $resultIp = array(); before regardless.

            $resultIp["validerbar"] = $weather->check($ipadress);
            $resultIp["weatherForecast"] = $weather->getWeather($ipadress)["weatherForecast"];
            $resultIp["weatherHistory"] = $weather->getWeather($ipadress)["weatherHistory"];

            return $resultIp;
        }
        return [];
    }
}