Issues in FirebaseResponce.php (master) - Issues in master - Samuel18/zend_Firebase - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/FirebaseResponce.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types = 1);
namespace Zend\Firebase;

/**
 * PHP7 FIREBASE LIBRARY (http://samuelventimiglia.it/)
 *
 *
 * @link https://github.com/samuel20miglia/zend_Firebase
 * @copyright Copyright (c) 2016-now Ventimiglia Samuel - Biasin Davide
 * @license BSD 3-Clause License
 *
 */

/**
 *
 * @author Davide Biasin
 * @package ZendFirebase
 */
class FirebaseResponce
{

    /**
     * Data from Firebase
     *
     * @var array $firebaseData
     */
    protected $firebaseData;

    /**
     * Type of operation
     *
     * @var string $operation
     */
    protected $operation;

    /**
     * Http server code
     *
     * @var integer $status
     */
    protected $status;

    /**
     * Format to array the responce
     *
     * @return array $firebaseData
     */
    public function getFirebaseData(): array
    {
        return $this->firebaseData;
    }

    /**
     * Type of Operation
     *
     * @return string $operation
     */
    public function getOperation(): string
    {
        return $this->operation;
    }

    /**
     * Status from http server
     *
     * @return integer $status
     */
    public function getStatus(): int
    {
        return $this->status;
    }

    /**
     * Set data from firebase api
     *
     * @param array $firebaseData
     */
    protected function setFirebaseData($firebaseData)
    {
        $this->firebaseData = $firebaseData;
    }

    /**
     * Set type of operation
     *
     * @param string $operation
     */
    protected function setOperation($operation)
    {
        $this->operation = $operation;
    }

    /**
     * Set status responce
     *
     * @param integer $status
     */
    protected function setStatus($status)
    {
        $this->status = $status;
    }

    /**
     * Method for validate data arrives in _costruct.
     * If all data was correct skip function without returns.
     *
     * @throws \Exception
     */
    protected function validateResponce()
    {
        try {
            /* check validity of Operation */
            $this->validateOperation();

            /* check validity of Status */
            $this->validateStatus();

            /* check validity of FirebaseData */
            $this->validateData();
        } catch (\Exception $e) {
            throw $e->getMessage();
        }
    }

    /**
     * Validate type of data receved
     *
     * @throws \Exception
     */
    private function validateOperation()
    {
        if (! is_string($this->getOperation())) {
            $getOperation = "Operation parameter must be STRING and NOT EMPTY. Received : ";
            $getOperation .= gettype($this->getOperation()) . " ({$this->getOperation()}).";

            throw new \Exception($getOperation);
        }
    }

    /**
     * Validate type of data receved
     *
     * @throws \Exception
     */
    private function validateStatus()
    {
        if (! is_numeric($this->getStatus())) {
            $getStatus = "Status parameter must be NUMERIC. Received : ";
            $getStatus .= gettype($this->getStatus()) . " ({$this->getStatus()}).";

            throw new \Exception($getStatus);
        }
    }

    /**
     * Validate type of data receved
     *
     * @throws \Exception
     */
    private function validateData()
    {
        if (! is_array($this->getFirebaseData())) {
            $gettype = "FirebaseData parameter must be ARRAY. Received : " . gettype($this->getFirebaseData()) . ".";
            throw new \Exception($gettype);
        }
    }

    /**
     * Validate type of json receved
     *
     * @return string
     */
    protected function validateJson():string
    {
        switch (json_last_error()) {
            case JSON_ERROR_NONE:
                $jsonValidator =  '';
                break;
            case JSON_ERROR_STATE_MISMATCH:
                $jsonValidator =  ' - Underflow or the modes mismatch';
                break;
            case JSON_ERROR_SYNTAX:
                $jsonValidator =  ' - Syntax error, malformed JSON';
                break;
            case JSON_ERROR_UTF8:
                $jsonValidator =  ' - Malformed UTF-8 characters, possibly incorrectly encoded';
                break;
        }

        return $jsonValidator;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2			declare(strict_types = 1);
3			namespace Zend\Firebase;
4
5			/**
6			* PHP7 FIREBASE LIBRARY (http://samuelventimiglia.it/)
7			*
8			*
9			* @link https://github.com/samuel20miglia/zend_Firebase
10			* @copyright Copyright (c) 2016-now Ventimiglia Samuel - Biasin Davide
11			* @license BSD 3-Clause License
12			*
13			*/
14
15			/**
16			*
17			* @author Davide Biasin
18			* @package ZendFirebase
19			*/
20			class FirebaseResponce
21			{
22
23			/**
24			* Data from Firebase
25			*
26			* @var array $firebaseData
27			*/
28			protected $firebaseData;
29
30			/**
31			* Type of operation
32			*
33			* @var string $operation
34			*/
35			protected $operation;
36
37			/**
38			* Http server code
39			*
40			* @var integer $status
41			*/
42			protected $status;
43
44			/**
45			* Format to array the responce
46			*
47			* @return array $firebaseData
48			*/
49			public function getFirebaseData(): array
50			{
51			return $this->firebaseData;
52			}
53
54			/**
55			* Type of Operation
56			*
57			* @return string $operation
58			*/
59			public function getOperation(): string
60			{
61			return $this->operation;
62			}
63
64			/**
65			* Status from http server
66			*
67			* @return integer $status
68			*/
69			public function getStatus(): int
70			{
71			return $this->status;
72			}
73
74			/**
75			* Set data from firebase api
76			*
77			* @param array $firebaseData
78			*/
79			protected function setFirebaseData($firebaseData)
80			{
81			$this->firebaseData = $firebaseData;
82			}
83
84			/**
85			* Set type of operation
86			*
87			* @param string $operation
88			*/
89			protected function setOperation($operation)
90			{
91			$this->operation = $operation;
92			}
93
94			/**
95			* Set status responce
96			*
97			* @param integer $status
98			*/
99			protected function setStatus($status)
100			{
101			$this->status = $status;
102			}
103
104			/**
105			* Method for validate data arrives in _costruct.
106			* If all data was correct skip function without returns.
107			*
108			* @throws \Exception
109			*/
110			protected function validateResponce()
111			{
112			try {
113			/* check validity of Operation */
114			$this->validateOperation();
115
116			/* check validity of Status */
117			$this->validateStatus();
118
119			/* check validity of FirebaseData */
120			$this->validateData();
121			} catch (\Exception $e) {
122			throw $e->getMessage();
123			}
124			}
125
126			/**
127			* Validate type of data receved
128			*
129			* @throws \Exception
130			*/
131			private function validateOperation()
132			{
133			if (! is_string($this->getOperation())) {
134			$getOperation = "Operation parameter must be STRING and NOT EMPTY. Received : ";
135			$getOperation .= gettype($this->getOperation()) . " ({$this->getOperation()}).";
136
137			throw new \Exception($getOperation);
138			}
139			}
140
141			/**
142			* Validate type of data receved
143			*
144			* @throws \Exception
145			*/
146			private function validateStatus()
147			{
148			if (! is_numeric($this->getStatus())) {
149			$getStatus = "Status parameter must be NUMERIC. Received : ";
150			$getStatus .= gettype($this->getStatus()) . " ({$this->getStatus()}).";
151
152			throw new \Exception($getStatus);
153			}
154			}
155
156			/**
157			* Validate type of data receved
158			*
159			* @throws \Exception
160			*/
161			private function validateData()
162			{
163			if (! is_array($this->getFirebaseData())) {
164			$gettype = "FirebaseData parameter must be ARRAY. Received : " . gettype($this->getFirebaseData()) . ".";
165			throw new \Exception($gettype);
166			}
167			}
168
169			/**
170			* Validate type of json receved
171			*
172			* @return string
173			*/
174			protected function validateJson():string
175			{
176			switch (json_last_error()) {
177			case JSON_ERROR_NONE:
178			$jsonValidator = '';
179			break;
180			case JSON_ERROR_STATE_MISMATCH:
181			$jsonValidator = ' - Underflow or the modes mismatch';
182			break;
183			case JSON_ERROR_SYNTAX:
184			$jsonValidator = ' - Syntax error, malformed JSON';
185			break;
186			case JSON_ERROR_UTF8:
187			$jsonValidator = ' - Malformed UTF-8 characters, possibly incorrectly encoded';
188			break;
189			}
190
191			return $jsonValidator;
			0 ignored issues – show Bug introduced 2017-01-17 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$jsonValidator` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
192			}
193			}
194

Samuel18 / zend_Firebase

Issues (8)

Security Analysis no request data

src/FirebaseResponce.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like