Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types = 1); |
||
13 | class FunctionGenerator extends AbstractGenerator |
||
14 | { |
||
15 | /** @var string Function name */ |
||
16 | protected $name; |
||
17 | |||
18 | /** |
||
19 | * FunctionGenerator constructor. |
||
20 | * |
||
21 | * @param GenericGenerator $parent Parent Generator |
||
22 | * @param string $name Function name |
||
23 | */ |
||
24 | public function __construct(string $name, GenericGenerator $parent = null) |
||
30 | |||
31 | /** |
||
32 | * Build function definition. |
||
33 | * |
||
34 | * @return string Function definition |
||
35 | */ |
||
36 | protected function buildDefinition() |
||
40 | |||
41 | /** |
||
42 | * {@inheritdoc} |
||
43 | */ |
||
44 | View Code Duplication | public function code($indentation = 0) : string |
|
60 | } |
||
61 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.