AbstractGenerator - Code Metrics - Inspection of "Added different property types generation and test..." - SamsonPHP/generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 650414...7550e7 )

by Vitaly

created 2016-09-04 08:58 UTC

AbstractGenerator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	2
dl	0
loc	95
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
	code()	1	?
A	__construct()	4	1
A	decreaseIndentation()	6	1
A	increaseIndentation()	6	1
A	end()	13	2
A	defComment()	4	1
A	indentation()	4	2

<?php declare(strict_types = 1);
/**
 * Created by Vitaly Iegorov <[email protected]>.
 * on 03.09.16 at 11:37
 */
namespace samsonphp\generator;

/**
 * Abstract code generator.
 *
 * @author Vitaly Egorov <[email protected]>
 */
abstract class AbstractGenerator
{
    /** @var GenericGenerator Parent class generator */
    protected $parent;

    /** @var array Generated code grouped by generator class name */
    protected $generatedCode = [];

    /** @var int Indentation level */
    protected $indentation = 0;

    /**
     * MethodGenerator constructor.
     *
     * @param GenericGenerator $parent Parent generator
     */
    public function __construct(AbstractGenerator $parent = null)
    {
        $this->parent = $parent;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Decrease indentation.
     *
     * @return $this
     */
    public function decreaseIndentation() : AbstractGenerator
    {
        $this->indentation--;

        return $this;
    }

    /**
     * Increase indentation.
     *
     * @return $this
     */
    public function increaseIndentation() : AbstractGenerator
    {
        $this->indentation++;

        return $this;
    }

    /**
     * Close current generator and return parent.
     *
     * @return AbstractGenerator Parent
     */
    public function end() : AbstractGenerator
    {
        // Create array item
        $class = get_class($this);
        if (!array_key_exists($class, $this->parent->generatedCode)) {

            $this->parent->generatedCode[$class] = '';

        }

        // Pass generated code to parent
        $this->parent->generatedCode[$class] .= $this->code($this->indentation);


        return $this->parent;
    }

    /**
     * Generate code.
     *
     * @param int $indentation Code level
     *
     * @return string Generated code
     */
    abstract public function code(int $indentation = 0) : string;

    /**
     * Set Comments block.
     *
     * @return CommentsGenerator Comments block generator
     */
    public function defComment() : CommentsGenerator
    {
        return new CommentsGenerator($this);
    }

    /**
     * Get indentation string.
     *
     * @param int $indentation Code level
     *
     * @return string Indentation string
     */
    protected function indentation(int $indentation = 0) : string
    {
        return implode('', $indentation > 0 ? array_fill(0, $indentation, '    ') : []);
    }
}


1			<?php declare(strict_types = 1);
2			/**
3			* Created by Vitaly Iegorov <[email protected]>.
4			* on 03.09.16 at 11:37
5			*/
6			namespace samsonphp\generator;
7
8			/**
9			* Abstract code generator.
10			*
11			* @author Vitaly Egorov <[email protected]>
12			*/
13			abstract class AbstractGenerator
14			{
15			/** @var GenericGenerator Parent class generator */
16			protected $parent;
17
18			/** @var array Generated code grouped by generator class name */
19			protected $generatedCode = [];
20
21			/** @var int Indentation level */
22			protected $indentation = 0;
23
24			/**
25			* MethodGenerator constructor.
26			*
27			* @param GenericGenerator $parent Parent generator
28			*/
29			public function __construct(AbstractGenerator $parent = null)
30			{
31			$this->parent = $parent;
			0 ignored issues – show Documentation Bug introduced 2016-09-03 10:19 UTC by Report Bug Copy Issue Report It seems like `$parent` can also be of type `object<samsonphp\generator\AbstractGenerator>`. However, the property `$parent` is declared as type `object<samsonphp\generator\GenericGenerator>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
32			}
33
34			/**
35			* Decrease indentation.
36			*
37			* @return $this
38			*/
39			public function decreaseIndentation() : AbstractGenerator
40			{
41			$this->indentation--;
42
43			return $this;
44			}
45
46			/**
47			* Increase indentation.
48			*
49			* @return $this
50			*/
51			public function increaseIndentation() : AbstractGenerator
52			{
53			$this->indentation++;
54
55			return $this;
56			}
57
58			/**
59			* Close current generator and return parent.
60			*
61			* @return AbstractGenerator Parent
62			*/
63			public function end() : AbstractGenerator
64			{
65			// Create array item
66			$class = get_class($this);
67			if (!array_key_exists($class, $this->parent->generatedCode)) {
			0 ignored issues – show Bug introduced 2016-09-04 08:42 UTC by Report Bug Copy Issue Report The property `generatedCode` cannot be accessed from this context as it is declared `protected` in class `samsonphp\generator\AbstractGenerator`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
68			$this->parent->generatedCode[$class] = '';
			0 ignored issues – show Bug introduced 2016-09-04 08:42 UTC by Report Bug Copy Issue Report The property `generatedCode` cannot be accessed from this context as it is declared `protected` in class `samsonphp\generator\AbstractGenerator`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
69			}
70
71			// Pass generated code to parent
72			$this->parent->generatedCode[$class] .= $this->code($this->indentation);
			0 ignored issues – show Bug introduced 2016-09-03 10:19 UTC by Report Bug Copy Issue Report The property `generatedCode` cannot be accessed from this context as it is declared `protected` in class `samsonphp\generator\AbstractGenerator`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
73
74			return $this->parent;
75			}
76
77			/**
78			* Generate code.
79			*
80			* @param int $indentation Code level
81			*
82			* @return string Generated code
83			*/
84			abstract public function code(int $indentation = 0) : string;
85
86			/**
87			* Set Comments block.
88			*
89			* @return CommentsGenerator Comments block generator
90			*/
91			public function defComment() : CommentsGenerator
92			{
93			return new CommentsGenerator($this);
94			}
95
96			/**
97			* Get indentation string.
98			*
99			* @param int $indentation Code level
100			*
101			* @return string Indentation string
102			*/
103			protected function indentation(int $indentation = 0) : string
104			{
105			return implode('', $indentation > 0 ? array_fill(0, $indentation, ' ') : []);
106			}
107			}
108

SamsonPHP / generator

Push — master ( 650414...7550e7 )

AbstractGenerator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like