JsynExtractor::__toString() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/Samsha..." - Samshal/Scripd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cfa990...8d390f )

by Samuel

created 2016-05-03 07:41 UTC

JsynExtractor::__toString() A

↳ Parent: JsynExtractor

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * This file is part of the samshal/scripd package.
 *
 * (c) Samuel Adeshina <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Samshal\Scripd;

/**
 * Contains utility methods for parsing a jsyn file.
 *
 * @since  1.0
 *
 * @author Samuel Adeshina <[email protected]>
 */
final class JsynExtractor
{
    /**
     * @var string
     *
     * Content of the JSYN File
     */
    private $jsyn;

    /**
     * @var string
     *
     * SQL Syntax to use for script generation
     */
    private $sqlSyntax;

    /**
     * @param $jsynFile string | PathUtil
     * @param $sqlSyntax string
     *
     * @return null

     */
    public function __construct($jsynFile, $sqlSyntax)
    {
        self::setJsynFile($jsynFile);
        self::setSqlSyntax($sqlSyntax);
    }

    /**
     * @param $jsynFile string | PathUtil
     *
     * Setter function for the jsonFile global property
     *
     * @return null
     */
    public function setJsynFile($jsynFile)
    {
        $this->jsyn = json_decode(file_get_contents($jsynFile));

        if (isset($this->sqlSyntax)) {
            $sqlSyntax = $this->sqlSyntax;
            $this->jsyn = $this->jsyn->$sqlSyntax;
        }

        return;
    }

     /**
     * @param $sqlSyntax string
     *
     * Setter function for the sqlSyntax global property
     *
     * @return null
     */
    public function setSqlSyntax($sqlSyntax)
    {
        $this->sqlSyntax = $sqlSyntax;

        if (isset($this->jsyn->$sqlSyntax)) {
            $this->jsyn = $this->jsyn->$sqlSyntax;
        }

        return;
    }

     /**
     * @return Array
     */
    public function getJsyn()
    {
        return $this->jsyn;
    }

     /**
     * Performs extraction of the appropriate sql syntax
     * fromthe supplied jsyn file.
     *
     * @return null
     */
    public function formatJsyn()
    {
        for ($i = 0; $i < count($this->jsyn); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if (strpos($this->jsyn[$i], '[') === 0 || strpos($this->jsyn[$i], '{') === (int) 0) {
                $this->jsyn[$i] = strtolower($this->jsyn[$i]);
            } else {
                $this->jsyn[$i] = strtoupper($this->jsyn[$i]);
            }
        }
    }

    /**
     * Returns the extracted jsyn as a string
     *
     * @return null
     */
    public function __toString()
    {
        return implode(' ', $this->getJsyn());
    }
}


1			<?php
2
3			/*
4			* This file is part of the samshal/scripd package.
5			*
6			* (c) Samuel Adeshina <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Samshal\Scripd;
13
14			/**
15			* Contains utility methods for parsing a jsyn file.
16			*
17			* @since 1.0
18			*
19			* @author Samuel Adeshina <[email protected]>
20			*/
21			final class JsynExtractor
22			{
23			/**
24			* @var string
25			*
26			* Content of the JSYN File
27			*/
28			private $jsyn;
29
30			/**
31			* @var string
32			*
33			* SQL Syntax to use for script generation
34			*/
35			private $sqlSyntax;
36
37			/**
38			* @param $jsynFile string \| PathUtil
39			* @param $sqlSyntax string
40			*
41			* @return null
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-05-03 07:43 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
42			*/
43			public function __construct($jsynFile, $sqlSyntax)
44			{
45			self::setJsynFile($jsynFile);
46			self::setSqlSyntax($sqlSyntax);
47			}
48
49			/**
50			* @param $jsynFile string \| PathUtil
51			*
52			* Setter function for the jsonFile global property
53			*
54			* @return null
55			*/
56			public function setJsynFile($jsynFile)
57			{
58			$this->jsyn = json_decode(file_get_contents($jsynFile));
59
60			if (isset($this->sqlSyntax)) {
61			$sqlSyntax = $this->sqlSyntax;
62			$this->jsyn = $this->jsyn->$sqlSyntax;
63			}
64
65			return;
66			}
67
68			/**
69			* @param $sqlSyntax string
70			*
71			* Setter function for the sqlSyntax global property
72			*
73			* @return null
74			*/
75			public function setSqlSyntax($sqlSyntax)
76			{
77			$this->sqlSyntax = $sqlSyntax;
78
79			if (isset($this->jsyn->$sqlSyntax)) {
80			$this->jsyn = $this->jsyn->$sqlSyntax;
81			}
82
83			return;
84			}
85
86			/**
87			* @return Array
88			*/
89			public function getJsyn()
90			{
91			return $this->jsyn;
92			}
93
94			/**
95			* Performs extraction of the appropriate sql syntax
96			* fromthe supplied jsyn file.
97			*
98			* @return null
99			*/
100			public function formatJsyn()
101			{
102			for ($i = 0; $i < count($this->jsyn); ++$i) {
			0 ignored issues – show Performance Best Practice introduced 2016-04-29 18:29 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
103			if (strpos($this->jsyn[$i], '[') === 0 \|\| strpos($this->jsyn[$i], '{') === (int) 0) {
104			$this->jsyn[$i] = strtolower($this->jsyn[$i]);
105			} else {
106			$this->jsyn[$i] = strtoupper($this->jsyn[$i]);
107			}
108			}
109			}
110
111			/**
112			* Returns the extracted jsyn as a string
113			*
114			* @return null
115			*/
116			public function __toString()
117			{
118			return implode(' ', $this->getJsyn());
119			}
120			}
121

Samshal / Scripd

Push — master ( cfa990...8d390f )

JsynExtractor::__toString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like