Samsara\Fermat\Values\Geometry\CoordinateSystems\PolarCoordinate

Complexity

Total Complexity

8

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Test Coverage

Coverage

70.83%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	distanceTo()	0	3	1
A	asPolar()	0	3	1
A	getDistanceFromOrigin()	0	3	1
A	__construct()	0	16	2
A	getPolarAngle()	0	3	1
A	asCartesian()	0	10	2

<?php

namespace Samsara\Fermat\Values\Geometry\CoordinateSystems;

use Samsara\Fermat\Numbers;
use Samsara\Fermat\Types\Base\Interfaces\Coordinates\CoordinateInterface;
use Samsara\Fermat\Types\Base\Interfaces\Coordinates\TwoDCoordinateInterface;
use Samsara\Fermat\Types\Coordinate;
use Samsara\Fermat\Values\ImmutableDecimal;

class PolarCoordinate extends Coordinate implements TwoDCoordinateInterface
{
    /** @var CartesianCoordinate */
    protected $cachedCartesian;

    public function __construct($rho, $theta)
    {
        $theta = Numbers::makeOrDont(Numbers::IMMUTABLE, $theta);

        $theta = $theta->continuousModulo(Numbers::TAU);

The method continuousModulo() does not exist on Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface. It seems like you code against a sub-type of Samsara\Fermat\Types\Base\Interfaces\Numbers\NumberInterface such as Samsara\Fermat\Types\Base\Interfaces\Numbers\DecimalInterface or Samsara\Fermat\Types\Decimal.

        if ($theta->isNegative()) {
            $theta = Numbers::makeTau($theta->getScale())->add($theta);
        }

        $data = [
            'rho' => $rho,
            'theta' => $theta
        ];

        parent::__construct($data);
    }

    public function getDistanceFromOrigin(): ImmutableDecimal
    {
        return $this->getAxis('rho');
    }

    public function distanceTo(CoordinateInterface $coordinate): ImmutableDecimal
    {
        return $this->asCartesian()->distanceTo($coordinate);
    }

    public function asCartesian(): CartesianCoordinate
    {
        if (is_null($this->cachedCartesian)) {
            $x = $this->getAxis('rho')->multiply($this->getAxis('theta')->cos());
            $y = $this->getAxis('rho')->multiply($this->getAxis('theta')->sin());

            $this->cachedCartesian = new CartesianCoordinate($x, $y);

It seems like $y can also be of type Samsara\Fermat\Values\ImmutableDecimal; however, parameter $y of Samsara\Fermat\Values\Geometry\CoordinateSystems\CartesianCoordinate::__construct() does only seem to accept null, maybe add an additional type check?

        }

        return $this->cachedCartesian;
    }

    public function getPolarAngle(): ImmutableDecimal
    {
        return $this->getAxis('theta');
    }

    public function asPolar(): PolarCoordinate
    {
        return $this;
    }

}