ExcludeWeekendConstraint::apply() - Code Metrics - Inspection of "[WIP] Feature constraints" - Samffy/recurrence - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Samuel

created 2017-12-04 22:34 UTC

ExcludeWeekendConstraint::apply() A

↳ Parent: ExcludeWeekendConstraint

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2

<?php

namespace Recurrence\Constraint;

use Recurrence\Model\Recurrence;

/**
 * Class ExcludeWeekendConstraint
 * @package Recurrence\Constraint
 */
class ExcludeWeekendConstraint implements RecurrenceConstraintInterface
{

    /**
     * @param Recurrence $recurrence
     * @param \Datetime $datetime
     * @return \Datetime
     */
    public function apply(Recurrence $recurrence, \Datetime $datetime)
    {
        if ($this->isWeekend($datetime)) {
            // Add 1 or 2 days to skip weekend (we didn't use `next monday` pattern of \Datetime::format cause it remove time)
            $days = (7 - (int) $datetime->format('N') + 1);
            $datetime->modify(sprintf('+%d days', $days));
        }

        return $datetime;
    }

    /**
     * @param \Datetime $date
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return bool
     */
    private function isWeekend($datetime) {
        return ((int) $datetime->format('N') >= 6);
    }
}


1			<?php
2
3			namespace Recurrence\Constraint;
4
5			use Recurrence\Model\Recurrence;
6
7			/**
8			* Class ExcludeWeekendConstraint
9			* @package Recurrence\Constraint
10			*/
11			class ExcludeWeekendConstraint implements RecurrenceConstraintInterface
12			{
13
14			/**
15			* @param Recurrence $recurrence
16			* @param \Datetime $datetime
17			* @return \Datetime
18			*/
19			public function apply(Recurrence $recurrence, \Datetime $datetime)
20			{
21			if ($this->isWeekend($datetime)) {
22			// Add 1 or 2 days to skip weekend (we didn't use `next monday` pattern of \Datetime::format cause it remove time)
23			$days = (7 - (int) $datetime->format('N') + 1);
24			$datetime->modify(sprintf('+%d days', $days));
25			}
26
27			return $datetime;
28			}
29
30			/**
31			* @param \Datetime $date
			0 ignored issues – show Bug introduced 2017-12-04 22:38 UTC by Report Bug Copy Issue Report There is no parameter named `$date`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
32			* @return bool
33			*/
34			private function isWeekend($datetime) {
35			return ((int) $datetime->format('N') >= 6);
36			}
37			}
38

Samffy / recurrence

Pull Request — master (#18)

ExcludeWeekendConstraint::apply() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like