CarMutation - Code Metrics - Inspection of "Merge pull request #1 from Samffy/feature_mutation" - Samffy/graphql-poc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2d9e7d...e8a8b9 )

by Samuel

created 2018-06-30 16:56 UTC

CarMutation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	69
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	3
dl	69
loc	69
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	createCar()	12	12	2
A	updateCar()	14	14	2
A	getAliases()	6	6	1

How to fix Duplicated Code

<?php

namespace App\Vehicle\App\Mutation;

use App\Common\App\Transformer\AppGlobalId;
use App\Vehicle\Domain\Car;
use App\Vehicle\Domain\VehicleRepositoryInterface;
use GraphQL\Error\UserError;
use Overblog\GraphQLBundle\Definition\Resolver\AliasedInterface;
use Overblog\GraphQLBundle\Definition\Resolver\MutationInterface;

class CarMutation implements MutationInterface, AliasedInterface

{
    /**
     * @var VehicleRepositoryInterface
     */
    private $vehicleRepository;

    /**
     * @param VehicleRepositoryInterface $vehicleRepository
     */
    public function __construct(VehicleRepositoryInterface $vehicleRepository)
    {
        $this->vehicleRepository = $vehicleRepository;
    }

    /**
     * @param string $id
     * @param string $manufacturer
     * @param string $model
     * @param int $seatsNumber
     * @return Car
     * @throws \Doctrine\ORM\NonUniqueResultException
     */
    public function createCar(string $id, string $manufacturer, string $model, int $seatsNumber): Car
    {
        if ($car = $this->vehicleRepository->find($id)) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            throw new UserError(sprintf('Car [%s] already exist', AppGlobalId::toGlobalId('Car', $id)));

            return $car;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        return $this->vehicleRepository->save(
            new Car($id, $manufacturer, $model, $seatsNumber)
        );
    }

    /**
     * @param string $id
     * @param string $manufacturer
     * @param string $model
     * @param int $seatsNumber
     * @return Car
     * @throws \Doctrine\ORM\NonUniqueResultException
     */
    public function updateCar(string $id, string $manufacturer, string $model, int $seatsNumber): Car
    {
        if (!$car = $this->vehicleRepository->find($id)) {
            throw new UserError(sprintf('Car [%s] not found', AppGlobalId::toGlobalId('Car', $id)));
        }

        $car
            ->setManufacturer($manufacturer)
            ->setModel($model)
            ->setSeatsNumber($seatsNumber)
        ;

        return $this->vehicleRepository->save($car);
    }

    /**
     * {@inheritdoc}
     */
    public static function getAliases(): array
    {
        return [
            'resolve' => 'CarMutation',
        ];
    }
}


1		<?php
2
3		namespace App\Vehicle\App\Mutation;
4
5		use App\Common\App\Transformer\AppGlobalId;
6		use App\Vehicle\Domain\Car;
7		use App\Vehicle\Domain\VehicleRepositoryInterface;
8		use GraphQL\Error\UserError;
9		use Overblog\GraphQLBundle\Definition\Resolver\AliasedInterface;
10		use Overblog\GraphQLBundle\Definition\Resolver\MutationInterface;
11
12	View Code Duplication	class CarMutation implements MutationInterface, AliasedInterface
		0 ignored issues – show Duplication introduced 2018-06-30 16:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* @var VehicleRepositoryInterface
16		*/
17		private $vehicleRepository;
18
19		/**
20		* @param VehicleRepositoryInterface $vehicleRepository
21		*/
22		public function __construct(VehicleRepositoryInterface $vehicleRepository)
23		{
24		$this->vehicleRepository = $vehicleRepository;
25		}
26
27		/**
28		* @param string $id
29		* @param string $manufacturer
30		* @param string $model
31		* @param int $seatsNumber
32		* @return Car
33		* @throws \Doctrine\ORM\NonUniqueResultException
34		*/
35		public function createCar(string $id, string $manufacturer, string $model, int $seatsNumber): Car
36		{
37		if ($car = $this->vehicleRepository->find($id)) {
		0 ignored issues – show Unused Code introduced 2018-06-30 16:55 UTC by Report Bug Copy Issue Report `$car` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38		throw new UserError(sprintf('Car [%s] already exist', AppGlobalId::toGlobalId('Car', $id)));
39
40		return $car;
		0 ignored issues – show Unused Code introduced 2018-06-30 16:55 UTC by Report Bug Copy Issue Report `return $car;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
41		}
42
43		return $this->vehicleRepository->save(
44		new Car($id, $manufacturer, $model, $seatsNumber)
45		);
46		}
47
48		/**
49		* @param string $id
50		* @param string $manufacturer
51		* @param string $model
52		* @param int $seatsNumber
53		* @return Car
54		* @throws \Doctrine\ORM\NonUniqueResultException
55		*/
56		public function updateCar(string $id, string $manufacturer, string $model, int $seatsNumber): Car
57		{
58		if (!$car = $this->vehicleRepository->find($id)) {
59		throw new UserError(sprintf('Car [%s] not found', AppGlobalId::toGlobalId('Car', $id)));
60		}
61
62		$car
63		->setManufacturer($manufacturer)
64		->setModel($model)
65		->setSeatsNumber($seatsNumber)
66		;
67
68		return $this->vehicleRepository->save($car);
69		}
70
71		/**
72		* {@inheritdoc}
73		*/
74		public static function getAliases(): array
75		{
76		return [
77		'resolve' => 'CarMutation',
78		];
79		}
80		}
81

Samffy / graphql-poc

Push — master ( 2d9e7d...e8a8b9 )

CarMutation A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like