SaleDetailsRepository - Code Metrics - Saluki/Barmate - Measure and Improve Code Quality continuously with Scrutinizer

SaleDetailsRepository A
last analyzed 2016-01-19 13:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	5
c	2
b	0
f	0
lcom	0
cbo	3
dl	15
loc	45
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getModelName()	0	4	1
A	store()	0	20	2
A	validate()	15	15	2

How to fix Duplicated Code

<?php namespace App\Repositories;

use App\Exceptions\RepositoryException;
use App\Models\SaleDetails;
use Validator;

class SaleDetailsRepository extends Repository{

    public function getModelName()
    {
        return 'App\Models\SaleDetails';
    }

    public function store(array $data)
    {
        $this->validate($data);

        try
        {
            $detail = new SaleDetails();

            $detail->sale_id       = intval($data['sale_id']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $detail->product_id    = intval($data['product_id']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $detail->quantity      = intval($data['quantity']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $detail->current_price = floatval($data['current_price']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $detail->save();
        }
        catch(\Exception $e)
        {
            throw new RepositoryException("Could not store sale detail: ".$e->getMessage(), RepositoryException::DATABASE_ERROR);
        }
    }

    public function validate(array $data)

    {
        $validator = Validator::make($data,
            [
                'sale_id'       => 'required|integer|min:0',
                'product_id'    => 'required|integer|min:0',
                'quantity'      => 'required|integer|min:0',
                'current_price' => 'required|numeric|min:0'
            ]
        );

        if( $validator->fails() ) {
            throw new RepositoryException('Sale detail validation failed', RepositoryException::VALIDATION_FAILED);
        }
    }

}

1		<?php namespace App\Repositories;
2
3		use App\Exceptions\RepositoryException;
4		use App\Models\SaleDetails;
5		use Validator;
6
7		class SaleDetailsRepository extends Repository{
8
9		public function getModelName()
10		{
11		return 'App\Models\SaleDetails';
12		}
13
14		public function store(array $data)
15		{
16		$this->validate($data);
17
18		try
19		{
20		$detail = new SaleDetails();
21
22		$detail->sale_id = intval($data['sale_id']);
		0 ignored issues – show Documentation introduced 2015-11-24 09:38 UTC by Report Bug Copy Issue Report The property `sale_id` does not exist on `object<App\Models\SaleDetails>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23		$detail->product_id = intval($data['product_id']);
		0 ignored issues – show Documentation introduced 2015-11-24 09:38 UTC by Report Bug Copy Issue Report The property `product_id` does not exist on `object<App\Models\SaleDetails>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24		$detail->quantity = intval($data['quantity']);
		0 ignored issues – show Documentation introduced 2015-11-24 09:38 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<App\Models\SaleDetails>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25		$detail->current_price = floatval($data['current_price']);
		0 ignored issues – show Documentation introduced 2015-11-24 09:38 UTC by Report Bug Copy Issue Report The property `current_price` does not exist on `object<App\Models\SaleDetails>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26
27		$detail->save();
28		}
29		catch(\Exception $e)
30		{
31		throw new RepositoryException("Could not store sale detail: ".$e->getMessage(), RepositoryException::DATABASE_ERROR);
32		}
33		}
34
35	View Code Duplication	public function validate(array $data)
		0 ignored issues – show Duplication introduced 2015-11-24 09:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$validator = Validator::make($data,
38		[
39		'sale_id' => 'required\|integer\|min:0',
40		'product_id' => 'required\|integer\|min:0',
41		'quantity' => 'required\|integer\|min:0',
42		'current_price' => 'required\|numeric\|min:0'
43		]
44		);
45
46		if( $validator->fails() ) {
47		throw new RepositoryException('Sale detail validation failed', RepositoryException::VALIDATION_FAILED);
48		}
49		}
50
51		}

Saluki / Barmate

SaleDetailsRepository A last analyzed 2016-01-19 13:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

SaleDetailsRepository A
last analyzed 2016-01-19 13:42 UTC