Salah3id\Domains\Validator\LaravelValidator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	passes()	0	13	2

<?php namespace Salah3id\Domains\Validator;

use Illuminate\Contracts\Validation\Factory;

/**
 * Class LaravelValidator
 * @package Salah3id\Domains\Validator
 * @author Anderson Andrade <contato@andersonandra.de>
 */
class LaravelValidator extends AbstractValidator
{
    /**
     * Validator
     *
     * @var \Illuminate\Validation\Factory
     */
    protected $validator;

    /**
     * Construct
     *
     * @param \Illuminate\Contracts\Validation\Factory $validator
     */
    public function __construct(Factory $validator)
    {
        $this->validator = $validator;

$validator is of type Illuminate\Contracts\Validation\Factory, but the property $validator was declared to be of type Illuminate\Validation\Factory. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * Pass the data and the rules to the validator
     *
     * @param string $action
     * @return bool
     */
    public function passes($action = null)
    {
        $rules      = $this->getRules($action);

It seems like $action can also be of type string; however, parameter $action of Salah3id\Domains\Validator\AbstractValidator::getRules() does only seem to accept null, maybe add an additional type check?

        $messages   = $this->getMessages();
        $attributes = $this->getAttributes();
        $validator  = $this->validator->make($this->data, $rules, $messages, $attributes);

        if ($validator->fails()) {
            $this->errors = $validator->messages();
            return false;
        }

        return true;
    }
}