GuestController::getFields() - Code Metrics - Inspection of "addFlashMessage()" - Saibamen/HotelManager - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Branch — master (065bfc)

by Adam
created 2018-01-03 19:53 UTC
GuestController::getFields() A

↳ Parent: GuestController
Complexity

Conditions	1
Paths	1
Size

Total Lines	74
Code Lines	46
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	38
CRAP Score	1
Importance

Changes
Metric	Value
cc	1
eloc	46
nc	1
nop	0
dl	0
loc	74
ccs	38
cts	38
cp	1
crap	1
rs	9.0335
c	0
b	0
f	0
How to fix Long Method

<?php

namespace App\Http\Controllers;

use App\Http\Requests\GuestRequest;
use App\Models\Guest;
use Illuminate\Database\Eloquent\ModelNotFoundException;

class GuestController extends Controller
{
    private function getRouteName()
    {
        return 'guest';
    }

    public function index()
    {
        $title = trans('general.guests');

        $dataset = Guest::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact')
            ->paginate($this->getItemsPerPage());

        if ($dataset->isEmpty()) {
            $this->addFlashMessage(trans('general.no_guests_in_database'), 'alert-danger');
        }

        $viewData = [
            'columns'       => $this->getColumns(),
            'dataset'       => $dataset,
            'routeName'     => $this->getRouteName(),
            'title'         => $title,
            // TODO
            'deleteMessage' => mb_strtolower(trans('general.guest')).' '.mb_strtolower(trans('general.number')),
            'deleteMessage' => mb_strtolower(/** @scrutinizer ignore-type */ trans('general.guest')).' '.mb_strtolower(trans('general.number')),
        ];

        return view('list', $viewData);
    }

    public function store(GuestRequest $request, $id = null)
    {
        if ($id === null) {
            $object = new Guest();
        } else {
            try {
                $object = Guest::findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                return Controller::/** @scrutinizer ignore-call */ returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger',
                ]);
            }
        }

        $object->fill($request->all());
        $object->save();

        return redirect()->route($this->getRouteName().'.index')
            ->with([
                'message'     => trans('general.saved'),
                'alert-class' => 'alert-success',
            ]);
    }

    public function delete($id)
    {
        Guest::destroy($id);
        $data = ['class' => 'alert-success', 'message' => trans('general.deleted')];

        return response()->json($data);
    }

    // TODO
    public function showAddEditForm($id = null)
    {
        if ($id === null) {
            $dataset = new Guest();
            $title = trans('navigation.add_guest');
            $submitRoute = route($this->getRouteName().'.postadd');
        } else {
            try {
                $dataset = Guest::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact')->findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                return Controller::/** @scrutinizer ignore-call */ returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger',
                ]);
            }

            $title = trans('navigation.edit_guest');
            $submitRoute = route($this->getRouteName().'.postedit', $id);
        }

        $viewData = [
            'dataset'     => $dataset,
            'fields'      => $this->getFields(),
            'title'       => $title,
            'submitRoute' => $submitRoute,
            'routeName'   => $this->getRouteName(),
        ];

        return view('addedit', $viewData);
    }

    // TODO
    private function getFields()
    {
        return [
            [
                'id'    => 'first_name',
                'title' => trans('general.first_name'),
                'value' => function (Guest $data) {
                    return $data->first_name;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'last_name',
                'title' => trans('general.last_name'),
                'value' => function (Guest $data) {
                    return $data->last_name;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'address',
                'title' => trans('general.address'),
                'value' => function (Guest $data) {
                    return $data->address;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'zip_code',
                'title' => trans('general.zip_code'),
                'value' => function (Guest $data) {
                    return $data->zip_code;
                },
                'optional' => [
                    'required'    => 'required',
                    'placeholder' => '00-000',
                ],
            ],
            [
                'id'    => 'place',
                'title' => trans('general.place'),
                'value' => function (Guest $data) {
                    return $data->place;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'PESEL',
                'title' => trans('general.PESEL'),
                'value' => function (Guest $data) {
                    return $data->PESEL;
                },
                'optional' => [
                    'required'    => 'required',
                    'placeholder' => '12345654321',
                ],
            ],
            [
                'id'    => 'contact',
                'title' => trans('general.contact'),
                'value' => function (Guest $data) {
                    return $data->contact;
                },
                'type'     => 'textarea',
                'optional' => [
                    'placeholder' => trans('general.contact_placeholder'),
                ],
            ],
        ];
    }

    private function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.first_name'),
                'value' => function (Guest $data) {
                    return $data->first_name;
                },
            ],
            [
                'title' => trans('general.last_name'),
                'value' => function (Guest $data) {
                    return $data->last_name;
                },
            ],
            [
                'title' => trans('general.address'),
                'value' => function (Guest $data) {
                    return $data->address.', '.$data->zip_code.' '.$data->place;
                },
            ],
            [
                'title' => trans('general.PESEL'),
                'value' => function (Guest $data) {
                    return $data->PESEL;
                },
            ],
            [
                'title' => trans('general.contact'),
                'value' => function (Guest $data) {
                    return $data->contact;
                },
            ],
        ];

        return $dataset;
    }
}

Saibamen / HotelManager

Branch — master (065bfc)

GuestController::getFields() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
