App\Http\Controllers\UserController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

95.24%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	19	2
A	delete()	0	13	4

<?php

namespace App\Http\Controllers;

use App\Models\User;
use App\Services\UserTableService;
use Illuminate\Support\Facades\Auth;

class UserController extends Controller
{
    protected $userTableService;

    public function __construct(UserTableService $userTableService)
    {
        $this->userTableService = $userTableService;
    }

    public function index()
    {
        $title = trans('general.users');

        $dataset = User::select('id', 'name', 'email', 'created_at')
            ->paginate($this->getItemsPerPage());

        if ($dataset->isEmpty()) {
            $this->addFlashMessage(trans('general.no_users_in_database'), 'alert-danger');
        }

        $viewData = [
            'columns'       => $this->userTableService->getColumns(),
            'dataset'       => $dataset,
            'routeName'     => $this->userTableService->getRouteName(),
            'title'         => $title,
        ];

        return view('list', $viewData);
    }

    public function delete($objectId)
    {
        $object = User::find($objectId);
        $data = ['class' => 'alert-success', 'message' => trans('general.deleted')];

        // TODO: isAdmin()
        if (!$object || $object->id === 1 || $object->id = Auth::user()->id /*|| $object->isAdmin()*/) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

72% of this comment could be valid code. Did you maybe forget this after debugging?

            $data = ['class' => 'alert-danger', 'message' => trans('general.cannot_delete_admins')];
        } else {
            User::destroy($objectId);
        }

        return response()->json($data);
    }
}