Saibamen /
HotelManager
| Total Complexity | 40 |
| Total Lines | 508 |
| Duplicated Lines | 0 % |
| Coverage | 69.09% |
| Changes | 0 | ||
Complex classes like ReservationController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ReservationController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | class ReservationController extends Controller implements ManageTableInterface |
||
| 19 | { |
||
| 20 | protected $reservationTableService; |
||
| 21 | |||
| 22 | 14 | public function __construct(ReservationTableService $reservationTableService) |
|
| 25 | 14 | } |
|
| 26 | |||
| 27 | 4 | public function index() |
|
| 28 | { |
||
| 29 | 4 | $title = trans('navigation.all_reservations'); |
|
| 30 | |||
| 31 | 4 | $dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people') |
|
| 32 | 4 | ->with('guest:id,first_name,last_name') |
|
| 33 | 4 | ->with('room:id,number') |
|
| 34 | 4 | ->orderBy('date_end', 'DESC') |
|
| 35 | 4 | ->paginate($this->getItemsPerPage()); |
|
| 36 | |||
| 37 | 4 | if ($dataset->isEmpty()) { |
|
| 38 | 2 | $this->addFlashMessage(trans('general.no_reservations_in_database'), 'alert-danger'); |
|
| 39 | } |
||
| 40 | |||
| 41 | $viewData = [ |
||
| 42 | 4 | 'columns' => $this->reservationTableService->getColumns(), |
|
| 43 | 4 | 'dataset' => $dataset, |
|
| 44 | 4 | 'routeName' => $this->reservationTableService->getRouteName(), |
|
| 45 | 4 | 'title' => $title, |
|
| 46 | ]; |
||
| 47 | |||
| 48 | 4 | return view('list', $viewData); |
|
| 49 | } |
||
| 50 | |||
| 51 | 2 | public function current() |
|
| 52 | { |
||
| 53 | 2 | $title = trans('navigation.current_reservations'); |
|
| 54 | |||
| 55 | 2 | $dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people') |
|
| 56 | 2 | ->with('guest:id,first_name,last_name') |
|
| 57 | 2 | ->with('room:id,number') |
|
| 58 | 2 | ->getCurrentReservations() |
|
| 59 | 2 | ->orderBy('date_end') |
|
| 60 | 2 | ->paginate($this->getItemsPerPage()); |
|
| 61 | |||
| 62 | 2 | if ($dataset->isEmpty()) { |
|
| 63 | 1 | $this->addFlashMessage(trans('general.no_reservations_in_database'), 'alert-danger'); |
|
| 64 | } |
||
| 65 | |||
| 66 | $viewData = [ |
||
| 67 | 2 | 'columns' => $this->reservationTableService->getColumns(), |
|
| 68 | 2 | 'dataset' => $dataset, |
|
| 69 | 2 | 'routeName' => $this->reservationTableService->getRouteName(), |
|
| 70 | 2 | 'title' => $title, |
|
| 71 | ]; |
||
| 72 | |||
| 73 | 2 | return view('list', $viewData); |
|
| 74 | } |
||
| 75 | |||
| 76 | 2 | public function future() |
|
| 77 | { |
||
| 78 | 2 | $title = trans('navigation.future_reservations'); |
|
| 79 | |||
| 80 | 2 | $dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people') |
|
| 81 | 2 | ->with('guest:id,first_name,last_name') |
|
| 82 | 2 | ->with('room:id,number') |
|
| 83 | 2 | ->getFutureReservations() |
|
| 84 | 2 | ->orderBy('date_end') |
|
| 85 | 2 | ->paginate($this->getItemsPerPage()); |
|
| 86 | |||
| 87 | 2 | if ($dataset->isEmpty()) { |
|
| 88 | 1 | $this->addFlashMessage(trans('general.no_reservations_in_database'), 'alert-danger'); |
|
| 89 | } |
||
| 90 | |||
| 91 | $viewData = [ |
||
| 92 | 2 | 'columns' => $this->reservationTableService->getColumns(), |
|
| 93 | 2 | 'dataset' => $dataset, |
|
| 94 | 2 | 'routeName' => $this->reservationTableService->getRouteName(), |
|
| 95 | 2 | 'title' => $title, |
|
| 96 | ]; |
||
| 97 | |||
| 98 | 2 | return view('list', $viewData); |
|
| 99 | } |
||
| 100 | |||
| 101 | 3 | public function chooseGuest(GuestTableService $guestTableService) |
|
| 102 | { |
||
| 103 | 3 | $title = trans('navigation.choose_guest'); |
|
| 104 | |||
| 105 | 3 | $dataset = Guest::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact') |
|
| 106 | 3 | ->paginate($this->getItemsPerPage()); |
|
| 107 | |||
| 108 | 3 | if ($dataset->isEmpty()) { |
|
| 109 | 1 | $this->addFlashMessage(trans('general.no_guests_in_database'), 'alert-danger'); |
|
| 110 | } |
||
| 111 | |||
| 112 | $viewData = [ |
||
| 113 | 3 | 'columns' => $guestTableService->getColumns(), |
|
| 114 | 3 | 'dataset' => $dataset, |
|
| 115 | 3 | 'routeName' => $guestTableService->getRouteName(), |
|
| 116 | 3 | 'title' => $title, |
|
| 117 | 3 | 'routeChooseName' => $this->reservationTableService->getRouteName().'.search_free_rooms', |
|
| 118 | ]; |
||
| 119 | |||
| 120 | 3 | return view('list', $viewData); |
|
| 121 | } |
||
| 122 | |||
| 123 | 3 | public function searchFreeRooms($guestId) |
|
| 124 | { |
||
| 125 | try { |
||
| 126 | 3 | $guest = Guest::select('id', 'first_name', 'last_name')->findOrFail($guestId); |
|
| 127 | } catch (ModelNotFoundException $e) { |
||
| 128 | return $this->returnBack([ |
||
| 129 | 'message' => trans('general.object_not_found'), |
||
| 130 | 'alert-class' => 'alert-danger', |
||
| 131 | ]); |
||
| 132 | } |
||
| 133 | |||
| 134 | 3 | $dataset = new Reservation(); |
|
| 135 | 3 | $dataset->guest()->associate($guest); |
|
| 136 | 3 | $title = trans('navigation.search_free_rooms'); |
|
| 137 | 3 | $submitRoute = route($this->reservationTableService->getRouteName().'.post_search_free_rooms', $dataset->guest->id); |
|
|
Bug
introduced
by
|
|||
| 138 | |||
| 139 | 3 | $fiels = $this->getFields(); |
|
| 140 | 3 | array_unshift($fiels, $this->getGuestField()); |
|
| 141 | |||
| 142 | $viewData = [ |
||
| 143 | 3 | 'dataset' => $dataset, |
|
| 144 | 3 | 'fields' => $fiels, |
|
| 145 | 3 | 'title' => $title, |
|
| 146 | 3 | 'submitRoute' => $submitRoute, |
|
| 147 | ]; |
||
| 148 | |||
| 149 | 3 | return view('addedit', $viewData); |
|
| 150 | } |
||
| 151 | |||
| 152 | 2 | public function postSearchFreeRooms(ReservationSearchRequest $request, $guestId = null) |
|
| 153 | { |
||
| 154 | try { |
||
| 155 | 2 | $guest = Guest::select('id')->findOrFail($guestId); |
|
| 156 | } catch (ModelNotFoundException $e) { |
||
| 157 | return $this->returnBack([ |
||
| 158 | 'message' => trans('general.object_not_found'), |
||
| 159 | 'alert-class' => 'alert-danger', |
||
| 160 | ]); |
||
| 161 | } |
||
| 162 | |||
| 163 | 2 | $data = $request->only(['date_start', 'date_end', 'people']); |
|
| 164 | |||
| 165 | 2 | return redirect()->route($this->reservationTableService->getRouteName().'.choose_free_room', $guest->id) |
|
| 166 | 2 | ->with($data); |
|
| 167 | } |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @param RoomTableService $roomTableService |
||
| 171 | * @param int $guestId |
||
| 172 | * |
||
| 173 | * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\RedirectResponse|\Illuminate\View\View |
||
| 174 | */ |
||
| 175 | 2 | public function chooseFreeRoom(RoomTableService $roomTableService, $guestId) |
|
| 223 | } |
||
| 224 | |||
| 225 | 1 | public function add($guestId, $roomId) |
|
| 226 | { |
||
| 227 | 1 | if (!$this->isReservationDataInSessionCorrect()) { |
|
| 228 | return $this->returnBack([ |
||
| 229 | 'message' => trans('general.object_not_found'), |
||
| 230 | 'alert-class' => 'alert-danger', |
||
| 231 | ]); |
||
| 232 | } |
||
| 233 | |||
| 234 | 1 | $dateStart = Session::get('date_start'); |
|
| 235 | 1 | $dateEnd = Session::get('date_end'); |
|
| 236 | 1 | $people = Session::get('people'); |
|
| 237 | |||
| 238 | try { |
||
| 239 | 1 | $guest = Guest::select('id')->findOrFail($guestId); |
|
| 240 | 1 | $room = Room::select('id')->findOrFail($roomId); |
|
| 241 | } catch (ModelNotFoundException $e) { |
||
| 242 | Log::warning(__CLASS__.'::'.__FUNCTION__.' at '.__LINE__.': '.$e->getMessage()); |
||
| 243 | |||
| 244 | return $this->returnBack([ |
||
| 245 | 'message' => trans('general.object_not_found'), |
||
| 246 | 'alert-class' => 'alert-danger', |
||
| 247 | ]); |
||
| 248 | } |
||
| 249 | |||
| 250 | 1 | $reservation = new Reservation(); |
|
| 251 | 1 | $reservation->guest_id = $guest->id; |
|
| 252 | 1 | $reservation->room_id = $room->id; |
|
| 253 | 1 | $reservation->date_start = $dateStart; |
|
| 254 | 1 | $reservation->date_end = $dateEnd; |
|
| 255 | 1 | $reservation->people = $people; |
|
| 256 | |||
| 257 | 1 | $reservation->save(); |
|
| 258 | |||
| 259 | 1 | $this->addFlashMessage(trans('general.saved'), 'alert-success'); |
|
| 260 | |||
| 261 | 1 | return redirect()->route($this->reservationTableService->getRouteName().'.index'); |
|
| 262 | } |
||
| 263 | |||
| 264 | // TODO |
||
| 265 | public function store(ReservationSearchRequest $request, $objectId = null) |
||
| 287 | ]); |
||
| 288 | } |
||
| 289 | |||
| 290 | 1 | public function delete($objectId) |
|
| 305 | } |
||
| 306 | |||
| 307 | 2 | public function showEditForm($objectId) |
|
| 308 | { |
||
| 309 | try { |
||
| 310 | 2 | $dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people') |
|
| 311 | 2 | ->with('guest:id,first_name,last_name') |
|
| 312 | 2 | ->with('room:id,number') |
|
| 336 | } |
||
| 337 | |||
| 338 | public function editChooseGuest(GuestTableService $guestTableService, $reservationId) |
||
| 339 | { |
||
| 340 | try { |
||
| 341 | $reservation = Reservation::select('id', 'guest_id') |
||
| 342 | ->findOrFail($reservationId); |
||
| 343 | } catch (ModelNotFoundException $e) { |
||
| 344 | return $this->returnBack([ |
||
| 345 | 'message' => trans('general.object_not_found'), |
||
| 346 | 'alert-class' => 'alert-danger', |
||
| 347 | ]); |
||
| 348 | } |
||
| 349 | |||
| 350 | $title = trans('navigation.change_guest_for_reservation'); |
||
| 351 | |||
| 352 | $dataset = Guest::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact') |
||
| 353 | ->whereNotIn('id', [$reservation->guest_id]) |
||
| 354 | ->paginate($this->getItemsPerPage()); |
||
| 355 | |||
| 356 | if ($dataset->isEmpty()) { |
||
| 357 | $this->addFlashMessage(trans('general.no_guests_in_database'), 'alert-danger'); |
||
| 358 | } |
||
| 359 | |||
| 360 | $viewData = [ |
||
| 361 | 'columns' => $guestTableService->getColumns(), |
||
| 362 | 'dataset' => $dataset, |
||
| 363 | 'routeName' => $guestTableService->getRouteName(), |
||
| 364 | 'title' => $title, |
||
| 365 | 'routeChooseName' => $this->reservationTableService->getRouteName().'.edit_change_guest', |
||
| 366 | 'additionalRouteParams' => $reservation->id, |
||
| 367 | ]; |
||
| 368 | |||
| 369 | return view('list', $viewData); |
||
| 370 | } |
||
| 371 | |||
| 372 | public function editChooseRoom(RoomTableService $roomTableService, $reservationId) |
||
| 407 | } |
||
| 408 | |||
| 409 | 4 | public function getGuestField() |
|
| 410 | { |
||
| 411 | return [ |
||
| 412 | 4 | 'id' => 'guest', |
|
| 413 | 4 | 'title' => trans('general.guest'), |
|
| 414 | 4 | 'value' => function (Reservation $data) { |
|
| 415 | 4 | return $data->guest->full_name; |
|
| 416 | 4 | }, |
|
| 417 | 'optional' => [ |
||
| 418 | 'readonly' => 'readonly', |
||
| 419 | ], |
||
| 420 | ]; |
||
| 421 | } |
||
| 422 | |||
| 423 | 1 | public function getRoomField() |
|
| 424 | { |
||
| 425 | return [ |
||
| 426 | 1 | 'id' => 'room', |
|
| 427 | 1 | 'title' => trans('general.room'), |
|
| 428 | 1 | 'value' => function (Reservation $data) { |
|
| 429 | 1 | return $data->room->number; |
|
| 430 | 1 | }, |
|
| 431 | 'optional' => [ |
||
| 432 | 'readonly' => 'readonly', |
||
| 433 | ], |
||
| 434 | ]; |
||
| 435 | } |
||
| 436 | |||
| 437 | 1 | public function getActionButtons() |
|
| 438 | { |
||
| 439 | return [ |
||
| 440 | 1 | 'id' => 'action_buttons', |
|
| 441 | 1 | 'type' => 'buttons', |
|
| 442 | 'buttons' => [ |
||
| 443 | [ |
||
| 444 | 1 | 'value' => function () { |
|
| 445 | 1 | return 'Zmień gościa'; |
|
| 446 | 1 | }, |
|
| 447 | 1 | 'route_name' => 'reservation.edit_choose_guest', |
|
| 448 | 1 | 'route_param' => function (Reservation $data) { |
|
| 449 | 1 | return $data->id; |
|
| 450 | 1 | }, |
|
| 451 | 'optional' => [ |
||
| 452 | 'class' => 'btn btn-primary', |
||
| 453 | ], |
||
| 454 | ], |
||
| 455 | [ |
||
| 456 | 1 | 'value' => function () { |
|
| 457 | 1 | return 'Zmień pokój'; |
|
| 458 | 1 | }, |
|
| 459 | 1 | 'route_name' => 'reservation.edit_choose_room', |
|
| 460 | 1 | 'route_param' => function (Reservation $data) { |
|
| 461 | 1 | return $data->id; |
|
| 462 | 1 | }, |
|
| 463 | 'optional' => [ |
||
| 464 | 'class' => 'btn btn-primary', |
||
| 465 | ], |
||
| 466 | ], |
||
| 467 | ], |
||
| 468 | ]; |
||
| 469 | } |
||
| 470 | |||
| 471 | 4 | public function getFields() |
|
| 510 | ], |
||
| 511 | ], |
||
| 512 | ]; |
||
| 513 | } |
||
| 514 | |||
| 515 | 2 | private function isReservationDataInSessionCorrect() |
|
| 526 | } |
||
| 527 | } |
||
| 528 |
Loading history...
