App\Http\Controllers\UserController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	141
Duplicated Lines	0 %

Test Coverage

Coverage

41.1%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	postChangePassword()	0	10	1
A	getFields()	0	47	1
A	delete()	0	12	4
A	index()	0	20	2
A	postAdd()	0	12	1
A	showAddForm()	0	14	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\ChangePasswordRequest;
use App\Http\Requests\UserAddRequest;
use App\Models\User;
use App\Services\UserTableService;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;

class UserController extends Controller
{
    protected $userTableService;

    public function __construct(UserTableService $userTableService)
    {
        $this->userTableService = $userTableService;
    }

    public function index()
    {
        $title = trans('general.users');

        $dataset = User::select('id', 'name', 'email', 'created_at')
            ->paginate($this->getItemsPerPage());

        if ($dataset->isEmpty()) {
            $this->addFlashMessage(trans('general.no_users_in_database'), 'alert-danger');
        }

        $viewData = [
            'columns'       => $this->userTableService->getColumns(),
            'dataset'       => $dataset,
            'routeName'     => $this->userTableService->getRouteName(),
            'title'         => $title,
            'disableEdit'   => true,
        ];

        return view('list', $viewData);
    }

    public function showAddForm()
    {
        $dataset = new User();
        $title = trans('navigation.add_user');

        $viewData = [
            'dataset'     => $dataset,
            'fields'      => $this->getFields(),
            'title'       => $title,
            'submitRoute' => route($this->userTableService->getRouteName().'.postadd'),
            'routeName'   => $this->userTableService->getRouteName(),
        ];

        return view('addedit', $viewData);
    }

    public function postAdd(UserAddRequest $request)
    {
        $object = new User();

        $request->merge(['password' => Hash::make($request->password)]);
        $object->fill($request->all());
        $object->save();

        return redirect()->route($this->userTableService->getRouteName().'.index')
            ->with([
                'message'     => trans('general.saved'),
                'alert-class' => 'alert-success',
            ]);
    }

    public function delete($objectId)
    {
        $object = User::find($objectId);
        $data = ['class' => 'alert-success', 'message' => trans('general.deleted')];

        if (!$object || $object->id === 1 || $object->id = Auth::user()->id) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $data = ['class' => 'alert-danger', 'message' => trans('general.cannot_delete_object')];
        } else {
            $object->delete();
        }

        return response()->json($data);
    }

    public function changePassword()
    {
        return view('auth.passwords.change');
    }

    public function postChangePassword(ChangePasswordRequest $request)
    {
        $user = Auth::user();
        $user->password = Hash::make($request->new_password);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user->save();

        return redirect()->route($this->userTableService->getRouteName().'.change_password')
            ->with([
                'message'     => trans('general.saved'),
                'alert-class' => 'alert-success',
            ]);
    }

    public function getFields()
    {
        return [
            [
                'id'    => 'name',
                'title' => trans('general.name'),
                'value' => function (User $data) {
                    return $data->name;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'email',
                'title' => trans('auth.email'),
                'value' => function (User $data) {
                    return $data->email;
                },
                'type'     => 'email',
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'       => 'password',
                'title'    => trans('auth.password'),
                'type'     => 'password',
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'       => 'password_confirmation',
                'title'    => trans('auth.password_confirmation'),
                'type'     => 'password',
                'optional' => [
                    'required'    => 'required',
                ],
            ],
            [
                'id'    => 'is_admin',
                'title' => trans('general.administrator'),
                'value' => function () {
                    return true;
                },
                'type'     => 'checkbox',
            ],
        ];
    }
}