Controller::returnBack() - Code Metrics - Inspection of "Test infinite loop protection" - Saibamen/HotelManager - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ef1203...78513a )

by Adam

created 2018-05-20 16:06 UTC

Controller::returnBack() A

↳ Parent: Controller

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	0
loc	10
ccs	5
cts	5
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Session;

class Controller extends BaseController
{
    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;

    protected function getItemsPerPage()
    {
        return 20;
    }

    protected function addFlashMessage($message, $alertClass = null)
    {
        // Display only one message
        if (!Session::has('message')) {
            Session::flash('message', $message);

            if ($alertClass) {
                Session::flash('alert-class', $alertClass);
            }
        }
    }

    protected function returnBack($data)
    {
        // Zapobiegaj infinite loop
        if (back()->getTargetUrl() === url()->current()) {
            Log::info('Request loop: '.back()->getTargetUrl());

            return redirect(route('room.index'))->with($data);
        }

        return back()->with($data);
    }

    public function changeLanguage($language)
    {
        // 90 dni w minutach
        return back()->cookie('lang', $language, 129600);
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
6		use Illuminate\Foundation\Bus\DispatchesJobs;
7		use Illuminate\Foundation\Validation\ValidatesRequests;
8		use Illuminate\Routing\Controller as BaseController;
9		use Illuminate\Support\Facades\Log;
10		use Illuminate\Support\Facades\Session;
11
12		class Controller extends BaseController
13		{
14		use AuthorizesRequests, DispatchesJobs, ValidatesRequests;
15
16	68	protected function getItemsPerPage()
17		{
18	68	return 20;
19		}
20
21	38	protected function addFlashMessage($message, $alertClass = null)
22		{
23		// Display only one message
24	38	if (!Session::has('message')) {
25	37	Session::flash('message', $message);
26
27	37	if ($alertClass) {
28	37	Session::flash('alert-class', $alertClass);
29		}
30		}
31	38	}
32
33	21	protected function returnBack($data)
34		{
35		// Zapobiegaj infinite loop
36	21	if (back()->getTargetUrl() === url()->current()) {
37	1	Log::info('Request loop: '.back()->getTargetUrl());
38
39	1	return redirect(route('room.index'))->with($data);
40		}
41
42	20	return back()->with($data);
43		}
44
45	3	public function changeLanguage($language)
46		{
47		// 90 dni w minutach
48	3	return back()->cookie('lang', $language, 129600);
49		}
50		}
51

Saibamen / HotelManager

Push — master ( ef1203...78513a )

Controller::returnBack() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like