RoomController::getFields() - Code Metrics - Inspection of "Funkcja store() (WIP), reorganizacja kolejności me..." - Saibamen/HotelManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e9267...ad0247 )

by Adam

created 2017-03-04 02:47 UTC

RoomController::getFields() A

↳ Parent: RoomController

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	59
ccs	0
cts	42
cp	0
rs	9.597
cc	1
eloc	37
nc	1
nop	0
crap	2

How to fix Long Method

<?php

namespace App\Http\Controllers;

use App\Models\Room;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Http\Request;

class RoomController extends Controller
{
    private function getRouteName()
    {
        return 'room';
    }

    public function index()
    {
        $title = trans('general.rooms');

        $dataset = Room::select('id', 'number', 'floor', 'capacity', 'price')
            ->paginate($this->getItemsPerPage());

        $view_data = [
            'columns'    => $this->getColumns(),
            'dataset'    => $dataset,
            'route_name' => $this->getRouteName(),
            'title'      => $title,
        ];

        return view('list', $view_data);
    }

    public function store(/*RoomRequest $request*/ Request $request, $id = null)
    {
        if($id === null) {
            $object = new Room();
        } else {
            try {
                $object = Room::findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger'
                ]);
            }
        }

        $object->fill($request->all());
        $object->save();

        return redirect()->route($this->getRouteName() . '.index')
            ->with([
                'message'     => trans('general.saved'),
                'alert-class' => 'alert-success'
            ]);
    }

    public function delete($id)
    {
        Room::destroy($id);

        $data = ['class' => 'alert-success', 'message' => trans('general.deleted')];

        return response()->json($data);
    }

    public function showAddEditForm($id = null)
    {
        if ($id === null) {
            $dataset = new Room();
            $title = trans('general.add');
            $submit_route = route($this->getRouteName().'.postadd');
        } else {
            try {
                $dataset = Room::findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger',
                ]);
            }

            $title = trans('general.edit');
            $submit_route = route($this->getRouteName().'.postedit', $id);
        }

        $title .= ' '.mb_strtolower(trans('general.room'));

        $view_data = [
            'dataset'      => $dataset,
            'fields'       => $this->getFields(),
            'title'        => $title,
            'submit_route' => $submit_route,
            'route_name'   => $this->getRouteName(),
        ];

        return view('addedit', $view_data);
    }

    private function getFields()
    {
        return [
            [
                'id'    => 'number',
                'title' => trans('general.number'),
                'value' => function (Room $data) {
                    return $data->number;
                },
                'type'     => 'number',
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'floor',
                'title' => trans('general.floor'),
                'value' => function (Room $data) {
                    return $data->floor;
                },
                'type'     => 'number',
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'capacity',
                'title' => trans('general.capacity'),
                'value' => function (Room $data) {
                    return $data->capacity;
                },
                'type'     => 'number',
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'price',
                'title' => trans('general.price'),
                'value' => function (Room $data) {
                    return $data->price;
                },
                'type'     => 'number',
                'optional' => [
                    'step'        => '0.01',
                    'placeholder' => '0.00',
                    'required'    => 'required',
                ],
            ],
            [
                'id'    => 'comments',
                'title' => trans('general.comments'),
                'value' => function (Room $data) {
                    return $data->comments;
                },
                'type' => 'textarea',
            ],
        ];
    }

    private function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.number'),
                'value' => function (Room $data) {
                    return $data->number;
                },
            ],
            [
                'title' => trans('general.floor'),
                'value' => function (Room $data) {
                    return $data->floor;
                },
            ],
            [
                'title' => trans('general.capacity'),
                'value' => function (Room $data) {
                    return $data->capacity;
                },
            ],
            [
                'title' => trans('general.price'),
                'value' => function (Room $data) {
                    return $data->price;
                },
            ],
        ];

        return $dataset;
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Models\Room;
6			use Illuminate\Database\Eloquent\ModelNotFoundException;
7			use Illuminate\Http\Request;
8
9			class RoomController extends Controller
10			{
11			private function getRouteName()
12			{
13			return 'room';
14			}
15
16			public function index()
17			{
18			$title = trans('general.rooms');
19
20			$dataset = Room::select('id', 'number', 'floor', 'capacity', 'price')
21			->paginate($this->getItemsPerPage());
22
23			$view_data = [
24			'columns' => $this->getColumns(),
25			'dataset' => $dataset,
26			'route_name' => $this->getRouteName(),
27			'title' => $title,
28			];
29
30			return view('list', $view_data);
31			}
32
33			public function store(/RoomRequest $request/ Request $request, $id = null)
34			{
35			if($id === null) {
36			$object = new Room();
37			} else {
38			try {
39			$object = Room::findOrFail($id);
40			} catch (ModelNotFoundException $e) {
41			return Controller::returnBack([
42			'message' => trans('general.object_not_found'),
43			'alert-class' => 'alert-danger'
44			]);
45			}
46			}
47
48			$object->fill($request->all());
49			$object->save();
50
51			return redirect()->route($this->getRouteName() . '.index')
52			->with([
53			'message' => trans('general.saved'),
54			'alert-class' => 'alert-success'
55			]);
56			}
57
58			public function delete($id)
59			{
60			Room::destroy($id);
61
62			$data = ['class' => 'alert-success', 'message' => trans('general.deleted')];
63
64			return response()->json($data);
65			}
66
67			public function showAddEditForm($id = null)
68			{
69			if ($id === null) {
70			$dataset = new Room();
71			$title = trans('general.add');
72			$submit_route = route($this->getRouteName().'.postadd');
73			} else {
74			try {
75			$dataset = Room::findOrFail($id);
76			} catch (ModelNotFoundException $e) {
77			return Controller::returnBack([
78			'message' => trans('general.object_not_found'),
79			'alert-class' => 'alert-danger',
80			]);
81			}
82
83			$title = trans('general.edit');
84			$submit_route = route($this->getRouteName().'.postedit', $id);
85			}
86
87			$title .= ' '.mb_strtolower(trans('general.room'));
88
89			$view_data = [
90			'dataset' => $dataset,
91			'fields' => $this->getFields(),
92			'title' => $title,
93			'submit_route' => $submit_route,
94			'route_name' => $this->getRouteName(),
95			];
96
97			return view('addedit', $view_data);
98			}
99
100			private function getFields()
101			{
102			return [
103			[
104			'id' => 'number',
105			'title' => trans('general.number'),
106			'value' => function (Room $data) {
107			return $data->number;
108			},
109			'type' => 'number',
110			'optional' => [
111			'required' => 'required',
112			],
113			],
114			[
115			'id' => 'floor',
116			'title' => trans('general.floor'),
117			'value' => function (Room $data) {
118			return $data->floor;
119			},
120			'type' => 'number',
121			'optional' => [
122			'required' => 'required',
123			],
124			],
125			[
126			'id' => 'capacity',
127			'title' => trans('general.capacity'),
128			'value' => function (Room $data) {
129			return $data->capacity;
130			},
131			'type' => 'number',
132			'optional' => [
133			'required' => 'required',
134			],
135			],
136			[
137			'id' => 'price',
138			'title' => trans('general.price'),
139			'value' => function (Room $data) {
140			return $data->price;
141			},
142			'type' => 'number',
143			'optional' => [
144			'step' => '0.01',
145			'placeholder' => '0.00',
146			'required' => 'required',
147			],
148			],
149			[
150			'id' => 'comments',
151			'title' => trans('general.comments'),
152			'value' => function (Room $data) {
153			return $data->comments;
154			},
155			'type' => 'textarea',
156			],
157			];
158			}
159
160			private function getColumns()
161			{
162			$dataset = [
163			[
164			'title' => trans('general.number'),
165			'value' => function (Room $data) {
166			return $data->number;
167			},
168			],
169			[
170			'title' => trans('general.floor'),
171			'value' => function (Room $data) {
172			return $data->floor;
173			},
174			],
175			[
176			'title' => trans('general.capacity'),
177			'value' => function (Room $data) {
178			return $data->capacity;
179			},
180			],
181			[
182			'title' => trans('general.price'),
183			'value' => function (Room $data) {
184			return $data->price;
185			},
186			],
187			];
188
189			return $dataset;
190			}
191			}
192

Saibamen / HotelManager

Push — master ( 4e9267...ad0247 )

RoomController::getFields() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like