ReservationController::getFields() - Code Metrics - Inspection of "Add foreign keys in reversations table, WIP Reserv..." - Saibamen/HotelManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( df9caa...85af72 )

by Adam

created 2017-11-27 21:44 UTC

ReservationController::getFields() B

↳ Parent: ReservationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	78
Code Lines	47

Duplication

Lines	78
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	78
loc	78
ccs	0
cts	38
cp	0
rs	8.9019
cc	1
eloc	47
nc	1
nop	0
crap	2

How to fix Long Method

<?php

namespace App\Http\Controllers;

// TODO
use App\Http\Requests\GuestRequest;
use App\Models\Reservation;
use Illuminate\Database\Eloquent\ModelNotFoundException;

class ReservationController extends Controller
{
    private function getRouteName()
    {
        return 'reservation';
    }

    public function index()

    {
        $title = trans('general.reservations');

        $dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people')
            ->with('guest:id,first_name,last_name')
            ->with('room:id,number')
            ->paginate($this->getItemsPerPage());

        $viewData = [
            'columns'       => $this->getColumns(),
            'dataset'       => $dataset,
            'routeName'     => $this->getRouteName(),
            'title'         => $title,
            // TODO
            'deleteMessage' => mb_strtolower(trans('general.reservation')).' '.mb_strtolower(trans('general.number')),
        ];

        return view('list', $viewData);
    }

    // TODO
    public function store(GuestRequest $request, $id = null)

    {
        if ($id === null) {
            $object = new Reservation();
        } else {
            try {
                $object = Reservation::findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger',
                ]);
            }
        }

        $object->fill($request->all());
        $object->save();

        return redirect()->route($this->getRouteName().'.index')
            ->with([
                'message'     => trans('general.saved'),
                'alert-class' => 'alert-success',
            ]);
    }

    public function delete($id)

    {
        Reservation::destroy($id);
        $data = ['class' => 'alert-success', 'message' => trans('general.deleted')];

        return response()->json($data);
    }

    // TODO
    public function showAddEditForm($id = null)

    {
        if ($id === null) {
            $dataset = new Reservation();
            $title = trans('navigation.add_guest');
            $submitRoute = route($this->getRouteName().'.postadd');
        } else {
            try {
                $dataset = Reservation::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact')->findOrFail($id);
            } catch (ModelNotFoundException $e) {
                return Controller::returnBack([
                    'message'     => trans('general.object_not_found'),
                    'alert-class' => 'alert-danger',
                ]);
            }

            $title = trans('navigation.edit_guest');
            $submitRoute = route($this->getRouteName().'.postedit', $id);
        }

        $viewData = [
            'dataset'     => $dataset,
            'fields'      => $this->getFields(),
            'title'       => $title,
            'submitRoute' => $submitRoute,
            'routeName'   => $this->getRouteName(),
        ];

        return view('addedit', $viewData);
    }

    // TODO
    private function getFields()

    {
        return [
            [
                'id'    => 'first_name',
                'title' => trans('general.first_name'),
                'value' => function (Reservation $data) {
                    return $data->first_name;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'last_name',
                'title' => trans('general.last_name'),
                'value' => function (Reservation $data) {
                    return $data->last_name;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'address',
                'title' => trans('general.address'),
                'value' => function (Reservation $data) {
                    return $data->address;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'zip_code',
                'title' => trans('general.zip_code'),
                'value' => function (Reservation $data) {
                    return $data->zip_code;
                },
                'optional' => [
                    'required'    => 'required',
                    'placeholder' => '00-000',
                ],
            ],
            [
                'id'    => 'place',
                'title' => trans('general.place'),
                'value' => function (Reservation $data) {
                    return $data->place;
                },
                'optional' => [
                    'required' => 'required',
                ],
            ],
            [
                'id'    => 'PESEL',
                'title' => trans('general.PESEL'),
                'value' => function (Reservation $data) {
                    return $data->PESEL;
                },
                'optional' => [
                    'required'    => 'required',
                    'placeholder' => '12345654321',
                ],
            ],
            [
                'id'    => 'contact',
                'title' => trans('general.contact'),
                'value' => function (Reservation $data) {
                    return $data->contact;
                },
                'type'     => 'textarea',
                'optional' => [
                    'placeholder' => trans('general.contact_placeholder'),
                ],
            ],
        ];
    }

    // TODO
    private function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.room'),
                'value' => function (Reservation $data) {
                    return $data->room->number;
                },
            ],
            [
                'title' => trans('general.guest'),
                'value' => function (Reservation $data) {
                    return $data->guest->first_name.' '.$data->guest->last_name;
                },
            ],
            [
                'title' => trans('general.date_start'),
                'value' => function (Reservation $data) {
                    return $data->date_start;
                },
            ],
            [
                'title' => trans('general.date_end'),
                'value' => function (Reservation $data) {
                    return $data->date_end;
                },
            ],
            [
                'title' => trans('general.people'),
                'value' => function (Reservation $data) {
                    return $data->people;
                },
            ],
        ];

        return $dataset;
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		// TODO
6		use App\Http\Requests\GuestRequest;
7		use App\Models\Reservation;
8		use Illuminate\Database\Eloquent\ModelNotFoundException;
9
10		class ReservationController extends Controller
11		{
12		private function getRouteName()
13		{
14		return 'reservation';
15		}
16
17	View Code Duplication	public function index()
		0 ignored issues – show Duplication introduced 2017-11-27 21:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		$title = trans('general.reservations');
20
21		$dataset = Reservation::select('id', 'room_id', 'guest_id', 'date_start', 'date_end', 'people')
22		->with('guest:id,first_name,last_name')
23		->with('room:id,number')
24		->paginate($this->getItemsPerPage());
25
26		$viewData = [
27		'columns' => $this->getColumns(),
28		'dataset' => $dataset,
29		'routeName' => $this->getRouteName(),
30		'title' => $title,
31		// TODO
32		'deleteMessage' => mb_strtolower(trans('general.reservation')).' '.mb_strtolower(trans('general.number')),
33		];
34
35		return view('list', $viewData);
36		}
37
38		// TODO
39	View Code Duplication	public function store(GuestRequest $request, $id = null)
		0 ignored issues – show Duplication introduced 2017-11-27 21:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		if ($id === null) {
42		$object = new Reservation();
43		} else {
44		try {
45		$object = Reservation::findOrFail($id);
46		} catch (ModelNotFoundException $e) {
47		return Controller::returnBack([
48		'message' => trans('general.object_not_found'),
49		'alert-class' => 'alert-danger',
50		]);
51		}
52		}
53
54		$object->fill($request->all());
55		$object->save();
56
57		return redirect()->route($this->getRouteName().'.index')
58		->with([
59		'message' => trans('general.saved'),
60		'alert-class' => 'alert-success',
61		]);
62		}
63
64	View Code Duplication	public function delete($id)
		0 ignored issues – show Duplication introduced 2017-11-27 21:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		Reservation::destroy($id);
67		$data = ['class' => 'alert-success', 'message' => trans('general.deleted')];
68
69		return response()->json($data);
70		}
71
72		// TODO
73	View Code Duplication	public function showAddEditForm($id = null)
		0 ignored issues – show Duplication introduced 2017-11-27 21:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		if ($id === null) {
76		$dataset = new Reservation();
77		$title = trans('navigation.add_guest');
78		$submitRoute = route($this->getRouteName().'.postadd');
79		} else {
80		try {
81		$dataset = Reservation::select('id', 'first_name', 'last_name', 'address', 'zip_code', 'place', 'PESEL', 'contact')->findOrFail($id);
82		} catch (ModelNotFoundException $e) {
83		return Controller::returnBack([
84		'message' => trans('general.object_not_found'),
85		'alert-class' => 'alert-danger',
86		]);
87		}
88
89		$title = trans('navigation.edit_guest');
90		$submitRoute = route($this->getRouteName().'.postedit', $id);
91		}
92
93		$viewData = [
94		'dataset' => $dataset,
95		'fields' => $this->getFields(),
96		'title' => $title,
97		'submitRoute' => $submitRoute,
98		'routeName' => $this->getRouteName(),
99		];
100
101		return view('addedit', $viewData);
102		}
103
104		// TODO
105	View Code Duplication	private function getFields()
		0 ignored issues – show Duplication introduced 2017-11-27 21:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		return [
108		[
109		'id' => 'first_name',
110		'title' => trans('general.first_name'),
111		'value' => function (Reservation $data) {
112		return $data->first_name;
113		},
114		'optional' => [
115		'required' => 'required',
116		],
117		],
118		[
119		'id' => 'last_name',
120		'title' => trans('general.last_name'),
121		'value' => function (Reservation $data) {
122		return $data->last_name;
123		},
124		'optional' => [
125		'required' => 'required',
126		],
127		],
128		[
129		'id' => 'address',
130		'title' => trans('general.address'),
131		'value' => function (Reservation $data) {
132		return $data->address;
133		},
134		'optional' => [
135		'required' => 'required',
136		],
137		],
138		[
139		'id' => 'zip_code',
140		'title' => trans('general.zip_code'),
141		'value' => function (Reservation $data) {
142		return $data->zip_code;
143		},
144		'optional' => [
145		'required' => 'required',
146		'placeholder' => '00-000',
147		],
148		],
149		[
150		'id' => 'place',
151		'title' => trans('general.place'),
152		'value' => function (Reservation $data) {
153		return $data->place;
154		},
155		'optional' => [
156		'required' => 'required',
157		],
158		],
159		[
160		'id' => 'PESEL',
161		'title' => trans('general.PESEL'),
162		'value' => function (Reservation $data) {
163		return $data->PESEL;
164		},
165		'optional' => [
166		'required' => 'required',
167		'placeholder' => '12345654321',
168		],
169		],
170		[
171		'id' => 'contact',
172		'title' => trans('general.contact'),
173		'value' => function (Reservation $data) {
174		return $data->contact;
175		},
176		'type' => 'textarea',
177		'optional' => [
178		'placeholder' => trans('general.contact_placeholder'),
179		],
180		],
181		];
182		}
183
184		// TODO
185		private function getColumns()
186		{
187		$dataset = [
188		[
189		'title' => trans('general.room'),
190		'value' => function (Reservation $data) {
191		return $data->room->number;
192		},
193		],
194		[
195		'title' => trans('general.guest'),
196		'value' => function (Reservation $data) {
197		return $data->guest->first_name.' '.$data->guest->last_name;
198		},
199		],
200		[
201		'title' => trans('general.date_start'),
202		'value' => function (Reservation $data) {
203		return $data->date_start;
204		},
205		],
206		[
207		'title' => trans('general.date_end'),
208		'value' => function (Reservation $data) {
209		return $data->date_end;
210		},
211		],
212		[
213		'title' => trans('general.people'),
214		'value' => function (Reservation $data) {
215		return $data->people;
216		},
217		],
218		];
219
220		return $dataset;
221		}
222		}
223

Saibamen / HotelManager

Push — master ( df9caa...85af72 )

ReservationController::getFields() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like