Includes\Generate::generateAndSaveRandomNumbers()

Complexity

Conditions	9
Paths	16

Size

Total Lines	77
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public static function generateAndSaveRandomNumbers($min, $max, $decimalPlaces, $maxFileSize, $filename, $fileExtension = '.dat', $delimiter = ' ')
    {
        $range = $max - $min;

        $minMaxNumberSize = self::getMinMaxNumberSize($min, $max, $decimalPlaces);

        if ($minMaxNumberSize['max'] > $maxFileSize) {
            die('Error: Cannot generate any number due to too low file size.');

Using exit here is not recommended.

        }

        File::createMissingDirectory($filename);
        File::checkIfFileExistsAndDeleteContent($filename, $fileExtension);

        // Maximum iteration without delimiter
        $maxIteration = (int) ($maxFileSize / $minMaxNumberSize['max']);
        Text::debug('First maximum iteration: '.$maxIteration);

        $findingStart = microtime(true);
        Text::message('Finding maximum iteration for loop...');

        for ($i = 0; ; $i++) {
            $tempMaxIteration = $maxIteration - $i;
            $maximumBytes = ($minMaxNumberSize['max'] * $tempMaxIteration) + $tempMaxIteration - strlen($delimiter);

            if ($maxFileSize >= $maximumBytes) {
                $maxIteration = $tempMaxIteration;
                unset($tempMaxIteration);
                break;
            }
        }

        Text::printTimeDuration($findingStart);
        unset($findingStart);

        Text::message('GENERATING...');
        Text::debug('Min: '.$min.' Max: '.$max.' Decimal places: '.$decimalPlaces.' Size: '.$maxFileSize."\nMaximum iteration: ".$maxIteration."\n");

        $generateStart = microtime(true);

        $file = fopen($filename.$fileExtension, 'w');
        $chunkSize = 20;
        $maxMainIteration = ceil((int) ($maxIteration / $chunkSize));
        $outputString = null;
        $progress = 1;

        for ($i = 0; $i <= $maxMainIteration; $i++) {
            for ($j = 1; $j <= $chunkSize; $j++, $progress++) {
                if ($progress > $maxIteration) {
                    break;
                }

                if (!self::getTesting()) {
                    // Print progress and move cursor back to position 0
                    echo 'Progress: '.$progress.'/'.$maxIteration."\r";
                }

                // Random number
                $number = $min + $range * (mt_rand() / mt_getrandmax());
                // Format with trailing zeros ie. 8.00
                $number = number_format((float) $number, (int) $decimalPlaces, '.', '');

                $outputString .= $number.$delimiter;
            }

            // Remove last delimiter
            if ($progress > $maxIteration) {
                $outputString = rtrim($outputString, $delimiter);

It seems like $outputString can also be of type null; however, parameter $string of rtrim() does only seem to accept string, maybe add an additional type check?

            }

            fwrite($file, $outputString);

It seems like $outputString can also be of type null; however, parameter $data of fwrite() does only seem to accept string, maybe add an additional type check?

            $outputString = null;
        }

        fclose($file);

        Text::printTimeDuration($generateStart);
        Text::message('Output file '.$filename.$fileExtension.' generated with '.filesize($filename.$fileExtension).' bytes.');
    }