Test Failed
Pull Request — master (#16)
by
unknown
11:20
created
GitControlBundle/Controller/Issues/IssueMilestoneController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         if ($form->isValid()) {
84 84
             $issueMilestone = $this->issueMilestoneRepository->createMilestone($issueMilestone);
85 85
 
86
-            $this->get('session')->getFlashBag()->add('notice', 'New Milestone:'.$issueMilestone->getTitle());
86
+            $this->get('session')->getFlashBag()->add('notice', 'New Milestone:' . $issueMilestone->getTitle());
87 87
 
88 88
             return $this->redirect($this->generateUrl('issuemilestone_show', array('milestoneId' => $issueMilestone->getId())));
89 89
         }
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
         if ($editForm->isValid()) {
233 233
             $this->issueMilestoneRepository->updateMilestone($issueMilestone);
234
-            $this->get('session')->getFlashBag()->add('notice', 'Updated Milestone:'.$issueMilestone->getTitle());
234
+            $this->get('session')->getFlashBag()->add('notice', 'Updated Milestone:' . $issueMilestone->getTitle());
235 235
 
236 236
             return $this->redirect($this->generateUrl('issuemilestone_show', array('id' => $id, 'milestoneId' => $milestoneId)));
237 237
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         if ($form->isValid()) {
258 258
             $this->issueMilestoneRepository->deleteMilestone($milestoneId);
259 259
 
260
-            $this->get('session')->getFlashBag()->add('notice', 'Deleted Milestone:'.$milestoneId);
260
+            $this->get('session')->getFlashBag()->add('notice', 'Deleted Milestone:' . $milestoneId);
261 261
         }
262 262
 
263 263
         return $this->redirect($this->generateUrl('issuemilestones', array('id' => $id)));
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
             throw $this->createNotFoundException('Unable to find Issue Milestone entity.');
296 296
         }
297 297
 
298
-        $this->get('session')->getFlashBag()->add('notice', 'Milestone #'.$issueMilestone->getId().' has been closed');
298
+        $this->get('session')->getFlashBag()->add('notice', 'Milestone #' . $issueMilestone->getId() . ' has been closed');
299 299
 
300 300
         return $this->redirect($this->generateUrl('issuemilestones', array('project' => $issueMilestone->getProject()->getId())));
301 301
     }
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
             throw $this->createNotFoundException('Unable to find Issue Milestone entity.');
316 316
         }
317 317
 
318
-        $this->get('session')->getFlashBag()->add('notice', 'Milestone #'.$issueMilestone->getId().' has been opened');
318
+        $this->get('session')->getFlashBag()->add('notice', 'Milestone #' . $issueMilestone->getId() . ' has been opened');
319 319
 
320 320
         return $this->redirect($this->generateUrl('issuemilestone_show', array('id' => $this->project->getId(), 'milestoneId' => $issueMilestone->getId())));
321 321
     }
Please login to merge, or discard this patch.
app/src/VersionControl/GitControlBundle/Controller/ProjectTagController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     {
45 45
         $tags = $this->gitCommands->command('tag')->getTags();
46 46
 
47
-        $defaultData =array();
47
+        $defaultData = array();
48 48
         $form = $this->createNewTagForm($this->project, $defaultData);
49 49
 
50 50
         return array_merge($this->viewVariables, array(
@@ -108,12 +108,12 @@  discard block
 block discarded – undo
108 108
                 ->add('name', TextType::class, array(
109 109
                     'label' => 'Tag Name', 'required' => true, 'constraints' => array(
110 110
                         new NotBlank(),
111
-                    ), )
111
+                    ),)
112 112
                 )
113 113
                 ->add('message', TextType::class, array(
114 114
                     'label' => 'Tag Message', 'required' => true, 'constraints' => array(
115 115
                         new NotBlank(),
116
-                    ), )
116
+                    ),)
117 117
                 )
118 118
                 ->add('commit', HiddenType::class)
119 119
                 ->getForm();
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     public function pushTagAction(Request $request, $tag, $responseType)
136 136
     {
137 137
         $success = true;
138
-        $form = $this->createPushTagForm($this->project,$tag);
138
+        $form = $this->createPushTagForm($this->project, $tag);
139 139
         $form->add('push', SubmitType::class, array('label' => 'Push'));
140 140
         
141 141
         $form->handleRequest($request);
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         $gitRemoteVersions = $this->gitCommands->command('sync')->getRemoteVersions();
191 191
         $remoteChoices = array();
192 192
         foreach ($gitRemoteVersions as $remoteVersion) {
193
-            $remoteChoices[$remoteVersion[0].'('.$remoteVersion[1].')'] = $remoteVersion[0];
193
+            $remoteChoices[$remoteVersion[0] . '(' . $remoteVersion[1] . ')'] = $remoteVersion[0];
194 194
         }
195 195
 
196 196
         $firstOrigin = reset($remoteChoices);
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
             ->add('remote', ChoiceType::class, array(
205 205
                 'label' => 'Remote Server', 'choices' => $remoteChoices, 'data' => $firstOrigin, 'required' => false, 'choices_as_values' => true, 'constraints' => array(
206 206
                     new NotBlank(),
207
-                ), )
207
+                ),)
208 208
             )
209 209
             ->add('tag', HiddenType::class)
210 210
             ->getForm();
Please login to merge, or discard this patch.
src/VersionControl/GitControlBundle/Controller/ProjectSyncController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
         $gitRemoteVersions = $this->gitSyncCommands->getRemoteVersions();
197 197
         $remoteChoices = array();
198 198
         foreach ($gitRemoteVersions as $remoteVersion) {
199
-            $remoteChoices[$remoteVersion[0].'('.$remoteVersion[1].')'] = $remoteVersion[0];
199
+            $remoteChoices[$remoteVersion[0] . '(' . $remoteVersion[1] . ')'] = $remoteVersion[0];
200 200
         }
201 201
 
202 202
         //Local Branch choice
@@ -219,12 +219,12 @@  discard block
 block discarded – undo
219 219
             ->add('remote', ChoiceType::class, array(
220 220
                 'label' => 'Remote Server', 'choices' => $remoteChoices, 'data' => $firstOrigin, 'required' => false, 'choices_as_values' => true, 'constraints' => array(
221 221
                     new NotBlank(),
222
-                ), )
222
+                ),)
223 223
             )
224 224
             ->add('branch', ChoiceType::class, array(
225 225
                 'label' => 'Branch', 'choices' => $branchChoices, 'preferred_choices' => array($currentBranch), 'data' => trim($currentBranch), 'required' => false, 'choices_as_values' => true, 'constraints' => array(
226 226
                     new NotBlank(),
227
-                ), )
227
+                ),)
228 228
             )
229 229
             ->getForm();
230 230
 
Please login to merge, or discard this patch.
src/VersionControl/GitControlBundle/Utility/ProjectEnvironmentStorage.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public function setProjectEnvironment($projectId, $projectEnvironmentId)
55 55
     {
56
-        $this->session->set('projectEnvironment'.$projectId, $projectEnvironmentId);
56
+        $this->session->set('projectEnvironment' . $projectId, $projectEnvironmentId);
57 57
     }
58 58
 
59 59
     /**
@@ -65,8 +65,8 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getProjectEnviromment(Project $project)
67 67
     {
68
-        if ($this->session->has('projectEnvironment'.$project->getId())) {
69
-            $projectEnvironmentId = $this->session->get('projectEnvironment'.$project->getId());
68
+        if ($this->session->has('projectEnvironment' . $project->getId())) {
69
+            $projectEnvironmentId = $this->session->get('projectEnvironment' . $project->getId());
70 70
 
71 71
             $currentProjectEnvironment = $this->em->getRepository('VersionControlGitControlBundle:ProjectEnvironment')->find($projectEnvironmentId);
72 72
             if ($currentProjectEnvironment->getProject()->getId() === $project->getId()) {
Please login to merge, or discard this patch.
GitControlBundle/Security/Authentication/FOSVersionUserProvider.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
         $username = $response->getUsername();
26 26
         //on connect - get the access token and the user ID
27 27
         $service = $response->getResourceOwner()->getName();
28
-        $setter = 'set'.ucfirst($service);
29
-        $setter_id = $setter.'Id';
30
-        $setter_token = $setter.'AccessToken';
28
+        $setter = 'set' . ucfirst($service);
29
+        $setter_id = $setter . 'Id';
30
+        $setter_token = $setter . 'AccessToken';
31 31
 
32 32
         //we "disconnect" previously connected users
33 33
         if (null !== $previousUser = $this->userManager->findUserBy(array($property => $username))) {
@@ -51,9 +51,9 @@  discard block
 block discarded – undo
51 51
         //when the user is registrating
52 52
         if (null === $user) {
53 53
             $service = $response->getResourceOwner()->getName();
54
-            $setter = 'set'.ucfirst($service);
55
-            $setter_id = $setter.'Id';
56
-            $setter_token = $setter.'AccessToken';
54
+            $setter = 'set' . ucfirst($service);
55
+            $setter_id = $setter . 'Id';
56
+            $setter_token = $setter . 'AccessToken';
57 57
             // create new user here
58 58
             $user = $this->userManager->createUser();
59 59
             $user->$setter_id($username);
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
         //update access token
76 76
         $serviceName = $response->getResourceOwner()->getName();
77
-        $setter = 'set'.ucfirst($serviceName).'AccessToken';
77
+        $setter = 'set' . ucfirst($serviceName) . 'AccessToken';
78 78
         $user->$setter($response->getAccessToken());
79 79
 
80 80
         return $user;
Please login to merge, or discard this patch.
VersionControl/GitControlBundle/Tests/Controller/IssueControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,14 +18,14 @@
 block discarded – undo
18 18
              'HTTP_X-Requested-With' => 'XMLHttpRequest',
19 19
         ));
20 20
         //$crawler = $this->client->followRedirect();
21
-        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET '.$url);
21
+        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET ' . $url);
22 22
 
23 23
         $newIssueLink = $crawler->filter('.box-tools > form > .pull-right > a')->link();
24 24
         $crawler = $this->client->request($newIssueLink->getMethod(), $newIssueLink->getUri(), array(), array(), array(
25 25
              'HTTP_X-Requested-With' => 'XMLHttpRequest',
26 26
         ));
27 27
 
28
-        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET '.$url);
28
+        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET ' . $url);
29 29
 
30 30
         // Fill in the form and submit it
31 31
         $form = $crawler->selectButton('Create')->form(array(
Please login to merge, or discard this patch.
VersionControl/GitControlBundle/Tests/Controller/BaseControllerTestCase.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         $loginManager->loginUser($firewallName, $user);
40 40
 
41 41
         // save the login token into the session and put it in a cookie
42
-        $container->get('session')->set('_security_'.$firewallName,
42
+        $container->get('session')->set('_security_' . $firewallName,
43 43
             serialize($container->get('security.context')->getToken()));
44 44
         $container->get('session')->save();
45 45
         $this->client->getCookieJar()->set(new Cookie($session->getName(), $session->getId()));
@@ -84,24 +84,24 @@  discard block
 block discarded – undo
84 84
 
85 85
     protected function assertInputValue($crawler, $key, $val)
86 86
     {
87
-        $input = $crawler->filter('input[name="'.$key.'"]');
87
+        $input = $crawler->filter('input[name="' . $key . '"]');
88 88
         $this->assertEquals(
89
-            $val, $input->attr('value'), $key.' failed'
89
+            $val, $input->attr('value'), $key . ' failed'
90 90
         );
91 91
     }
92 92
 
93 93
     protected function assertSelectValue($crawler, $key, $val)
94 94
     {
95
-        $input = $crawler->filter('select[name="'.$key.'"]');
95
+        $input = $crawler->filter('select[name="' . $key . '"]');
96 96
         $selected_option = $input->filter('option[selected="selected"]');
97
-        $this->assertEquals($val, $selected_option->attr('value'), $key.' failed');
97
+        $this->assertEquals($val, $selected_option->attr('value'), $key . ' failed');
98 98
     }
99 99
 
100 100
     protected function assertTextAreaValue($crawler, $key, $val)
101 101
     {
102
-        $input = $crawler->filter('textarea[name="'.$key.'"]');
102
+        $input = $crawler->filter('textarea[name="' . $key . '"]');
103 103
         $this->assertEquals(
104
-            $val, $input->text(), $key.' failed'
104
+            $val, $input->text(), $key . ' failed'
105 105
         );
106 106
     }
107 107
 
Please login to merge, or discard this patch.
VersionControl/GitControlBundle/Tests/Controller/ProjectControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
         // Create a new entry in the database
16 16
         $crawler = $this->client->request('GET', $projectCreateURL);
17
-        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET '.$projectCreateURL);
17
+        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET ' . $projectCreateURL);
18 18
 
19 19
         // Fill in the form and submit it
20 20
         $form = $crawler->selectButton('Create')->form(array(
Please login to merge, or discard this patch.
GitControlBundle/Tests/Controller/IssueMilestoneControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
         $crawler = $this->client->request('GET', $listMilestoneURL, array(), array(), array(
17 17
              'HTTP_X-Requested-With' => 'XMLHttpRequest',
18 18
         ));
19
-        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET '.$listMilestoneURL);
19
+        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET ' . $listMilestoneURL);
20 20
 
21 21
         //Click New Issue Milestone Link
22 22
         $newIssueMilestoneLink = $crawler->filter('a:contains("New Milestone")')->link();
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
              'HTTP_X-Requested-With' => 'XMLHttpRequest',
25 25
         ));
26 26
 
27
-        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET '.$newIssueMilestoneLink->getUri());
27
+        $this->assertEquals(200, $this->client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET ' . $newIssueMilestoneLink->getUri());
28 28
 
29 29
         // Fill in the new issue milestone form and submit it
30 30
         $form = $crawler->selectButton('Create')->form(array(
Please login to merge, or discard this patch.