Inspection of "[Support-php7.2] Fix tests" - SSHVersionControl/git-web-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 051175...ba50f0 )

by Paul

created 2020-04-05 11:48 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -66,8 +66,8 @@
 block discarded – undo
                     },*/
                 ))
             //->add('project', 'hidden_entity',array(
-             //       'class' => 'VersionControl\GitControlBundle\Entity\Project'
-             //   ))
+                //       'class' => 'VersionControl\GitControlBundle\Entity\Project'
+                //   ))
             //->add('verUser')
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),

Please login to merge, or discard this patch.

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -37,20 +37,20 @@  discard block
 block discarded – undo
             ->add('description', TextareaType::class)
             ->add('issueMilestone', 'choice', array(
                     'choices' => $this->getIssueMilestoneChoices(),
-                    'multiple' => false,   // Multiple selection allowed
+                    'multiple' => false, // Multiple selection allowed
                     //'expanded' => true,   // Render as checkboxes
                     'placeholder' => 'Choose a milestone',
                     'required' => false,
                     'choices_as_values' => true,
                     //'property' => 'title', // Assuming that the entity has a "name" property
-                    'choice_label' => function ($issueMilestone) {
+                    'choice_label' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueMilestone) {
+                    'choice_value' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getId();
                         }
@@ -71,20 +71,20 @@  discard block
 block discarded – undo
             //->add('verUser')
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),
-                    'multiple' => true,   // Multiple selection allowed
-                    'expanded' => true,   // Render as checkboxes
+                    'multiple' => true, // Multiple selection allowed
+                    'expanded' => true, // Render as checkboxes
                     //'property' => 'title', // Assuming that the entity has a "name" property
                     //'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
                     'required' => false,
                     'choices_as_values' => true,
-                    'choice_label' => function ($issueLabel) {
+                    'choice_label' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueLabel) {
+                    'choice_value' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getId();
                         }

Please login to merge, or discard this patch.

app/src/VersionControl/GithubIssueBundle/Form/IssueEditType.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -38,20 +38,20 @@  discard block
 block discarded – undo
                     )
             ->add('issueMilestone', ChoiceType::class, array(
                     'choices' => $this->getIssueMilestoneChoices(),
-                    'multiple' => false,   // Multiple selection allowed
+                    'multiple' => false, // Multiple selection allowed
                     //'expanded' => true,   // Render as checkboxes
                     'placeholder' => 'Choose a milestone',
                     'required' => false,
                     'choices_as_values' => true,
                     //'property' => 'title', // Assuming that the entity has a "name" property
-                    'choice_label' => function ($issueMilestone) {
+                    'choice_label' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueMilestone) {
+                    'choice_value' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getId();
                         }
@@ -68,20 +68,20 @@  discard block
 block discarded – undo
                 ))
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),
-                    'multiple' => true,   // Multiple selection allowed
-                    'expanded' => true,   // Render as checkboxes
+                    'multiple' => true, // Multiple selection allowed
+                    'expanded' => true, // Render as checkboxes
                     //'property' => 'title', // Assuming that the entity has a "name" property
                     //'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
                     'required' => false,
                     'choices_as_values' => true,
-                    'choice_label' => function ($issueLabel) {
+                    'choice_label' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueLabel) {
+                    'choice_value' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getId();
                         }

Please login to merge, or discard this patch.

DependencyInjection/VersionControlGithubIssueExtension.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@
 block discarded – undo
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
     }
 }

Please login to merge, or discard this patch.

src/VersionControl/GitlabIssueBundle/Repository/IssueLabelRepository.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -65,7 +65,7 @@  discard block
 block discarded – undo
         $this->authenticate();
         $label = $this->client->api('projects')->addLabel($this->issueIntegrator->getProjectName(), array(
             'name' => $issueLabel->getTitle(),
-            'color' => '#'.$issueLabel->getHexColor(),
+            'color' => '#' . $issueLabel->getHexColor(),
         ));
 
         return $this->mapToEntity($label);
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
         $label = $this->client->api('projects')->updateLabel($this->issueIntegrator->getProjectName(), array(
             'name' => $issueLabel->getId(),
             'new_name' => $issueLabel->getTitle(),
-            'color' => '#'.$issueLabel->getHexColor(),
+            'color' => '#' . $issueLabel->getHexColor(),
         ));
 
         return $this->mapToEntity($label);

Please login to merge, or discard this patch.

app/src/VersionControl/GitlabIssueBundle/Form/IssueType.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -66,8 +66,8 @@
 block discarded – undo
                     },*/
                 ))
             //->add('project', 'hidden_entity',array(
-             //       'class' => 'VersionControl\GitControlBundle\Entity\Project'
-             //   ))
+                //       'class' => 'VersionControl\GitControlBundle\Entity\Project'
+                //   ))
             //->add('verUser')
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),

Please login to merge, or discard this patch.

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -37,20 +37,20 @@  discard block
 block discarded – undo
             ->add('description', TextareaType::class)
             ->add('issueMilestone', ChoiceType::class, array(
                     'choices' => $this->getIssueMilestoneChoices(),
-                    'multiple' => false,   // Multiple selection allowed
+                    'multiple' => false, // Multiple selection allowed
                     //'expanded' => true,   // Render as checkboxes
                     'placeholder' => 'Choose a milestone',
                     'required' => false,
                     'choices_as_values' => true,
                     //'property' => 'title', // Assuming that the entity has a "name" property
-                    'choice_label' => function ($issueMilestone) {
+                    'choice_label' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueMilestone) {
+                    'choice_value' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getId();
                         }
@@ -71,20 +71,20 @@  discard block
 block discarded – undo
             //->add('verUser')
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),
-                    'multiple' => true,   // Multiple selection allowed
-                    'expanded' => true,   // Render as checkboxes
+                    'multiple' => true, // Multiple selection allowed
+                    'expanded' => true, // Render as checkboxes
                     //'property' => 'title', // Assuming that the entity has a "name" property
                     //'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
                     'required' => false,
                     'choices_as_values' => true,
-                    'choice_label' => function ($issueLabel) {
+                    'choice_label' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueLabel) {
+                    'choice_value' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getId();
                         }

Please login to merge, or discard this patch.

GitlabIssueBundle/Form/EventListener/AddProjectNameFieldSubscriber.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -33,18 +33,18 @@  discard block
 block discarded – undo
         if ($projectIssueIntegratorGitlab && $projectIssueIntegratorGitlab instanceof \VersionControl\GitlabIssueBundle\Entity\ProjectIssueIntegratorGitlab) {
             $form->add('projectName', GitlabProjectType::class, array(
                     'choices' => $this->getProjectChoices($projectIssueIntegratorGitlab),
-                    'multiple' => false,   // Multiple selection allowed
+                    'multiple' => false, // Multiple selection allowed
                     'placeholder' => 'Choose a projecton Gitlab',
                     'required' => false,
                     'choices_as_values' => true,
-                    'choice_label' => function ($gitLabProject) {
+                    'choice_label' => function($gitLabProject) {
                         if ($gitLabProject) {
                             return $gitLabProject->getName();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($gitLabProject) {
+                    'choice_value' => function($gitLabProject) {
                         if ($gitLabProject) {
                             return $gitLabProject->getId();
                         }
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
 
     protected function getProjectChoices(\VersionControl\GitlabIssueBundle\Entity\ProjectIssueIntegratorGitlab $projectIssueIntegrator)
     {
-        $client = new \Gitlab\Client(rtrim($projectIssueIntegrator->getUrl(), '/').'/api/v3/'); // change here
+        $client = new \Gitlab\Client(rtrim($projectIssueIntegrator->getUrl(), '/') . '/api/v3/'); // change here
         $client->authenticate($projectIssueIntegrator->getApiToken(), \Gitlab\Client::AUTH_URL_TOKEN);
         $choices = array();
         $dataResponse = $client->api('projects')->all(1, 200);

Please login to merge, or discard this patch.

app/src/VersionControl/GitlabIssueBundle/Form/IssueEditType.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -38,20 +38,20 @@  discard block
 block discarded – undo
                     )
             ->add('issueMilestone', ChoiceType::class, array(
                     'choices' => $this->getIssueMilestoneChoices(),
-                    'multiple' => false,   // Multiple selection allowed
+                    'multiple' => false, // Multiple selection allowed
                     //'expanded' => true,   // Render as checkboxes
                     'placeholder' => 'Choose a milestone',
                     'required' => false,
                     'choices_as_values' => true,
                     //'property' => 'title', // Assuming that the entity has a "name" property
-                    'choice_label' => function ($issueMilestone) {
+                    'choice_label' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueMilestone) {
+                    'choice_value' => function($issueMilestone) {
                         if ($issueMilestone) {
                             return $issueMilestone->getId();
                         }
@@ -68,20 +68,20 @@  discard block
 block discarded – undo
                 ))
             ->add('issueLabel', ChoiceType::class, array(
                     'choices' => $this->getIssueLabelChoices(),
-                    'multiple' => true,   // Multiple selection allowed
-                    'expanded' => true,   // Render as checkboxes
+                    'multiple' => true, // Multiple selection allowed
+                    'expanded' => true, // Render as checkboxes
                     //'property' => 'title', // Assuming that the entity has a "name" property
                     //'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
                     'required' => false,
                     'choices_as_values' => true,
-                    'choice_label' => function ($issueLabel) {
+                    'choice_label' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getTitle();
                         }
 
                         return;
                     },
-                    'choice_value' => function ($issueLabel) {
+                    'choice_value' => function($issueLabel) {
                         if ($issueLabel) {
                             return $issueLabel->getId();
                         }

Please login to merge, or discard this patch.

app/src/VersionControl/GitCommandBundle/Logger/GitCommandLogger.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@
 block discarded – undo
 
         if (null !== $this->logger) {
             $message = sprintf('%s (%s) %0.2f ms', $command, $method, $time * 1000);
-            $this->logger->info($message, (array)$data);
+            $this->logger->info($message, (array) $data);
         }
     }
 

Please login to merge, or discard this patch.

src/VersionControl/GitCommandBundle/GitCommands/Command/GitFilesCommand.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -148,7 +148,7 @@
 block discarded – undo
      */
     protected function sortFilesByDirectoryThenName(array &$fileArray): void
     {
-        usort($fileArray, static function (FileInfoInterface $a, FileInfoInterface $b) {
+        usort($fileArray, static function(FileInfoInterface $a, FileInfoInterface $b) {
             if ($a->isDir()) {
                 if ($b->isDir()) {
                     return strnatcasecmp($a->getFilename(), $b->getFilename());

Please login to merge, or discard this patch.

		@@ -148,7 +148,7 @@
		block discarded – undo
148	148	*/
149	149	protected function sortFilesByDirectoryThenName(array &$fileArray): void
150	150	{
151		- usort($fileArray, static function (FileInfoInterface $a, FileInfoInterface $b) {
	151	+ usort($fileArray, static function(FileInfoInterface $a, FileInfoInterface $b) {
152	152	if ($a->isDir()) {
153	153	if ($b->isDir()) {
154	154	return strnatcasecmp($a->getFilename(), $b->getFilename());

		@@ -66,8 +66,8 @@
		block discarded – undo
66	66	},*/
67	67	))
68	68	//->add('project', 'hidden_entity',array(
69		- // 'class' => 'VersionControl\GitControlBundle\Entity\Project'
70		- // ))
	69	+ // 'class' => 'VersionControl\GitControlBundle\Entity\Project'
	70	+ // ))
71	71	//->add('verUser')
72	72	->add('issueLabel', ChoiceType::class, array(
73	73	'choices' => $this->getIssueLabelChoices(),

		@@ -37,20 +37,20 @@ discard block
		block discarded – undo
37	37	->add('description', TextareaType::class)
38	38	->add('issueMilestone', 'choice', array(
39	39	'choices' => $this->getIssueMilestoneChoices(),
40		- 'multiple' => false, // Multiple selection allowed
	40	+ 'multiple' => false, // Multiple selection allowed
41	41	//'expanded' => true, // Render as checkboxes
42	42	'placeholder' => 'Choose a milestone',
43	43	'required' => false,
44	44	'choices_as_values' => true,
45	45	//'property' => 'title', // Assuming that the entity has a "name" property
46		- 'choice_label' => function ($issueMilestone) {
	46	+ 'choice_label' => function($issueMilestone) {
47	47	if ($issueMilestone) {
48	48	return $issueMilestone->getTitle();
49	49	}
50	50
51	51	return;
52	52	},
53		- 'choice_value' => function ($issueMilestone) {
	53	+ 'choice_value' => function($issueMilestone) {
54	54	if ($issueMilestone) {
55	55	return $issueMilestone->getId();
56	56	}
		@@ -71,20 +71,20 @@ discard block
		block discarded – undo
71	71	//->add('verUser')
72	72	->add('issueLabel', ChoiceType::class, array(
73	73	'choices' => $this->getIssueLabelChoices(),
74		- 'multiple' => true, // Multiple selection allowed
75		- 'expanded' => true, // Render as checkboxes
	74	+ 'multiple' => true, // Multiple selection allowed
	75	+ 'expanded' => true, // Render as checkboxes
76	76	//'property' => 'title', // Assuming that the entity has a "name" property
77	77	//'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
78	78	'required' => false,
79	79	'choices_as_values' => true,
80		- 'choice_label' => function ($issueLabel) {
	80	+ 'choice_label' => function($issueLabel) {
81	81	if ($issueLabel) {
82	82	return $issueLabel->getTitle();
83	83	}
84	84
85	85	return;
86	86	},
87		- 'choice_value' => function ($issueLabel) {
	87	+ 'choice_value' => function($issueLabel) {
88	88	if ($issueLabel) {
89	89	return $issueLabel->getId();
90	90	}

		@@ -38,20 +38,20 @@ discard block
		block discarded – undo
38	38	)
39	39	->add('issueMilestone', ChoiceType::class, array(
40	40	'choices' => $this->getIssueMilestoneChoices(),
41		- 'multiple' => false, // Multiple selection allowed
	41	+ 'multiple' => false, // Multiple selection allowed
42	42	//'expanded' => true, // Render as checkboxes
43	43	'placeholder' => 'Choose a milestone',
44	44	'required' => false,
45	45	'choices_as_values' => true,
46	46	//'property' => 'title', // Assuming that the entity has a "name" property
47		- 'choice_label' => function ($issueMilestone) {
	47	+ 'choice_label' => function($issueMilestone) {
48	48	if ($issueMilestone) {
49	49	return $issueMilestone->getTitle();
50	50	}
51	51
52	52	return;
53	53	},
54		- 'choice_value' => function ($issueMilestone) {
	54	+ 'choice_value' => function($issueMilestone) {
55	55	if ($issueMilestone) {
56	56	return $issueMilestone->getId();
57	57	}
		@@ -68,20 +68,20 @@ discard block
		block discarded – undo
68	68	))
69	69	->add('issueLabel', ChoiceType::class, array(
70	70	'choices' => $this->getIssueLabelChoices(),
71		- 'multiple' => true, // Multiple selection allowed
72		- 'expanded' => true, // Render as checkboxes
	71	+ 'multiple' => true, // Multiple selection allowed
	72	+ 'expanded' => true, // Render as checkboxes
73	73	//'property' => 'title', // Assuming that the entity has a "name" property
74	74	//'class' => 'VersionControl\GitControlBundle\Entity\IssueLabel',
75	75	'required' => false,
76	76	'choices_as_values' => true,
77		- 'choice_label' => function ($issueLabel) {
	77	+ 'choice_label' => function($issueLabel) {
78	78	if ($issueLabel) {
79	79	return $issueLabel->getTitle();
80	80	}
81	81
82	82	return;
83	83	},
84		- 'choice_value' => function ($issueLabel) {
	84	+ 'choice_value' => function($issueLabel) {
85	85	if ($issueLabel) {
86	86	return $issueLabel->getId();
87	87	}

		@@ -30,7 +30,7 @@
		block discarded – undo
30	30	$configuration = new Configuration();
31	31	$config = $this->processConfiguration($configuration, $configs);
32	32
33		- $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
	33	+ $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
34	34	$loader->load('services.yml');
35	35	}
36	36	}

		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	$this->authenticate();
66	66	$label = $this->client->api('projects')->addLabel($this->issueIntegrator->getProjectName(), array(
67	67	'name' => $issueLabel->getTitle(),
68		- 'color' => '#'.$issueLabel->getHexColor(),
	68	+ 'color' => '#' . $issueLabel->getHexColor(),
69	69	));
70	70
71	71	return $this->mapToEntity($label);
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	$label = $this->client->api('projects')->updateLabel($this->issueIntegrator->getProjectName(), array(
82	82	'name' => $issueLabel->getId(),
83	83	'new_name' => $issueLabel->getTitle(),
84		- 'color' => '#'.$issueLabel->getHexColor(),
	84	+ 'color' => '#' . $issueLabel->getHexColor(),
85	85	));
86	86
87	87	return $this->mapToEntity($label);

		@@ -33,18 +33,18 @@ discard block
		block discarded – undo
33	33	if ($projectIssueIntegratorGitlab && $projectIssueIntegratorGitlab instanceof \VersionControl\GitlabIssueBundle\Entity\ProjectIssueIntegratorGitlab) {
34	34	$form->add('projectName', GitlabProjectType::class, array(
35	35	'choices' => $this->getProjectChoices($projectIssueIntegratorGitlab),
36		- 'multiple' => false, // Multiple selection allowed
	36	+ 'multiple' => false, // Multiple selection allowed
37	37	'placeholder' => 'Choose a projecton Gitlab',
38	38	'required' => false,
39	39	'choices_as_values' => true,
40		- 'choice_label' => function ($gitLabProject) {
	40	+ 'choice_label' => function($gitLabProject) {
41	41	if ($gitLabProject) {
42	42	return $gitLabProject->getName();
43	43	}
44	44
45	45	return;
46	46	},
47		- 'choice_value' => function ($gitLabProject) {
	47	+ 'choice_value' => function($gitLabProject) {
48	48	if ($gitLabProject) {
49	49	return $gitLabProject->getId();
50	50	}
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58
59	59	protected function getProjectChoices(\VersionControl\GitlabIssueBundle\Entity\ProjectIssueIntegratorGitlab $projectIssueIntegrator)
60	60	{
61		- $client = new \Gitlab\Client(rtrim($projectIssueIntegrator->getUrl(), '/').'/api/v3/'); // change here
	61	+ $client = new \Gitlab\Client(rtrim($projectIssueIntegrator->getUrl(), '/') . '/api/v3/'); // change here
62	62	$client->authenticate($projectIssueIntegrator->getApiToken(), \Gitlab\Client::AUTH_URL_TOKEN);
63	63	$choices = array();
64	64	$dataResponse = $client->api('projects')->all(1, 200);

		@@ -74,7 +74,7 @@
		block discarded – undo
74	74
75	75	if (null !== $this->logger) {
76	76	$message = sprintf('%s (%s) %0.2f ms', $command, $method, $time * 1000);
77		- $this->logger->info($message, (array)$data);
	77	+ $this->logger->info($message, (array) $data);
78	78	}
79	79	}
80	80

SSHVersionControl / git-web-client

Push — master ( 051175...ba50f0 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch