TestJobGenerator.test_add_pbs_flags_invalid() - Code Metrics - Inspection of "Merge pull request #122 from mgermain/pbsflags" - SMART-Lab/smartdispatch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 981c14...d395f4 )

by Marc-Alexandre

created 2016-04-15 15:27 UTC

TestJobGenerator.test_add_pbs_flags_invalid() A

↳ Parent: TestJobGenerator

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	1
dl	0
loc	2
rs	10

from nose.tools import assert_true, assert_false, assert_equal, assert_raises

import os
import tempfile
import shutil
from smartdispatch.queue import Queue
from smartdispatch.job_generator import JobGenerator, job_generator_factory
from smartdispatch.job_generator import HeliosJobGenerator, HadesJobGenerator
from smartdispatch.job_generator import GuilliminJobGenerator, MammouthJobGenerator


class TestJobGenerator(object):
    pbs_flags = ['-lfeature=k80', '-lwalltime=42:42', '-lnodes=6:gpus=66', '-m', '-A123-asd-11', '-t10,20,30']

    def setUp(self):
        self.testing_dir = tempfile.mkdtemp()
        self.cluster_name = "skynet"
        self.name = "9000@hal"
        self.walltime = "10:00"
        self.cores = 42
        self.gpus = 42
        self.mem_per_node = 32
        self.modules = ["cuda", "python"]

        self.queue = Queue(self.name, self.cluster_name, self.walltime, self.cores, 0, self.mem_per_node, self.modules)
        self.queue_gpu = Queue(self.name, self.cluster_name, self.walltime, self.cores, self.gpus, self.mem_per_node, self.modules)

        self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]

    def tearDown(self):
        shutil.rmtree(self.testing_dir)

    def test_generate_pbs(self):
        job_generator = JobGenerator(self.queue, self.commands)

        # Test nb_cores_per_command argument
        # Should needs one PBS file
        assert_equal(len(job_generator.pbs_list), 1)
        assert_equal(job_generator.pbs_list[0].commands, self.commands)

    def test_generate_pbs2_cpu(self):

        # Should needs two PBS file
        command_params = {'nb_cores_per_command': self.cores // 2}
        job_generator = JobGenerator(self.queue, self.commands, command_params)
        assert_equal(len(job_generator.pbs_list), 2)
        assert_equal(job_generator.pbs_list[0].commands, self.commands[:2])
        assert_equal(job_generator.pbs_list[1].commands, self.commands[2:])

    def test_generate_pbs4_cpu(self):
        # Should needs four PBS file
        command_params = {'nb_cores_per_command': self.cores}
        job_generator = JobGenerator(self.queue, self.commands, command_params)
        assert_equal(len(job_generator.pbs_list), 4)
        assert_equal([pbs.commands[0] for pbs in job_generator.pbs_list], self.commands)

        # Since queue has no gpus it should not be specified in PBS resource `nodes`
        assert_true('gpus' not in job_generator.pbs_list[0].resources['nodes'])

        # Test modules to load
        # Check if needed modules for this queue are included in the PBS file
        assert_equal(job_generator.pbs_list[0].modules, self.modules)

    def test_generate_pbs2_gpu(self):

        # Test nb_gpus_per_command argument
        # Should needs two PBS file
        command_params = {'nb_gpus_per_command': self.gpus // 2}
        job_generator = JobGenerator(self.queue_gpu, self.commands, command_params)
        assert_equal(len(job_generator.pbs_list), 2)
        assert_equal(job_generator.pbs_list[0].commands, self.commands[:2])
        assert_equal(job_generator.pbs_list[1].commands, self.commands[2:])

    def test_generate_pbs4_gpu(self):
        # Should needs four PBS files
        command_params = {'nb_gpus_per_command': self.gpus}
        job_generator = JobGenerator(self.queue_gpu, self.commands, command_params)
        assert_equal(len(job_generator.pbs_list), 4)
        assert_equal([pbs.commands[0] for pbs in job_generator.pbs_list], self.commands)

        # Since queue has gpus it should be specified in PBS resource `nodes`
        assert_true('gpus' in job_generator.pbs_list[0].resources['nodes'])

        # Test modules to load
        # Check if needed modules for this queue are included in the PBS file
        assert_equal(job_generator.pbs_list[0].modules, self.modules)

    def test_write_pbs_files(self):
        commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
        command_params = {'nb_cores_per_command': self.cores}
        job_generator = JobGenerator(self.queue, commands, command_params)
        filenames = job_generator.write_pbs_files(self.testing_dir)
        assert_equal(len(filenames), 4)

    def _test_add_pbs_flags(self, flags):
        job_generator = JobGenerator(self.queue, self.commands)
        job_generator.add_pbs_flags(flags)

        resources = []
        options = []

        for flag in flags:
            if flag.startswith('-l'):
                resources += [flag[:2] + ' ' + flag[2:]]
            elif flag.startswith('-'):
                options += [(flag[:2] + ' ' + flag[2:]).strip()]

        for pbs in job_generator.pbs_list:
            pbs_str = pbs.__str__()
            for flag in resources:
                assert_equal(pbs_str.count(flag), 1)
                assert_equal(pbs_str.count(flag[:flag.find('=')]), 1)
            for flag in options:
                assert_equal(pbs_str.count(flag), 1)

    def test_add_pbs_flags(self):
        for flag in self.pbs_flags:
            yield self._test_add_pbs_flags, [flag]

        yield self._test_add_pbs_flags, self.pbs_flags

    def test_add_pbs_flags_invalid(self):
        assert_raises(ValueError, self._test_add_pbs_flags, 'weeee')

    def test_add_pbs_flags_invalid_resource(self):
        assert_raises(ValueError, self._test_add_pbs_flags, '-l weeee')


class TestGuilliminQueue(object):

    def setUp(self):
        self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
        self.queue = Queue("test", "guillimin", "00:01", 1, 1, 1)

        self.bak_env_home_group = os.environ.get('HOME_GROUP')
        if self.bak_env_home_group is not None:
            del os.environ['HOME_GROUP']

    def tearDown(self):
        if self.bak_env_home_group is not None:
            os.environ['HOME_GROUP'] = self.bak_env_home_group

    def test_generate_pbs_no_home(self):
        assert_raises(ValueError, GuilliminJobGenerator, self.queue, self.commands)

    def test_generate_pbs(self):
        os.environ['HOME_GROUP'] = "/path/to/group"
        job_generator = GuilliminJobGenerator(self.queue, self.commands)
        pbs = job_generator.pbs_list[0]
        assert_true("-A" in pbs.options)
        assert_true(pbs.options["-A"] == 'group')


class TestMammouthQueue(object):

    def setUp(self):
        self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
        self.queue = Queue("qtest@mp2", "mammouth")

    def test_generate_pbs(self):
        job_generator = MammouthJobGenerator(self.queue, self.commands)

        assert_true("ppn=1" in str(job_generator.pbs_list[0]))


class TestHeliosQueue(object):

    def setUp(self):
        self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
        self.queue = Queue("gpu_8", "helios")

        self._home_backup = os.environ['HOME']
        os.environ['HOME'] = tempfile.mkdtemp()

        self.rap_filename = os.path.join(os.environ['HOME'], ".default_rap")
        if os.path.isfile(self.rap_filename):
            raise Exception("Test fail: {} should not be there.".format(self.rap_filename))
        else:
            self.rapid = 'asd-123-ab'
            with open(self.rap_filename, 'w+') as rap_file:
                rap_file.write(self.rapid)

        self.job_generator = HeliosJobGenerator(self.queue, self.commands)

    def tearDown(self):
        shutil.rmtree(os.environ['HOME'])
        os.environ['HOME'] = self._home_backup

    def test_generate_pbs_invalid_group(self):
        os.remove(self.rap_filename)

        assert_raises(ValueError, HeliosJobGenerator, self.queue, self.commands)

    def test_generate_pbs_valid_group(self):
        pbs = self.job_generator.pbs_list[0]

        assert_equal(pbs.options['-A'], self.rapid)

    def test_generate_pbs_ppn_is_absent(self):
        assert_false("ppn=" in str(self.job_generator.pbs_list[0]))

    def test_generate_pbs_even_nb_commands(self):
        assert_true("gpus=4" in str(self.job_generator.pbs_list[0]))

    def test_generate_pbs_odd_nb_commands(self):
        commands = ["echo 1", "echo 2", "echo 3", "echo 4", "echo 5"]
        job_generator = HeliosJobGenerator(self.queue, commands)

        assert_true("gpus=5" in str(job_generator.pbs_list[0]))


class TestHadesQueue(object):

    def setUp(self):
        self.queue = Queue("@hades", "hades")

        self.commands4 = ["echo 1", "echo 2", "echo 3", "echo 4"]
        job_generator = HadesJobGenerator(self.queue, self.commands4)
        self.pbs4 = job_generator.pbs_list

        # 8 commands chosen because there is 8 cores but still should be split because there is 6 gpu
        self.commands8 = ["echo 1", "echo 2", "echo 3", "echo 4", "echo 5", "echo 6", "echo 7", "echo 8"]
        job_generator = HadesJobGenerator(self.queue, self.commands8)
        self.pbs8 = job_generator.pbs_list

    def test_generate_pbs_ppn(self):
        assert_true("ppn={}".format(len(self.commands4)) in str(self.pbs4[0]))

    def test_generate_pbs_no_gpus_used(self):
        # Hades use ppn instead og the gpus flag and breaks if gpus is there
        assert_false("gpus=" in str(self.pbs4[0]))

    def test_pbs_split_1_job(self):
        assert_equal(len(self.pbs4), 1)

    def test_pbs_split_2_job(self):
        assert_equal(len(self.pbs8), 2)

    def test_pbs_split_2_job_nb_commands(self):
        assert_true("ppn=6" in str(self.pbs8[0]))
        assert_true("ppn=2" in str(self.pbs8[1]))


class TestJobGeneratorFactory(object):

    def setUp(self):
        self._home_backup = os.environ['HOME']
        os.environ['HOME'] = tempfile.mkdtemp()

        self.rap_filename = os.path.join(os.environ['HOME'], ".default_rap")
        if os.path.isfile(self.rap_filename):
            raise Exception("Test fail: {} should not be there.".format(self.rap_filename))
        else:
            self.rapid = 'asd-123-ab'
            with open(self.rap_filename, 'w+') as rap_file:
                rap_file.write(self.rapid)

    def tearDown(self):
        shutil.rmtree(os.environ['HOME'])
        os.environ['HOME'] = self._home_backup

    def _test_job_generator_factory(self, cluster_name, job_generator_class):
        q = Queue("test", cluster_name, 1, 1, 1, 1)
        job_generator = job_generator_factory(q, [], cluster_name=cluster_name)
        assert_true(isinstance(job_generator, job_generator_class))
        assert_true(type(job_generator) is job_generator_class)

    def test_job_generator_factory(self):
        clusters = [("guillimin", GuilliminJobGenerator),
                    ("mammouth", MammouthJobGenerator),
                    ("helios", HeliosJobGenerator),
                    ("hades", HadesJobGenerator),
                    (None, JobGenerator)]

        for cluster_name, job_generator_class in clusters:
            yield self._test_job_generator_factory, cluster_name, job_generator_class


1		from nose.tools import assert_true, assert_false, assert_equal, assert_raises
2
3		import os
4		import tempfile
5		import shutil
6		from smartdispatch.queue import Queue
7		from smartdispatch.job_generator import JobGenerator, job_generator_factory
8		from smartdispatch.job_generator import HeliosJobGenerator, HadesJobGenerator
9		from smartdispatch.job_generator import GuilliminJobGenerator, MammouthJobGenerator
10
11
12		class TestJobGenerator(object):
13		pbs_flags = ['-lfeature=k80', '-lwalltime=42:42', '-lnodes=6:gpus=66', '-m', '-A123-asd-11', '-t10,20,30']
14
15		def setUp(self):
16		self.testing_dir = tempfile.mkdtemp()
17		self.cluster_name = "skynet"
18		self.name = "9000@hal"
19		self.walltime = "10:00"
20		self.cores = 42
21		self.gpus = 42
22		self.mem_per_node = 32
23		self.modules = ["cuda", "python"]
24
25		self.queue = Queue(self.name, self.cluster_name, self.walltime, self.cores, 0, self.mem_per_node, self.modules)
26		self.queue_gpu = Queue(self.name, self.cluster_name, self.walltime, self.cores, self.gpus, self.mem_per_node, self.modules)
27
28		self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
29
30		def tearDown(self):
31		shutil.rmtree(self.testing_dir)
32
33		def test_generate_pbs(self):
34		job_generator = JobGenerator(self.queue, self.commands)
35
36		# Test nb_cores_per_command argument
37		# Should needs one PBS file
38		assert_equal(len(job_generator.pbs_list), 1)
39		assert_equal(job_generator.pbs_list[0].commands, self.commands)
40
41	View Code Duplication	def test_generate_pbs2_cpu(self):
		0 ignored issues – show Duplication introduced 2016-04-14 20:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
42		# Should needs two PBS file
43		command_params = {'nb_cores_per_command': self.cores // 2}
44		job_generator = JobGenerator(self.queue, self.commands, command_params)
45		assert_equal(len(job_generator.pbs_list), 2)
46		assert_equal(job_generator.pbs_list[0].commands, self.commands[:2])
47		assert_equal(job_generator.pbs_list[1].commands, self.commands[2:])
48
49		def test_generate_pbs4_cpu(self):
50		# Should needs four PBS file
51		command_params = {'nb_cores_per_command': self.cores}
52		job_generator = JobGenerator(self.queue, self.commands, command_params)
53		assert_equal(len(job_generator.pbs_list), 4)
54		assert_equal([pbs.commands[0] for pbs in job_generator.pbs_list], self.commands)
55
56		# Since queue has no gpus it should not be specified in PBS resource `nodes`
57		assert_true('gpus' not in job_generator.pbs_list[0].resources['nodes'])
58
59		# Test modules to load
60		# Check if needed modules for this queue are included in the PBS file
61		assert_equal(job_generator.pbs_list[0].modules, self.modules)
62
63	View Code Duplication	def test_generate_pbs2_gpu(self):
		0 ignored issues – show Duplication introduced 2016-04-14 20:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
64		# Test nb_gpus_per_command argument
65		# Should needs two PBS file
66		command_params = {'nb_gpus_per_command': self.gpus // 2}
67		job_generator = JobGenerator(self.queue_gpu, self.commands, command_params)
68		assert_equal(len(job_generator.pbs_list), 2)
69		assert_equal(job_generator.pbs_list[0].commands, self.commands[:2])
70		assert_equal(job_generator.pbs_list[1].commands, self.commands[2:])
71
72		def test_generate_pbs4_gpu(self):
73		# Should needs four PBS files
74		command_params = {'nb_gpus_per_command': self.gpus}
75		job_generator = JobGenerator(self.queue_gpu, self.commands, command_params)
76		assert_equal(len(job_generator.pbs_list), 4)
77		assert_equal([pbs.commands[0] for pbs in job_generator.pbs_list], self.commands)
78
79		# Since queue has gpus it should be specified in PBS resource `nodes`
80		assert_true('gpus' in job_generator.pbs_list[0].resources['nodes'])
81
82		# Test modules to load
83		# Check if needed modules for this queue are included in the PBS file
84		assert_equal(job_generator.pbs_list[0].modules, self.modules)
85
86		def test_write_pbs_files(self):
87		commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
88		command_params = {'nb_cores_per_command': self.cores}
89		job_generator = JobGenerator(self.queue, commands, command_params)
90		filenames = job_generator.write_pbs_files(self.testing_dir)
91		assert_equal(len(filenames), 4)
92
93		def _test_add_pbs_flags(self, flags):
94		job_generator = JobGenerator(self.queue, self.commands)
95		job_generator.add_pbs_flags(flags)
96
97		resources = []
98		options = []
99
100		for flag in flags:
101		if flag.startswith('-l'):
102		resources += [flag[:2] + ' ' + flag[2:]]
103		elif flag.startswith('-'):
104		options += [(flag[:2] + ' ' + flag[2:]).strip()]
105
106		for pbs in job_generator.pbs_list:
107		pbs_str = pbs.__str__()
108		for flag in resources:
109		assert_equal(pbs_str.count(flag), 1)
110		assert_equal(pbs_str.count(flag[:flag.find('=')]), 1)
111		for flag in options:
112		assert_equal(pbs_str.count(flag), 1)
113
114		def test_add_pbs_flags(self):
115		for flag in self.pbs_flags:
116		yield self._test_add_pbs_flags, [flag]
117
118		yield self._test_add_pbs_flags, self.pbs_flags
119
120		def test_add_pbs_flags_invalid(self):
121		assert_raises(ValueError, self._test_add_pbs_flags, 'weeee')
122
123		def test_add_pbs_flags_invalid_resource(self):
124		assert_raises(ValueError, self._test_add_pbs_flags, '-l weeee')
125
126
127		class TestGuilliminQueue(object):
128
129		def setUp(self):
130		self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
131		self.queue = Queue("test", "guillimin", "00:01", 1, 1, 1)
132
133		self.bak_env_home_group = os.environ.get('HOME_GROUP')
134		if self.bak_env_home_group is not None:
135		del os.environ['HOME_GROUP']
136
137		def tearDown(self):
138		if self.bak_env_home_group is not None:
139		os.environ['HOME_GROUP'] = self.bak_env_home_group
140
141		def test_generate_pbs_no_home(self):
142		assert_raises(ValueError, GuilliminJobGenerator, self.queue, self.commands)
143
144		def test_generate_pbs(self):
145		os.environ['HOME_GROUP'] = "/path/to/group"
146		job_generator = GuilliminJobGenerator(self.queue, self.commands)
147		pbs = job_generator.pbs_list[0]
148		assert_true("-A" in pbs.options)
149		assert_true(pbs.options["-A"] == 'group')
150
151
152		class TestMammouthQueue(object):
153
154		def setUp(self):
155		self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
156		self.queue = Queue("qtest@mp2", "mammouth")
157
158		def test_generate_pbs(self):
159		job_generator = MammouthJobGenerator(self.queue, self.commands)
160
161		assert_true("ppn=1" in str(job_generator.pbs_list[0]))
162
163
164		class TestHeliosQueue(object):
165
166		def setUp(self):
167		self.commands = ["echo 1", "echo 2", "echo 3", "echo 4"]
168		self.queue = Queue("gpu_8", "helios")
169
170		self._home_backup = os.environ['HOME']
171		os.environ['HOME'] = tempfile.mkdtemp()
172
173		self.rap_filename = os.path.join(os.environ['HOME'], ".default_rap")
174		if os.path.isfile(self.rap_filename):
175		raise Exception("Test fail: {} should not be there.".format(self.rap_filename))
176		else:
177		self.rapid = 'asd-123-ab'
178		with open(self.rap_filename, 'w+') as rap_file:
179		rap_file.write(self.rapid)
180
181		self.job_generator = HeliosJobGenerator(self.queue, self.commands)
182
183		def tearDown(self):
184		shutil.rmtree(os.environ['HOME'])
185		os.environ['HOME'] = self._home_backup
186
187		def test_generate_pbs_invalid_group(self):
188		os.remove(self.rap_filename)
189
190		assert_raises(ValueError, HeliosJobGenerator, self.queue, self.commands)
191
192		def test_generate_pbs_valid_group(self):
193		pbs = self.job_generator.pbs_list[0]
194
195		assert_equal(pbs.options['-A'], self.rapid)
196
197		def test_generate_pbs_ppn_is_absent(self):
198		assert_false("ppn=" in str(self.job_generator.pbs_list[0]))
199
200		def test_generate_pbs_even_nb_commands(self):
201		assert_true("gpus=4" in str(self.job_generator.pbs_list[0]))
202
203		def test_generate_pbs_odd_nb_commands(self):
204		commands = ["echo 1", "echo 2", "echo 3", "echo 4", "echo 5"]
205		job_generator = HeliosJobGenerator(self.queue, commands)
206
207		assert_true("gpus=5" in str(job_generator.pbs_list[0]))
208
209
210		class TestHadesQueue(object):
211
212		def setUp(self):
213		self.queue = Queue("@hades", "hades")
214
215		self.commands4 = ["echo 1", "echo 2", "echo 3", "echo 4"]
216		job_generator = HadesJobGenerator(self.queue, self.commands4)
217		self.pbs4 = job_generator.pbs_list
218
219		# 8 commands chosen because there is 8 cores but still should be split because there is 6 gpu
220		self.commands8 = ["echo 1", "echo 2", "echo 3", "echo 4", "echo 5", "echo 6", "echo 7", "echo 8"]
221		job_generator = HadesJobGenerator(self.queue, self.commands8)
222		self.pbs8 = job_generator.pbs_list
223
224		def test_generate_pbs_ppn(self):
225		assert_true("ppn={}".format(len(self.commands4)) in str(self.pbs4[0]))
226
227		def test_generate_pbs_no_gpus_used(self):
228		# Hades use ppn instead og the gpus flag and breaks if gpus is there
229		assert_false("gpus=" in str(self.pbs4[0]))
230
231		def test_pbs_split_1_job(self):
232		assert_equal(len(self.pbs4), 1)
233
234		def test_pbs_split_2_job(self):
235		assert_equal(len(self.pbs8), 2)
236
237		def test_pbs_split_2_job_nb_commands(self):
238		assert_true("ppn=6" in str(self.pbs8[0]))
239		assert_true("ppn=2" in str(self.pbs8[1]))
240
241
242		class TestJobGeneratorFactory(object):
243
244		def setUp(self):
245		self._home_backup = os.environ['HOME']
246		os.environ['HOME'] = tempfile.mkdtemp()
247
248		self.rap_filename = os.path.join(os.environ['HOME'], ".default_rap")
249		if os.path.isfile(self.rap_filename):
250		raise Exception("Test fail: {} should not be there.".format(self.rap_filename))
251		else:
252		self.rapid = 'asd-123-ab'
253		with open(self.rap_filename, 'w+') as rap_file:
254		rap_file.write(self.rapid)
255
256		def tearDown(self):
257		shutil.rmtree(os.environ['HOME'])
258		os.environ['HOME'] = self._home_backup
259
260		def _test_job_generator_factory(self, cluster_name, job_generator_class):
261		q = Queue("test", cluster_name, 1, 1, 1, 1)
262		job_generator = job_generator_factory(q, [], cluster_name=cluster_name)
263		assert_true(isinstance(job_generator, job_generator_class))
264		assert_true(type(job_generator) is job_generator_class)
265
266		def test_job_generator_factory(self):
267		clusters = [("guillimin", GuilliminJobGenerator),
268		("mammouth", MammouthJobGenerator),
269		("helios", HeliosJobGenerator),
270		("hades", HadesJobGenerator),
271		(None, JobGenerator)]
272
273		for cluster_name, job_generator_class in clusters:
274		yield self._test_job_generator_factory, cluster_name, job_generator_class
275

SMART-Lab / smartdispatch

Push — master ( 981c14...d395f4 )

TestJobGenerator.test_add_pbs_flags_invalid() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like