sdoc.sdoc2.formatter.html.ReferenceHtmlFormatter - Code Metrics - Inspection of "Personal/oleg/sdoc-32" - SDoc/py-sdoc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

unknown

created 2016-03-15 11:47 UTC

sdoc.sdoc2.formatter.html.ReferenceHtmlFormatter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Metric	Value
dl	0
loc	18
rs	10
wmc	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	generate()	0	12	1

"""
SDoc

Copyright 2016 Set Based IT Consultancy

Licence MIT
"""
# ----------------------------------------------------------------------------------------------------------------------
from sdoc.helper.Html import Html
from sdoc.sdoc2 import node_store
from sdoc.sdoc2.formatter.html.HtmlFormatter import HtmlFormatter


class ReferenceHtmlFormatter(HtmlFormatter):
    """
    HtmlFormatter for generating HTML code for references.
    """

    # ------------------------------------------------------------------------------------------------------------------
    def generate(self, node, file):
        """
        Generates the HTML code for a reference node.

        :param sdoc.sdoc2.node.ReferenceNode.ReferenceNode node: The reference node.
        :param file file: The output file.
        """
        attributes = {'href': node.get_option_value('href')}

        file.write(Html.generate_element('a', attributes, node._argument))
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        super().generate(node, file)

# ----------------------------------------------------------------------------------------------------------------------
node_store.register_formatter('ref', 'html', ReferenceHtmlFormatter)


1			"""
2			SDoc
3
4			Copyright 2016 Set Based IT Consultancy
5
6			Licence MIT
7			"""
8			# ----------------------------------------------------------------------------------------------------------------------
9			from sdoc.helper.Html import Html
10			from sdoc.sdoc2 import node_store
11			from sdoc.sdoc2.formatter.html.HtmlFormatter import HtmlFormatter
12
13
14			class ReferenceHtmlFormatter(HtmlFormatter):
15			"""
16			HtmlFormatter for generating HTML code for references.
17			"""
18
19			# ------------------------------------------------------------------------------------------------------------------
20			def generate(self, node, file):
21			"""
22			Generates the HTML code for a reference node.
23
24			:param sdoc.sdoc2.node.ReferenceNode.ReferenceNode node: The reference node.
25			:param file file: The output file.
26			"""
27			attributes = {'href': node.get_option_value('href')}
28
29			file.write(Html.generate_element('a', attributes, node._argument))
			0 ignored issues – show Coding Style Best Practice introduced 2016-03-15 11:48 UTC by Report Bug Copy Issue Report It seems like `_argument` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
30
31			super().generate(node, file)
32
33			# ----------------------------------------------------------------------------------------------------------------------
34			node_store.register_formatter('ref', 'html', ReferenceHtmlFormatter)
35

SDoc / py-sdoc

Pull Request — master (#17)

sdoc.sdoc2.formatter.html.ReferenceHtmlFormatter A

Complexity

Size/Duplication

1 Method

Duplication Side-by-Side

Filter issues like