SDIS62\Core\User\Entity\Profile\Sdis\SapeurPompierSdisProfile

Complexity

Total Complexity

3

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	isPro()	0	4	1
A	setPro()	0	6	1

<?php

namespace SDIS62\Core\User\Entity\Profile\Sdis;

use SDIS62\Core\User\Entity\User;
use SDIS62\Core\User\Entity\Profile\SdisProfile;

class SapeurPompierSdisProfile extends SdisProfile
{
    /**
     * Type du profil
     *
     * @var string
     */
    protected $type = 'sapeur_pompier';

    /**
     * Pro ou volontaire ?
     *
     * @var bool
     */
    protected $is_pro;

    /*
    * Constructeur
    *
    * @param SDIS62\Core\User\Entity\User $user
    * @param Sstring $grade
    * @param string $poste
    * @param bool $pro Optionnel
    */
    public function __construct(User $user, $grade, $poste, $pro = false)
    {
        $this->is_pro = $pro;

        parent::__construct($user, $grade, $poste);
    }

    /**
     * Get the value of Pro ou volontaire ?
     *
     * @return bool
     */
    public function isPro()
    {
        return $this->is_pro == true;

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

    }

    /**
     * Set the value of Pro ou volontaire ?
     *
     * @param bool is_pro
     *
     * @return self
     */
    public function setPro($value = true)
    {
        $this->is_pro = $value == true;

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        return $this;
    }
}